AI-generated analysisPublished automatically and not human-verified. Validated context appears in community notes below.
← Watch feed
High 80 Monero

verify legacy inputs

Public commit record

What the developer wrote

Authored by Julian

53/100 · Thin
verify legacy inputs

Co-authored-by: sneurlax <sneurlax@gmail.com>
✓ Subject identifies a change✓ Provides an explanatory body✓ Mentions testing or verification
The short version

What changed, and why it matters

This commit adds cryptographic checks that make sure transaction data coming from ElectrumX servers really was signed by the user's wallet and matches the amounts the wallet expects. Before this change, a malicious or buggy server could lie about a coin's value, a pending transaction's size, or even invent a fake spend that the wallet would trust. The fix verifies raw transaction bytes, checks signatures, and for older 'legacy' P2PKH inputs it also fetches and checks the parent transaction to confirm the amount. If verification fails, the wallet now blocks the coin or drops the unverified transaction instead of using it.

Recommended action

Treat this as a security-hardening fix and include it in the next release. Review that all ElectrumX-based coin integrations call verifyPendingSpend for pending spends and authenticatedP2pkhOutput for legacy P2PKH UTXOs. Ensure the new coin-specific layout flags are correctly set for any additional coins added later. Run the new test suites (owned_input_signatures_test, raw_transaction_layouts_test, replacement_fee_test) in CI.

Security signals we found

01

Server-supplied transaction sizes/values were used without cryptographic verification

02

Legacy P2PKH inputs do not commit to spent amount in signature hash, enabling value misreporting

03

RBF bump fees could be computed from attacker-controlled size metadata

04

New code verifies raw tx bytes hash to claimed txid and signatures are SIGHASH_ALL

05

Parent transactions are fetched and parsed to authenticate legacy input amounts

06

Unverified transactions are dropped and unverified UTXOs are blocked

07

Tests include forged-output, misreported-value, and malformed-transaction rejection cases

Risk score

Why this scored 80/100

Our methodology →
Potential impact 24/30
Exploitability 18/25
Stealth signal 12/15
Affected reach 14/15
Confidence 8/10
Evidence quality 4/5
Human-validated context

Community notes

Notes can correct, qualify, or add evidence to the AI analysis. Every note shown here has been validated by a human moderator.

No validated notes yet.

The AI analysis stands alone for now. Submit a note if you can add evidence or important context.