AI-generated analysisPublished automatically and not human-verified. Validated context appears in community notes below.
← Watch feed
Low 34 Monero

clean up replaced eth transactions

Public commit record

What the developer wrote

Authored by Julian

45/100 · Thin
clean up replaced eth transactions
✓ Descriptive subject✓ Names a concrete action or component! No meaningful explanatory body
The short version

What changed, and why it matters

This commit adds a cleanup routine for Ethereum transactions that were replaced by another transaction with the same nonce. In Ethereum, if you send a second transaction with the same sequence number (nonce) but a higher fee, the first one can be dropped by the network. Stack Wallet previously kept these dropped transactions visible as 'pending' forever. The new code detects them by checking the blockchain and removes them from the local transaction list. It is a bug-fix/quality improvement rather than an active remote hack vulnerability.

Recommended action

Treat as a routine reliability fix. Reviewers should verify that the nonce comparison (transaction.nonce >= latestConfirmedNonce continue; else consider replaced) correctly handles reorgs and that getTransactionByHash returning a transaction with blockHash == null is a reliable signal of a replaced transaction on the target RPC providers. Consider whether silently deleting records could hide transactions that are merely temporarily unavailable from the node.

Security signals we found

01

Data-consistency bug fix: stale pending Ethereum transactions could mislead users about balance and transaction state

02

Relies on external node RPC (getTransactionCount + getTransactionByHash); node errors are logged and cause preservation of pending records

03

Deletion is scoped to pending transactions with non-null nonce belonging to the wallet

04

No input from untrusted users is used in the deletion query beyond already-stored transaction records

Risk score

Why this scored 34/100

Our methodology →
Potential impact 8/30
Exploitability 3/25
Stealth signal 6/15
Affected reach 7/15
Confidence 7/10
Evidence quality 3/5
Human-validated context

Community notes

Notes can correct, qualify, or add evidence to the AI analysis. Every note shown here has been validated by a human moderator.

No validated notes yet.

The AI analysis stands alone for now. Submit a note if you can add evidence or important context.