AI-generated analysisPublished automatically and not human-verified. Validated context appears in community notes below.
← Watch feed
Low 34 Monero

Merge pull request #1511 from Cyrix126/share_send_fee_logic

Public commit record

What the developer wrote

Authored by Julian

73/100 · Adequate
Merge pull request #1511 from Cyrix126/share_send_fee_logic

refactor: share the send fee logic across send's view
✓ Specific, descriptive subject✓ Names a concrete action or component✓ Provides an explanatory body✓ Links an issue, advisory, or supporting reference
The short version

What changed, and why it matters

This is a large code refactor that moves fee-calculation logic out of individual send screens into shared providers and helper classes. The goal is to make the send fee UI behave consistently across mobile, desktop, token, and Solana token sends. The diff itself is mostly cleanup and consolidation; it does not obviously add or remove security checks, but any refactor touching transaction-fee handling deserves a careful look because mistakes here could affect how much fee a user pays or whether a transaction is constructed correctly.

Recommended action

Treat this as a high-touch refactor requiring focused review and regression testing. Verify that the shared fee provider preserves the exact fee-estimate behavior for each coin type, especially Monero/Wownero priority mapping, Firo public/private/OP_RETURN handling, Solana token fallback fee, and Ethereum custom EIP-1559. Run the new and existing send-view tests, and perform manual end-to-end sends on testnet/mainnet for at least one UTXO coin, one Cryptonote coin, Firo public/private, one ERC-20 token, and one Solana token. Check that custom fee rates cannot be carried over incorrectly between send forms and that the fee displayed before preview matches the fee used when building the transaction.

Security signals we found

01

Refactor of transaction fee estimation and selection UI across all send flows

02

Consolidation of wallet-specific fee logic (Cryptonote priorities, Firo Spark/public/OP_RETURN, Solana token fallback, Ethereum custom EIP-1559) into shared providers

03

Removal of per-view fee caches and timers; replacement with shared debounce/focus-loss retry logic

04

Change in how custom fee rate state is reset when a send form is opened (now resets to Average on desktop, Slow for Solana token)

05

New `CalculatingFutureBuilder` widget used for fee display, replacing inline `FutureBuilder` + `AnimatedText` patterns

06

Addition of unit/widget tests for send fee providers and forms

Risk score

Why this scored 34/100

Our methodology →
Potential impact 5/30
Exploitability 5/25
Stealth signal 5/15
Affected reach 10/15
Confidence 6/10
Evidence quality 3/5
Human-validated context

Community notes

Notes can correct, qualify, or add evidence to the AI analysis. Every note shown here has been validated by a human moderator.

No validated notes yet.

The AI analysis stands alone for now. Submit a note if you can add evidence or important context.