fix(shopinbit): remove unused customerKey field from ApiResponse
What the developer wrote
Authored by sneurlax
fix(shopinbit): remove unused customerKey field from ApiResponse
What changed, and why it matters
This commit removes an unused field called customerKey from a data structure used when the app talks to the ShopInBit service. There is no security fix here; it is a small cleanup that deletes dead code.
No security action needed. Treat as routine code cleanup.
Security signals we found
No strong security signals were identified.
Evidence from the diff
The patch deletes the customerKey property from the ApiResponse
Changed components
lib/services/shopinbit/src/api_response.dartlib/services/shopinbit/src/client.dartInspect captured patch +2 / −3
diff --git a/lib/services/shopinbit/src/api_response.dart b/lib/services/shopinbit/src/api_response.dart
index 623afc3..a1e9135 100644
--- a/lib/services/shopinbit/src/api_response.dart
+++ b/lib/services/shopinbit/src/api_response.dart
@@ -3,9 +3,8 @@ import 'api_exception.dart';
class ApiResponse<T> {
final T? value;
final ApiException? exception;
- final String? customerKey;
- ApiResponse({this.value, this.exception, this.customerKey});
+ ApiResponse({this.value, this.exception});
bool get hasError => exception != null;
diff --git a/lib/services/shopinbit/src/client.dart b/lib/services/shopinbit/src/client.dart
index c475cfe..f5c46c3 100644
--- a/lib/services/shopinbit/src/client.dart
+++ b/lib/services/shopinbit/src/client.dart
@@ -773,7 +773,7 @@ class ShopInBitClient {
);
}
final json = jsonDecode(response.body) as Map<String, dynamic>;
- return ApiResponse(value: parse(json), customerKey: customerKey);
+ return ApiResponse(value: parse(json));
} else {
Logging.instance.w(
"$_kTag $method $resolved HTTP:${response.code} "
Why this scored 15/100
Community notes
Notes can correct, qualify, or add evidence to the AI analysis. Every note shown here has been validated by a human moderator.
The AI analysis stands alone for now. Submit a note if you can add evidence or important context.