refactor(openalias): share the lookup between the send views
What changed, and why it matters
This commit is a code cleanup that moves the OpenAlias lookup logic into a shared service so both the mobile and desktop send screens use the same implementation. There is no direct evidence in the commit that it fixes a security vulnerability; it appears to be a refactoring change with added unit tests.
No immediate action required. Treat as routine refactoring. If auditing, verify that the shared OpenAliasService correctly preserves prior validation behavior and that the new sealed outcome class does not accidentally suppress error logging.
Security signals we found
Refactoring only: no new network calls, no new permissions, no cryptographic changes
Shared normalization of alias input via openAliasKey()
Centralized cancellation state to avoid race between cancel and result
No explicit security claim in commit title or message
Evidence from the diff
The change refactors OpenAlias resolution by introducing an OpenAliasService.resolve() method that returns a sealed OpenAliasOutcome (resolved/failed/cancelled). Both send_view.dart and desktop_send.dart are updated to call this shared method instead of duplicating the lookup/cancel/error-handling logic. The service now normalizes the alias key (trim + lowercase) centrally and surfaces failure messages consistently. Unit tests cover success, failure, cancellation, and incognito-mode cases.
Changed components
lib/services/openalias/open_alias_service.dartlib/pages/send_view/send_view.dartlib/pages_desktop_specific/my_stack_view/wallet_view/sub_widgets/desktop_send.dartInspect captured patch +263 / −70
### lib/pages/send_view/send_view.dart
@@ -1025,9 +1025,14 @@ class _SendViewState extends ConsumerState<SendView> {
/// to. Returns the alias, trimmed and lowercased, or null if the lookup
/// failed or was cancelled.
Future<String?> _resolveOpenAlias(String application) async {
- final alias = _address!.trim().toLowerCase();
- CsOpenAliasOperation<CsOpenAliasRecipient>? operation;
- bool cancelled = false;
+ final resolution = ref
+ .read(pOpenAliasService)
+ .resolve(
+ _address!,
+ isValidAddress: coin.validateAddress,
+ application: application,
+ coinName: coin.prettyName,
+ );
unawaited(
showDialog<void>(
context: context,
@@ -1037,44 +1042,32 @@ class _SendViewState extends ConsumerState<SendView> {
coin: coin,
isSpark: false,
onCancel: () {
- cancelled = true;
- operation?.cancel();
+ resolution.cancel();
Navigator.of(context).pop();
},
),
),
);
- try {
- operation = ref
- .read(pOpenAliasService)
- .lookup(
- _address!,
- isValidAddress: coin.validateAddress,
- application: application,
- );
- final address = (await operation.result).address;
- if (cancelled || !mounted) return null;
- Navigator.of(context, rootNavigator: true).pop();
- sendToController.text = address;
- _address = address;
- _setValidAddressProviders(_address);
- return alias;
- } catch (e, s) {
- if (cancelled || !mounted) return null;
- Logging.instance.w("OpenAlias lookup failed", error: e, stackTrace: s);
- Navigator.of(context, rootNavigator: true).pop();
- unawaited(
- showDialog<void>(
- context: context,
- builder: (context) => StackOkDialog(
- title: openAliasLookupFailedTitle,
- message: e is CsOpenAliasException
- ? openAliasErrorMessage(e, coin.prettyName)
- : e.toString(),
+ final outcome = await resolution.outcome;
+ if (!mounted) return null;
+ switch (outcome) {
+ case OpenAliasCancelled():
+ return null;
+ case OpenAliasResolved(:final alias, :final address):
+ Navigator.of(context, rootNavigator: true).pop();
+ sendToController.text = address;
+ _address = address;
+ _setValidAddressProviders(_address);
+ return alias;
+ case OpenAliasFailed(:final title, :final message):
+ Navigator.of(context, rootNavigator: true).pop();
+ unawaited(
+ showDialog<void>(
+ context: context,
+ builder: (context) => StackOkDialog(title: title, message: message),
),
- ),
- );
- return null;
+ );
+ return null;
}
}
### lib/pages_desktop_specific/my_stack_view/wallet_view/sub_widgets/desktop_send.dart
@@ -444,9 +444,14 @@ class _DesktopSendState extends ConsumerState<DesktopSend> {
/// to. Returns the alias, trimmed and lowercased, or null if the lookup
/// failed or was cancelled.
Future<String?> _resolveOpenAlias(String application) async {
- final alias = _address!.trim().toLowerCase();
- CsOpenAliasOperation<CsOpenAliasRecipient>? operation;
- bool cancelled = false;
+ final resolution = ref
+ .read(pOpenAliasService)
+ .resolve(
+ _address!,
+ isValidAddress: coin.validateAddress,
+ application: application,
+ coinName: coin.prettyName,
+ );
unawaited(
showDialog<void>(
context: context,
@@ -461,46 +466,35 @@ class _DesktopSendState extends ConsumerState<DesktopSend> {
coin: coin,
isSpark: false,
onCancel: () {
- cancelled = true;
- operation?.cancel();
+ resolution.cancel();
Navigator.of(context).pop();
},
),
),
),
),
);
- try {
- operation = ref
- .read(pOpenAliasService)
- .lookup(
- _address!,
- isValidAddress: coin.validateAddress,
- application: application,
- );
- final address = (await operation.result).address;
- if (cancelled || !mounted) return null;
- Navigator.of(context, rootNavigator: true).pop();
- sendToController.text = address;
- _address = address;
- _setValidAddressProviders(_address);
- return alias;
- } catch (e, s) {
- if (cancelled || !mounted) return null;
- Logging.instance.w("OpenAlias lookup failed", error: e, stackTrace: s);
- Navigator.of(context, rootNavigator: true).pop();
- unawaited(
- showDialog<void>(
- context: context,
- builder: (context) => SimpleDesktopDialog(
- title: openAliasLookupFailedTitle,
- message: e is CsOpenAliasException
- ? openAliasErrorMessage(e, coin.prettyName)
- : e.toString(),
+ final outcome = await resolution.outcome;
+ if (!mounted) return null;
+ switch (outcome) {
+ case OpenAliasCancelled():
+ return null;
+ case OpenAliasResolved(:final alias, :final address):
+ Navigator.of(context, rootNavigator: true).pop();
+ sendToController.text = address;
+ _address = address;
+ _setValidAddressProviders(_address);
+ return alias;
+ case OpenAliasFailed(:final title, :final message):
+ Navigator.of(context, rootNavigator: true).pop();
+ unawaited(
+ showDialog<void>(
+ context: context,
+ builder: (context) =>
+ SimpleDesktopDialog(title: title, message: message),
),
- ),
- );
- return null;
+ );
+ return null;
}
}
### lib/services/openalias/open_alias_service.dart
@@ -4,6 +4,7 @@ import 'package:cs_openalias/cs_openalias.dart';
import 'package:flutter_riverpod/flutter_riverpod.dart';
import '../../app_config.dart';
+import '../../utilities/logger.dart';
import '../../utilities/prefs.dart';
import '../tor_service.dart';
@@ -28,6 +29,8 @@ String openAliasErrorMessage(CsOpenAliasException e, String coinName) =>
CsOpenAliasCancelledException() => 'OpenAlias lookup cancelled.',
};
+String openAliasKey(String input) => input.trim().toLowerCase();
+
typedef OpenAliasLookup = CsOpenAliasOperation<CsOpenAliasRecipient> Function(
String alias, {
required bool Function(String address) isValidAddress,
@@ -90,6 +93,19 @@ class OpenAliasService {
);
}
+ /// Starts [lookup] for the alias typed into a send field.
+ OpenAliasResolution resolve(
+ String input, {
+ required bool Function(String address) isValidAddress,
+ required String application,
+ required String coinName,
+ }) => OpenAliasResolution._(
+ () =>
+ lookup(input, isValidAddress: isValidAddress, application: application),
+ alias: openAliasKey(input),
+ coinName: coinName,
+ );
+
({String? unavailable, CsOpenAliasProxy? proxy}) _route() {
if (!_externalCalls()) {
return (
@@ -120,3 +136,66 @@ class OpenAliasService {
);
}
}
+
+sealed class OpenAliasOutcome {
+ const OpenAliasOutcome();
+}
+
+final class OpenAliasResolved extends OpenAliasOutcome {
+ const OpenAliasResolved({required this.alias, required this.address});
+
+ final String alias;
+ final String address;
+}
+
+final class OpenAliasFailed extends OpenAliasOutcome {
+ const OpenAliasFailed(this.message);
+
+ String get title => openAliasLookupFailedTitle;
+ final String message;
+}
+
+final class OpenAliasCancelled extends OpenAliasOutcome {
+ const OpenAliasCancelled();
+}
+
+/// A lookup started by [OpenAliasService.resolve].
+final class OpenAliasResolution {
+ OpenAliasResolution._(
+ CsOpenAliasOperation<CsOpenAliasRecipient> Function() start, {
+ required String alias,
+ required String coinName,
+ }) {
+ outcome = _run(start, alias, coinName);
+ }
+
+ late final Future<OpenAliasOutcome> outcome;
+ CsOpenAliasOperation<CsOpenAliasRecipient>? _operation;
+ bool _cancelled = false;
+
+ void cancel() {
+ _cancelled = true;
+ _operation?.cancel();
+ }
+
+ Future<OpenAliasOutcome> _run(
+ CsOpenAliasOperation<CsOpenAliasRecipient> Function() start,
+ String alias,
+ String coinName,
+ ) async {
+ try {
+ _operation = start();
+ final address = (await _operation!.result).address;
+ if (_cancelled) return const OpenAliasCancelled();
+ return OpenAliasResolved(alias: alias, address: address);
+ } catch (e, s) {
+ if (_cancelled) return const OpenAliasCancelled();
+ Logging.instance.w("OpenAlias lookup failed", error: e, stackTrace: s);
+ return OpenAliasFailed(
+ e is CsOpenAliasException
+ ? openAliasErrorMessage(e, coinName)
+ : e.toString(),
+ );
+ }
+ }
+}
### test/services/openalias/open_alias_service_test.dart
@@ -1,3 +1,4 @@
+import 'dart:async';
import 'dart:io';
import 'package:cs_openalias/cs_openalias.dart';
@@ -35,6 +36,20 @@ class _Calls {
}
}
+OpenAliasService _service(OpenAliasLookup lookup, {bool external = true}) =>
+ OpenAliasService(
+ externalCalls: () => external,
+ useTor: () => false,
+ lookup: lookup,
+ );
+
+OpenAliasResolution _resolve(OpenAliasService service) => service.resolve(
+ ' Alice@Example.com',
+ isValidAddress: (_) => true,
+ application: 'xmr',
+ coinName: 'Monero',
+);
+
void main() {
test('isOpenAlias accepts names and rejects addresses', () {
for (final input in ['Alice@Example.com', 'donate.getmonero.org.']) {
@@ -203,4 +218,116 @@ void main() {
expect(reads, 2);
expect(calls.aliases, hasLength(1));
});
+
+ group('resolve', () {
+ test('returns the normalized alias and the address', () async {
+ final aliases = <String>[];
+ final service = _service((
+ alias, {
+ required isValidAddress,
+ required application,
+ required proxy,
+ }) {
+ aliases.add(alias);
+ return CsOpenAliasOperation(
+ Future.value(
+ CsOpenAliasRecipient(
+ domain: 'alice.example.com',
+ address: 'resolved',
+ fields: const {'recipient_address': 'resolved'},
+ ),
+ ),
+ () {},
+ );
+ });
+ final outcome = await _resolve(service).outcome;
+ expect(aliases.single, ' Alice@Example.com');
+ expect(
+ outcome,
+ isA<OpenAliasResolved>()
+ .having((e) => e.alias, 'alias', 'alice@example.com')
+ .having((e) => e.address, 'address', 'resolved'),
+ );
+ });
+
+ test('a lookup failure becomes its user message', () async {
+ final service = _service((
+ alias, {
+ required isValidAddress,
+ required application,
+ required proxy,
+ }) {
+ return CsOpenAliasOperation(
+ Future.error(
+ const CsOpenAliasNoRecordException('', alias: 'alice.example.com'),
+ ),
+ () {},
+ );
+ });
+ final outcome = await _resolve(service).outcome;
+ expect(
+ outcome,
+ isA<OpenAliasFailed>()
+ .having((e) => e.title, 'title', openAliasLookupFailedTitle)
+ .having(
+ (e) => e.message,
+ 'message',
+ 'No Monero OpenAlias record was found for alice.example.com.',
+ ),
+ );
+ });
+
+ test('an unavailable lookup shows the reason', () async {
+ final calls = _Calls();
+ final outcome = await _resolve(_service(calls.lookup, external: false))
+ .outcome;
+ expect(
+ outcome,
+ isA<OpenAliasFailed>().having((e) => e.message, 'message', incognito),
+ );
+ expect(calls.aliases, isEmpty);
+ });
+
+ test('any other error shows its text', () async {
+ final service = _service((
+ alias, {
+ required isValidAddress,
+ required application,
+ required proxy,
+ }) {
+ throw ArgumentError('bad application');
+ });
+ final outcome = await _resolve(service).outcome;
+ expect(
+ outcome,
+ isA<OpenAliasFailed>().having(
+ (e) => e.message,
+ 'message',
+ 'Invalid argument(s): bad application',
+ ),
+ );
+ });
+
+ test('cancel cancels the lookup', () async {
+ final result = Completer<CsOpenAliasRecipient>();
+ var cancels = 0;
+ final service = _service((
+ alias, {
+ required isValidAddress,
+ required application,
+ required proxy,
+ }) {
+ return CsOpenAliasOperation(result.future, () {
+ cancels++;
+ result.completeError(
+ CsOpenAliasCancelledException('cancelled', alias: alias),
+ );
+ });
+ });
+ final resolution = _resolve(service);
+ resolution.cancel();
+ expect(cancels, 1);
+ expect(await resolution.outcome, isA<OpenAliasCancelled>());
+ });
+ });
}Why this scored 17/100
Community notes
Notes can correct, qualify, or add evidence to the AI analysis. Every note shown here has been validated by a human moderator.
The AI analysis stands alone for now. Submit a note if you can add evidence or important context.