fix(salvium): report node connect result in sync status
What the developer wrote
Authored by Mæhdi MOKHTARI
fix(salvium): report node connect result in sync status
updateNode() had the ConnectedSyncStatus and FailedSyncStatus calls
commented out, so a failed daemon connection only got logged and the
wallet stayed stuck on "Connecting..." forever instead of showing
"unable to sync".
This uncomments them so connect success and failure are both reflected
in the sync status, matching how lib_monero_wallet already behaves. Both
status classes are defined in this same file so it compiles as is.
What changed, and why it matters
This commit fixes a user-interface bug in the Salvium wallet. When the wallet tried to connect to a network node, the code that reports 'connected' or 'connection failed' was disabled by comment marks, so users saw 'Connecting...' forever even though the connection had already failed. The change simply re-enables those two status updates, making the sync status accurate. It is a reliability/usability fix, not a security vulnerability.
Treat as a normal bug-fix commit. No security response required. Verify that ConnectedSyncStatus and FailedSyncStatus behave as expected during wallet sync testing.
Security signals we found
No security-relevant code change: only sync-status reporting is restored
No input handling, authentication, cryptography, or network protocol changes
No memory safety, privilege, or access-control changes
Evidence from the diff
In lib/wallets/wallet/intermediate/lib_salvium_wallet.dart, updateNode() previously had _setSyncStatus(ConnectedSyncStatus()) and _setSyncStatus(FailedSyncStatus()) calls commented out inside a try/catch. The patch uncomments both calls so successful node setup reports ConnectedSyncStatus and exceptions report FailedSyncStatus, matching lib_monero_wallet behavior. No other logic changes.
Changed components
lib/wallets/wallet/intermediate/lib_salvium_wallet.dartSalvium wallet sync status UIInspect captured patch +2 / −2
diff --git a/lib/wallets/wallet/intermediate/lib_salvium_wallet.dart b/lib/wallets/wallet/intermediate/lib_salvium_wallet.dart
index 4517f14..03e11f7 100644
--- a/lib/wallets/wallet/intermediate/lib_salvium_wallet.dart
+++ b/lib/wallets/wallet/intermediate/lib_salvium_wallet.dart
@@ -532,9 +532,9 @@ abstract class LibSalviumWallet<T extends CryptonoteCurrency>
csSalvium.startListeners(wallet!);
csSalvium.startAutoSaving(wallet!);
- // _setSyncStatus(ConnectedSyncStatus());
+ _setSyncStatus(ConnectedSyncStatus());
} catch (e, s) {
- // _setSyncStatus(FailedSyncStatus());
+ _setSyncStatus(FailedSyncStatus());
Logging.instance.e(
"Exception caught in $runtimeType.updateNode(): ",
error: e,
Why this scored 20/100
Community notes
Notes can correct, qualify, or add evidence to the AI analysis. Every note shown here has been validated by a human moderator.
The AI analysis stands alone for now. Submit a note if you can add evidence or important context.