What the developer wrote
Authored by kdmukai
Remove unreachable code
What changed, and why it matters
This commit removes a leftover 'Verify address' menu option and its related code from a seed management screen. The code was never reachable because nothing in the program ever set the 'unverified_address' value it depended on. It is a cleanup change, not a security fix.
No security action required. Treat as routine code cleanup. If the verify-address feature is intended to be restored, track it in a separate feature request with proper flow design and security review.
Security signals we found
Dead/unreachable code removal
No input validation, cryptographic, or privilege changes
No references to vulnerabilities, CVEs, or security issues in commit message
Evidence from the diff
The diff deletes the VERIFY_ADDRESS ButtonOption, the conditional block that appended it to button_data when controller.unverified_address was set, and the menu selection handler that routed to SeedAddressVerificationView. The commit title and TODO comment (‘Verify that an addr verification flow can actually reach this code’) indicate the author considered this code unreachable. No functional replacement or security hardening is introduced.
Changed components
src/seedsigner/views/seed_views.pySeedOptionsView UI menuInspect captured patch +0 / −10
diff --git a/src/seedsigner/views/seed_views.py b/src/seedsigner/views/seed_views.py
index 8093318..e1ee086 100644
--- a/src/seedsigner/views/seed_views.py
+++ b/src/seedsigner/views/seed_views.py
@@ -525,7 +525,6 @@ class SeedElectrumMnemonicStartView(View):
****************************************************************************"""
class SeedOptionsView(View):
SCAN_PSBT = ButtonOption("Scan transaction", SeedSignerIconConstants.QRCODE)
- VERIFY_ADDRESS = ButtonOption("Verify addr")
EXPORT_XPUB = ButtonOption("Export xpub")
EXPLORER = ButtonOption("Address explorer")
SIGN_MESSAGE = ButtonOption("Sign message")
@@ -571,12 +570,6 @@ class SeedOptionsView(View):
button_data = []
- if self.controller.unverified_address:
- # TODO: Verify that an addr verification flow can actually reach this code
- addr = self.controller.unverified_address["address"][:7]
- self.VERIFY_ADDRESS.button_label += f" {addr}"
- button_data.append(self.VERIFY_ADDRESS)
-
button_data.append(self.SCAN_PSBT)
if self.settings.get_value(SettingsConstants.SETTING__XPUB_EXPORT) == SettingsConstants.OPTION__ENABLED:
@@ -609,9 +602,6 @@ class SeedOptionsView(View):
self.controller.psbt_seed = self.controller.get_seed(self.seed_num)
return Destination(ScanPSBTView)
- elif button_data[selected_menu_num] == self.VERIFY_ADDRESS:
- return Destination(SeedAddressVerificationView, view_args=dict(seed_num=self.seed_num))
-
elif button_data[selected_menu_num] == self.EXPORT_XPUB:
return Destination(SeedExportXpubSigTypeView, view_args=dict(seed_num=self.seed_num))
Why this scored 12/100
Community notes
Notes can correct, qualify, or add evidence to the AI analysis. Every note shown here has been validated by a human moderator.
The AI analysis stands alone for now. Submit a note if you can add evidence or important context.