Add `async_poll.rs` to `lightning-block-sync`
What the developer wrote
Authored by Matt Corallo
Add `async_poll.rs` to `lightning-block-sync`
In the next commit we'll fetch blocks during initial connection
in parallel, which requires a multi-future poller. Here we add a
symlink to the existing `lightning` `async_poll.rs` file, making it
available in `lightning-block-sync`
What changed, and why it matters
This commit adds a symlink to an existing internal utility file and makes minor build configuration changes. It is purely a code-organization/refactoring step with no security-relevant behavior change visible in the diff.
No security action required; review the subsequent commit that uses async_poll.rs for parallel block fetching to assess any security implications.
Security signals we found
No strong security signals were identified.
Evidence from the diff
The commit creates a symbolic link at lightning-block-sync/src/async_poll.rs pointing to lightning/src/util/async_poll.rs, and updates lightning-block-sync/src/lib.rs to include the new module and remove the #![deny(unsafe_code)] crate-level attribute while adding extern crate alloc/core. The actual async_poll.rs implementation is not modified here, and no security-sensitive logic is introduced.
Changed components
lightning-block-sync/src/async_poll.rs (new symlink)lightning-block-sync/src/lib.rsInspect captured patch +7 / −1
diff --git a/lightning-block-sync/src/async_poll.rs b/lightning-block-sync/src/async_poll.rs
new file mode 120000
index 0000000..eb85cda
--- /dev/null
+++ b/lightning-block-sync/src/async_poll.rs
@@ -0,0 +1 @@
+../../lightning/src/util/async_poll.rs
\ No newline at end of file
diff --git a/lightning-block-sync/src/lib.rs b/lightning-block-sync/src/lib.rs
index cb4e814..c2590f0 100644
--- a/lightning-block-sync/src/lib.rs
+++ b/lightning-block-sync/src/lib.rs
@@ -16,9 +16,11 @@
#![deny(rustdoc::broken_intra_doc_links)]
#![deny(rustdoc::private_intra_doc_links)]
#![deny(missing_docs)]
-#![deny(unsafe_code)]
#![cfg_attr(docsrs, feature(doc_cfg))]
+extern crate alloc;
+extern crate core;
+
#[cfg(any(feature = "rest-client", feature = "rpc-client"))]
pub mod http;
@@ -42,6 +44,9 @@ mod test_utils;
#[cfg(any(feature = "rest-client", feature = "rpc-client"))]
mod utils;
+#[allow(unused)]
+mod async_poll;
+
use crate::poll::{ChainTip, Poll, ValidatedBlockHeader};
use bitcoin::block::{Block, Header};
Why this scored 15/100
Community notes
Notes can correct, qualify, or add evidence to the AI analysis. Every note shown here has been validated by a human moderator.
The AI analysis stands alone for now. Submit a note if you can add evidence or important context.