← Watch feed
Use `--quiet` not `--verbose` on `cargo` calls in `ci-tests.sh`
Public commit record
83/100 · Strong
What the developer wrote
Authored by Matt Corallo
Use `--quiet` not `--verbose` on `cargo` calls in `ci-tests.sh`
I'm pretty confident I've never needed the full command strings
printed by the `--verbose` argument to `cargo` in `ci-tests.sh` and
it makes the output nontrivially larger. Further, I'm not sure
there's really much reason at all to output which thing is built
built - we only care about failures, thus we switch to `--quiet`.
This should make CI output comparatively easy to parse as scrolling
up to see which command failed requires a lot less scrolling.
✓ Specific, descriptive subject✓ Names a concrete action or component✓ Provides detailed explanatory context✓ Mentions testing or verification
What changed, and why it matters
This commit only changes CI test scripts to use cargo's --quiet flag instead of --verbose. It reduces log output size and makes CI logs easier to read. There is no change to application code, no security fix, and no vulnerability introduced.
Recommended action
No security action needed. This is a routine CI hygiene change.
Security signals we found
No strong security signals were identified.
Evidence from the diff
The diff is a mechanical replacement of –verbose with –quiet across all cargo invocations in ci/ci-tests.sh. This affects only CI logging verbosity. It does not alter build behavior, dependency resolution, feature flags, compiler flags, or any Rust source code. No security-relevant behavior is changed.
Changed components
ci/ci-tests.shInspect captured patch +48 / −48
diff --git a/ci/ci-tests.sh b/ci/ci-tests.sh
index 488c5ac..820935f 100755
--- a/ci/ci-tests.sh
+++ b/ci/ci-tests.sh
@@ -14,136 +14,136 @@ function PIN_RELEASE_DEPS {
PIN_RELEASE_DEPS # pin the release dependencies in our main workspace
# The backtrace v0.3.75 crate relies on rustc 1.82
-[ "$RUSTC_MINOR_VERSION" -lt 82 ] && cargo update -p backtrace --precise "0.3.74" --verbose
+[ "$RUSTC_MINOR_VERSION" -lt 82 ] && cargo update -p backtrace --precise "0.3.74" --quiet
# proptest 1.9.0 requires rustc 1.82.0
-[ "$RUSTC_MINOR_VERSION" -lt 82 ] && cargo update -p proptest --precise "1.8.0" --verbose
+[ "$RUSTC_MINOR_VERSION" -lt 82 ] && cargo update -p proptest --precise "1.8.0" --quiet
# Starting with version 1.2.0, the `idna_adapter` crate has an MSRV of rustc 1.81.0.
-[ "$RUSTC_MINOR_VERSION" -lt 81 ] && cargo update -p idna_adapter --precise "1.1.0" --verbose
+[ "$RUSTC_MINOR_VERSION" -lt 81 ] && cargo update -p idna_adapter --precise "1.1.0" --quiet
export RUST_BACKTRACE=1
echo -e "\n\nChecking the workspace, except lightning-transaction-sync."
-cargo check --verbose --color always
+cargo check --quiet --color always
WORKSPACE_MEMBERS=( $(cat Cargo.toml | tr '\n' '\r' | sed 's/\r //g' | tr '\r' '\n' | grep '^members =' | sed 's/members.*=.*\[//' | tr -d '"' | tr ',' ' ') )
echo -e "\n\nTesting the workspace, except lightning-transaction-sync."
-cargo test --verbose --color always
+cargo test --quiet --color always
echo -e "\n\nTesting upgrade from prior versions of LDK"
pushd lightning-tests
-cargo test
+cargo test --quiet
popd
echo -e "\n\nChecking and building docs for all workspace members individually..."
for DIR in "${WORKSPACE_MEMBERS[@]}"; do
- cargo check -p "$DIR" --verbose --color always
- cargo doc -p "$DIR" --document-private-items
+ cargo check -p "$DIR" --quiet --color always
+ cargo doc -p "$DIR" --quiet --document-private-items
done
echo -e "\n\nChecking and testing lightning with features"
-cargo test -p lightning --verbose --color always --features dnssec
-cargo check -p lightning --verbose --color always --features dnssec
-cargo doc -p lightning --document-private-items --features dnssec
+cargo test -p lightning --quiet --color always --features dnssec
+cargo check -p lightning --quiet --color always --features dnssec
+cargo doc -p lightning --quiet --document-private-items --features dnssec
echo -e "\n\nChecking and testing Block Sync Clients with features"
-cargo test -p lightning-block-sync --verbose --color always --features rest-client
-cargo check -p lightning-block-sync --verbose --color always --features rest-client
-cargo test -p lightning-block-sync --verbose --color always --features rpc-client
-cargo check -p lightning-block-sync --verbose --color always --features rpc-client
-cargo test -p lightning-block-sync --verbose --color always --features rpc-client,rest-client
-cargo check -p lightning-block-sync --verbose --color always --features rpc-client,rest-client
-cargo test -p lightning-block-sync --verbose --color always --features rpc-client,rest-client,tokio
-cargo check -p lightning-block-sync --verbose --color always --features rpc-client,rest-client,tokio
+cargo test -p lightning-block-sync --quiet --color always --features rest-client
+cargo check -p lightning-block-sync --quiet --color always --features rest-client
+cargo test -p lightning-block-sync --quiet --color always --features rpc-client
+cargo check -p lightning-block-sync --quiet --color always --features rpc-client
+cargo test -p lightning-block-sync --quiet --color always --features rpc-client,rest-client
+cargo check -p lightning-block-sync --quiet --color always --features rpc-client,rest-client
+cargo test -p lightning-block-sync --quiet --color always --features rpc-client,rest-client,tokio
+cargo check -p lightning-block-sync --quiet --color always --features rpc-client,rest-client,tokio
echo -e "\n\nChecking Transaction Sync Clients with features."
-cargo check -p lightning-transaction-sync --verbose --color always --features esplora-blocking
-cargo check -p lightning-transaction-sync --verbose --color always --features esplora-async
-cargo check -p lightning-transaction-sync --verbose --color always --features esplora-async-https
-cargo check -p lightning-transaction-sync --verbose --color always --features electrum
+cargo check -p lightning-transaction-sync --quiet --color always --features esplora-blocking
+cargo check -p lightning-transaction-sync --quiet --color always --features esplora-async
+cargo check -p lightning-transaction-sync --quiet --color always --features esplora-async-https
+cargo check -p lightning-transaction-sync --quiet --color always --features electrum
if [ -z "$CI_ENV" ] && [[ -z "$BITCOIND_EXE" || -z "$ELECTRS_EXE" ]]; then
echo -e "\n\nSkipping testing Transaction Sync Clients due to BITCOIND_EXE or ELECTRS_EXE being unset."
cargo check -p lightning-transaction-sync --tests
else
echo -e "\n\nTesting Transaction Sync Clients with features."
- cargo test -p lightning-transaction-sync --verbose --color always --features esplora-blocking
- cargo test -p lightning-transaction-sync --verbose --color always --features esplora-async
- cargo test -p lightning-transaction-sync --verbose --color always --features esplora-async-https
- cargo test -p lightning-transaction-sync --verbose --color always --features electrum
+ cargo test -p lightning-transaction-sync --quiet --color always --features esplora-blocking
+ cargo test -p lightning-transaction-sync --quiet --color always --features esplora-async
+ cargo test -p lightning-transaction-sync --quiet --color always --features esplora-async-https
+ cargo test -p lightning-transaction-sync --quiet --color always --features electrum
fi
echo -e "\n\nChecking and testing lightning-persister with features"
-cargo test -p lightning-persister --verbose --color always --features tokio
-cargo check -p lightning-persister --verbose --color always --features tokio
-cargo doc -p lightning-persister --document-private-items --features tokio
+cargo test -p lightning-persister --quiet --color always --features tokio
+cargo check -p lightning-persister --quiet --color always --features tokio
+cargo doc -p lightning-persister --quiet --document-private-items --features tokio
echo -e "\n\nTest Custom Message Macros"
-cargo test -p lightning-custom-message --verbose --color always
+cargo test -p lightning-custom-message --quiet --color always
[ "$CI_MINIMIZE_DISK_USAGE" != "" ] && cargo clean
echo -e "\n\nTest backtrace-debug builds"
-cargo test -p lightning --verbose --color always --features backtrace
+cargo test -p lightning --quiet --color always --features backtrace
echo -e "\n\nTesting no_std builds"
for DIR in lightning-invoice lightning-rapid-gossip-sync lightning-liquidity; do
- cargo test -p $DIR --verbose --color always --no-default-features
+ cargo test -p $DIR --quiet --color always --no-default-features
done
-cargo test -p lightning --verbose --color always --no-default-features
-cargo test -p lightning-background-processor --verbose --color always --no-default-features
+cargo test -p lightning --quiet --color always --no-default-features
+cargo test -p lightning-background-processor --quiet --color always --no-default-features
echo -e "\n\nTesting c_bindings builds"
# Note that because `$RUSTFLAGS` is not passed through to doctest builds we cannot selectively
# disable doctests in `c_bindings` so we skip doctests entirely here.
-RUSTFLAGS="$RUSTFLAGS --cfg=c_bindings" cargo test --verbose --color always --lib --bins --tests
+RUSTFLAGS="$RUSTFLAGS --cfg=c_bindings" cargo test --quiet --color always --lib --bins --tests
for DIR in lightning-invoice lightning-rapid-gossip-sync; do
# check if there is a conflict between no_std and the c_bindings cfg
- RUSTFLAGS="$RUSTFLAGS --cfg=c_bindings" cargo test -p $DIR --verbose --color always --no-default-features
+ RUSTFLAGS="$RUSTFLAGS --cfg=c_bindings" cargo test -p $DIR --quiet --color always --no-default-features
done
# Note that because `$RUSTFLAGS` is not passed through to doctest builds we cannot selectively
# disable doctests in `c_bindings` so we skip doctests entirely here.
-RUSTFLAGS="$RUSTFLAGS --cfg=c_bindings" cargo test -p lightning-background-processor --verbose --color always --no-default-features --lib --bins --tests
-RUSTFLAGS="$RUSTFLAGS --cfg=c_bindings" cargo test -p lightning --verbose --color always --no-default-features --lib --bins --tests
+RUSTFLAGS="$RUSTFLAGS --cfg=c_bindings" cargo test -p lightning-background-processor --quiet --color always --no-default-features --lib --bins --tests
+RUSTFLAGS="$RUSTFLAGS --cfg=c_bindings" cargo test -p lightning --quiet --color always --no-default-features --lib --bins --tests
echo -e "\n\nTesting other crate-specific builds"
# Note that outbound_commitment_test only runs in this mode because of hardcoded signature values
-RUSTFLAGS="$RUSTFLAGS --cfg=ldk_test_vectors" cargo test -p lightning --verbose --color always --no-default-features --features=std
+RUSTFLAGS="$RUSTFLAGS --cfg=ldk_test_vectors" cargo test -p lightning --quiet --color always --no-default-features --features=std
# This one only works for lightning-invoice
# check that compile with no_std and serde works in lightning-invoice
-cargo test -p lightning-invoice --verbose --color always --no-default-features --features serde
+cargo test -p lightning-invoice --quiet --color always --no-default-features --features serde
echo -e "\n\nTesting no_std build on a downstream no-std crate"
# check no-std compatibility across dependencies
pushd no-std-check
-cargo check --verbose --color always
+cargo check --quiet --color always
[ "$CI_MINIMIZE_DISK_USAGE" != "" ] && cargo clean
popd
# Test that we can build downstream code with only the "release pins".
pushd msrv-no-dev-deps-check
PIN_RELEASE_DEPS
-cargo check
+cargo check --quiet
[ "$CI_MINIMIZE_DISK_USAGE" != "" ] && cargo clean
popd
if [ -f "$(which arm-none-eabi-gcc)" ]; then
pushd no-std-check
- cargo build --target=thumbv7m-none-eabi
+ cargo build --quiet --target=thumbv7m-none-eabi
[ "$CI_MINIMIZE_DISK_USAGE" != "" ] && cargo clean
popd
fi
echo -e "\n\nTest cfg-flag builds"
-RUSTFLAGS="--cfg=taproot" cargo test --verbose --color always -p lightning
+RUSTFLAGS="--cfg=taproot" cargo test --quiet --color always -p lightning
[ "$CI_MINIMIZE_DISK_USAGE" != "" ] && cargo clean
-RUSTFLAGS="--cfg=simple_close" cargo test --verbose --color always -p lightning
+RUSTFLAGS="--cfg=simple_close" cargo test --quiet --color always -p lightning
[ "$CI_MINIMIZE_DISK_USAGE" != "" ] && cargo clean
-RUSTFLAGS="--cfg=lsps1_service" cargo test --verbose --color always -p lightning-liquidity
+RUSTFLAGS="--cfg=lsps1_service" cargo test --quiet --color always -p lightning-liquidity
[ "$CI_MINIMIZE_DISK_USAGE" != "" ] && cargo clean
-RUSTFLAGS="--cfg=peer_storage" cargo test --verbose --color always -p lightning
+RUSTFLAGS="--cfg=peer_storage" cargo test --quiet --color always -p lightning
Risk score
Our methodology →Why this scored 15/100
Human-validated context
Community notes
Notes can correct, qualify, or add evidence to the AI analysis. Every note shown here has been validated by a human moderator.
No validated notes yet.
The AI analysis stands alone for now. Submit a note if you can add evidence or important context.