Clean up redundant steps in ci-tests-workspace.sh
What the developer wrote
Authored by Joost Jager
Clean up redundant steps in ci-tests-workspace.sh
Replace the per-member cargo check + cargo doc loop with a single
`cargo doc --workspace` call. The per-member cargo check is redundant
with the workspace-level cargo check already run earlier in the script.
Also remove the separate `cargo test -p lightning-custom-message` which
is covered by the workspace-level cargo test.
Fix stale "except lightning-transaction-sync" echo messages, as it has
been a workspace member for a while now.
AI tools were used in preparing this commit.
What changed, and why it matters
This commit is a routine cleanup of a CI shell script. It removes redundant test and documentation steps and updates stale log messages. There is no security relevance.
No security action needed. Treat as normal CI maintenance.
Security signals we found
No strong security signals were identified.
Evidence from the diff
The change refactors ci/ci-tests-workspace.sh to replace a per-crate cargo check + cargo doc loop with a single cargo doc –workspace call, removes a redundant cargo test -p lightning-custom-message invocation, and updates echo messages that incorrectly excluded lightning-transaction-sync. The shellcheck disable comment is also removed. No code behavior or security boundary is changed.
Changed components
ci/ci-tests-workspace.shInspect captured patch +4 / −12
diff --git a/ci/ci-tests-workspace.sh b/ci/ci-tests-workspace.sh
index 3302f07..f8be49b 100755
--- a/ci/ci-tests-workspace.sh
+++ b/ci/ci-tests-workspace.sh
@@ -1,16 +1,13 @@
#!/bin/bash
-#shellcheck disable=SC2002,SC2207
set -eox pipefail
# shellcheck source=ci/ci-tests-common.sh
source "$(dirname "$0")/ci-tests-common.sh"
-echo -e "\n\nChecking the workspace, except lightning-transaction-sync."
+echo -e "\n\nChecking the workspace."
cargo check --quiet --color always
-WORKSPACE_MEMBERS=( $(cat Cargo.toml | tr '\n' '\r' | sed 's/\r //g' | tr '\r' '\n' | grep '^members =' | sed 's/members.*=.*\[//' | tr -d '"' | tr ',' ' ') )
-
-echo -e "\n\nTesting the workspace, except lightning-transaction-sync."
+echo -e "\n\nTesting the workspace."
cargo test --quiet --color always
echo -e "\n\nTesting upgrade from prior versions of LDK"
@@ -18,14 +15,9 @@ pushd lightning-tests
cargo test --quiet
popd
-echo -e "\n\nChecking and building docs for all workspace members individually..."
-for DIR in "${WORKSPACE_MEMBERS[@]}"; do
- cargo check -p "$DIR" --quiet --color always
- cargo doc -p "$DIR" --quiet --document-private-items
-done
+echo -e "\n\nBuilding docs for all workspace members."
+cargo doc --workspace --quiet --document-private-items
-echo -e "\n\nTest Custom Message Macros"
-cargo test -p lightning-custom-message --quiet --color always
[ "$CI_MINIMIZE_DISK_USAGE" != "" ] && cargo clean
# Test that we can build downstream code with only the "release pins".
Why this scored 15/100
Community notes
Notes can correct, qualify, or add evidence to the AI analysis. Every note shown here has been validated by a human moderator.
The AI analysis stands alone for now. Submit a note if you can add evidence or important context.