fuzz: gate splice opcodes on cfg(splicing)
What the developer wrote
Authored by Joost Jager
fuzz: gate splice opcodes on cfg(splicing)
Keep the splice opcodes in chanmon_consistency available
only when the crate is built with cfg(splicing). When
splicing is disabled, return early from those opcode
handlers instead of calling splice helpers that are not
compiled in.
Add cfg(splicing) to fuzz/Cargo.toml check-cfg so the
guarded code builds cleanly in the fuzz crate.
AI tools were used in preparing this commit.
What changed, and why it matters
This commit is a build-system and fuzz-test maintenance change. It makes sure that certain experimental 'splicing' test commands in the fuzzing harness are only compiled and run when the 'splicing' feature flag is enabled. When the flag is off, those commands now do nothing instead of trying to call splicing code that isn't compiled in. There is no user-facing security fix here.
No security action required. Treat as normal build/test maintenance.
Security signals we found
No strong security signals were identified.
Evidence from the diff
The patch adds cfg!(splicing) guards around splice opcode handlers in fuzz/src/chanmon_consistency.rs and adds cfg(splicing) to the fuzz crate’s Cargo.toml check-cfg list. Previously, fuzzing without the splicing feature could fail to compile or reference unavailable splice helpers. The change also adds #[allow(unused_variables)] for loggers and fee_estimators because they are now unused when splicing is disabled. This is a conditional-compilation correctness fix in test/fuzz infrastructure, not a vulnerability patch.
Changed components
fuzz/src/chanmon_consistency.rsfuzz/Cargo.tomlInspect captured patch +27 / −0
diff --git a/fuzz/Cargo.toml b/fuzz/Cargo.toml
index 5a2e397..252946b 100644
--- a/fuzz/Cargo.toml
+++ b/fuzz/Cargo.toml
@@ -62,4 +62,5 @@ check-cfg = [
"cfg(fuzzing)",
"cfg(secp256k1_fuzz)",
"cfg(hashes_fuzz)",
+ "cfg(splicing)",
]
diff --git a/fuzz/src/chanmon_consistency.rs b/fuzz/src/chanmon_consistency.rs
index d8d4570..d4a0e56 100644
--- a/fuzz/src/chanmon_consistency.rs
+++ b/fuzz/src/chanmon_consistency.rs
@@ -1333,7 +1333,9 @@ pub fn do_test<Out: Output + MaybeSend + MaybeSync>(data: &[u8], out: Out) {
let (node_c, mut monitor_c, keys_manager_c, logger_c) = make_node!(2, fee_est_c, broadcast_c);
let mut nodes = [node_a, node_b, node_c];
+ #[allow(unused_variables)]
let loggers = [logger_a, logger_b, logger_c];
+ #[allow(unused_variables)]
let fee_estimators = [Arc::clone(&fee_est_a), Arc::clone(&fee_est_b), Arc::clone(&fee_est_c)];
// Connect peers first, then create channels
@@ -2426,24 +2428,36 @@ pub fn do_test<Out: Output + MaybeSend + MaybeSync>(data: &[u8], out: Out) {
},
0xa0 => {
+ if !cfg!(splicing) {
+ test_return!();
+ }
let cp_node_id = nodes[1].get_our_node_id();
let wallet = WalletSync::new(&wallets[0], Arc::clone(&loggers[0]));
let feerate_sat_per_kw = fee_estimators[0].feerate_sat_per_kw();
splice_in(&nodes[0], &cp_node_id, &chan_a_id, &wallet, feerate_sat_per_kw);
},
0xa1 => {
+ if !cfg!(splicing) {
+ test_return!();
+ }
let cp_node_id = nodes[0].get_our_node_id();
let wallet = WalletSync::new(&wallets[1], Arc::clone(&loggers[1]));
let feerate_sat_per_kw = fee_estimators[1].feerate_sat_per_kw();
splice_in(&nodes[1], &cp_node_id, &chan_a_id, &wallet, feerate_sat_per_kw);
},
0xa2 => {
+ if !cfg!(splicing) {
+ test_return!();
+ }
let cp_node_id = nodes[2].get_our_node_id();
let wallet = WalletSync::new(&wallets[1], Arc::clone(&loggers[1]));
let feerate_sat_per_kw = fee_estimators[1].feerate_sat_per_kw();
splice_in(&nodes[1], &cp_node_id, &chan_b_id, &wallet, feerate_sat_per_kw);
},
0xa3 => {
+ if !cfg!(splicing) {
+ test_return!();
+ }
let cp_node_id = nodes[1].get_our_node_id();
let wallet = WalletSync::new(&wallets[2], Arc::clone(&loggers[2]));
let feerate_sat_per_kw = fee_estimators[2].feerate_sat_per_kw();
@@ -2451,6 +2465,9 @@ pub fn do_test<Out: Output + MaybeSend + MaybeSync>(data: &[u8], out: Out) {
},
0xa4 => {
+ if !cfg!(splicing) {
+ test_return!();
+ }
let cp_node_id = nodes[1].get_our_node_id();
let wallet = &wallets[0];
let logger = Arc::clone(&loggers[0]);
@@ -2458,6 +2475,9 @@ pub fn do_test<Out: Output + MaybeSend + MaybeSync>(data: &[u8], out: Out) {
splice_out(&nodes[0], &cp_node_id, &chan_a_id, wallet, logger, feerate_sat_per_kw);
},
0xa5 => {
+ if !cfg!(splicing) {
+ test_return!();
+ }
let cp_node_id = nodes[0].get_our_node_id();
let wallet = &wallets[1];
let logger = Arc::clone(&loggers[1]);
@@ -2465,6 +2485,9 @@ pub fn do_test<Out: Output + MaybeSend + MaybeSync>(data: &[u8], out: Out) {
splice_out(&nodes[1], &cp_node_id, &chan_a_id, wallet, logger, feerate_sat_per_kw);
},
0xa6 => {
+ if !cfg!(splicing) {
+ test_return!();
+ }
let cp_node_id = nodes[2].get_our_node_id();
let wallet = &wallets[1];
let logger = Arc::clone(&loggers[1]);
@@ -2472,6 +2495,9 @@ pub fn do_test<Out: Output + MaybeSend + MaybeSync>(data: &[u8], out: Out) {
splice_out(&nodes[1], &cp_node_id, &chan_b_id, wallet, logger, feerate_sat_per_kw);
},
0xa7 => {
+ if !cfg!(splicing) {
+ test_return!();
+ }
let cp_node_id = nodes[1].get_our_node_id();
let wallet = &wallets[2];
let logger = Arc::clone(&loggers[2]);
Why this scored 15/100
Community notes
Notes can correct, qualify, or add evidence to the AI analysis. Every note shown here has been validated by a human moderator.
The AI analysis stands alone for now. Submit a note if you can add evidence or important context.