Clarify splicing feature flag requirements
What the developer wrote
Authored by Leo Nash
Clarify splicing feature flag requirements
What changed, and why it matters
This commit only adds documentation comments to a Rust function. It clarifies which feature flags and conditions are needed to use the splicing feature. No code behavior was changed, so there is no security issue.
No action needed. This is a documentation-only change with no security relevance.
Security signals we found
No strong security signals were identified.
Evidence from the diff
The diff adds a ‘# Required Feature Flags’ section to the rustdoc comment for a splicing-related method in channelmanager.rs. It explains that the counterparty must support splicing and be connected. There are no logic, API, or cryptographic changes.
Changed components
lightning/src/ln/channelmanager.rs (documentation only)Inspect captured patch +6 / −0
diff --git a/lightning/src/ln/channelmanager.rs b/lightning/src/ln/channelmanager.rs
index f2e8fa7..b0ed9af 100644
--- a/lightning/src/ln/channelmanager.rs
+++ b/lightning/src/ln/channelmanager.rs
@@ -4854,6 +4854,12 @@ where
/// the channel. This will spend the channel's funding transaction output, effectively replacing
/// it with a new one.
///
+ /// # Required Feature Flags
+ ///
+ /// Initiating a splice requires that the channel counterparty supports splicing. Any
+ /// channel (no matter the type) can be spliced, as long as the counterparty is currently
+ /// connected.
+ ///
/// # Arguments
///
/// Provide a `contribution` to determine if value is spliced in or out. The splice initiator is
Why this scored 15/100
Community notes
Notes can correct, qualify, or add evidence to the AI analysis. Every note shown here has been validated by a human moderator.
The AI analysis stands alone for now. Submit a note if you can add evidence or important context.