Drop unnecessary Rust install in SemVer CI

LDK

Lightning Dev Kit/rust-lightning

5da74997 View source ↗

Public commit record

What the developer wrote

Authored by Elias Rohrer

80/100 · Strong

Drop unnecessary Rust install in SemVer CI

In the last few days there was incompatibility of `cargo-semver-checks`
with the new stable Rust 1.93.0. While this should fixed by today's
release of `cargo-semver-checks`, we take the opportunity to drop an
unnecessary install step from the CI workflow, as the action will bring
their own Rust version if not configured otherwise.

✓ Descriptive subject✓ Names a concrete action or component✓ Provides detailed explanatory context✓ Explains rationale or failure mode

The short version

What changed, and why it matters

This commit removes an unnecessary step in an automated CI workflow that checks semantic versioning. It is a routine maintenance change with no security implications.

Recommended action

No security action required. Treat as normal CI cleanup.

Security signals we found

No strong security signals were identified.

Technical analysis

Evidence from the diff

The patch drops an explicit Rust stable toolchain installation from .github/workflows/semver.yml. The cargo-semver-checks-action already provides its own Rust toolchain when not configured otherwise, making the manual rustup install redundant. The change affects only CI infrastructure and no production code, dependencies, or cryptographic logic.

Changed components

.github/workflows/semver.yml

Inspect captured patch +0 / −4

diff --git a/.github/workflows/semver.yml b/.github/workflows/semver.yml
index 03017e1..03a8e46 100644
--- a/.github/workflows/semver.yml
+++ b/.github/workflows/semver.yml
@@ -13,10 +13,6 @@ jobs:
     steps:
       - name: Checkout source code
         uses: actions/checkout@v4
-      - name: Install Rust stable toolchain
-        run: |
-          curl --proto '=https' --tlsv1.2 -sSf https://sh.rustup.rs | sh -s -- -y --profile=minimal --default-toolchain stable
-          rustup override set stable
       - name: Check SemVer with default features
         uses: obi1kenobi/cargo-semver-checks-action@v2
         with:

Risk score

Why this scored 15/100

Our methodology →

Potential impact 0/30

Exploitability 0/25

Stealth signal 0/15

Affected reach 0/15

Confidence 10/10

Evidence quality 5/5

Human-validated context

Community notes

Notes can correct, qualify, or add evidence to the AI analysis. Every note shown here has been validated by a human moderator.

No validated notes yet.

The AI analysis stands alone for now. Submit a note if you can add evidence or important context.

What the developer wrote

What changed, and why it matters

Security signals we found

Evidence from the diff

Changed components

Why this scored 15/100

Community notes

Related watches

Merge PR 'Only fetch TXIDs instead of entire block during gossip verification' (#4846)

Merge PR 'Allow filtered block rescans at the current tip' (#4847)

Add test framework coverage of `Listen` block connection replays