Bind Channel::commitment_signed result in internal_commitment_signed
What the developer wrote
Authored by Wilmer Paulino
Bind Channel::commitment_signed result in internal_commitment_signed
What changed, and why it matters
This is a small Rust code cleanup in the Lightning Dev Kit's channel manager. It changes how the result of a commitment_signed call is handled so the result is first bound to a local variable before being passed to an error-handling macro. The change itself does not alter the visible behavior of the code, but it may fix a subtle Rust borrow-checker or drop-order issue that could affect correctness during channel state updates. There is no direct evidence in the commit that this fixes a security vulnerability.
Treat as a routine correctness/refactoring patch. Review the change in the context of the surrounding release notes or related commits to confirm whether it addresses a borrow-checker edge case, panic safety, or state consistency issue. No immediate security response is indicated by this commit alone.
Security signals we found
Change affects channel state commitment handling in a Lightning node implementation
Refactoring around try_channel_entry! error-handling macro could relate to panic safety or state consistency
No explicit security claim, CVE, or advisory referenced in commit or supplied materials
Evidence from the diff
In lightning/src/ln/channelmanager.rs, the internal_commitment_signed function is refactored to bind the return value of Channel::commitment_signed to a local let res before invoking the try_channel_entry! macro. Previously, the macro wrapped the method call directly. This change can affect temporary lifetimes, evaluation order, and drop order in Rust. The commit message is minimal and provides no explicit security or bug-fix rationale. No advisory, CVE, or researcher attribution is present in the supplied materials.
Changed components
lightning/src/ln/channelmanager.rsinternal_commitment_signedChannel::commitment_signedtry_channel_entry! macroInspect captured patch +8 / −11
diff --git a/lightning/src/ln/channelmanager.rs b/lightning/src/ln/channelmanager.rs
index 1a4fe17..4fc79ad 100644
--- a/lightning/src/ln/channelmanager.rs
+++ b/lightning/src/ln/channelmanager.rs
@@ -12167,18 +12167,15 @@ This indicates a bug inside LDK. Please report this error at https://github.com/
let chan = chan_entry.get_mut();
let logger = WithChannelContext::from(&self.logger, &chan.context(), None);
let funding_txo = chan.funding().get_funding_txo();
- let (monitor_opt, monitor_update_opt) = try_channel_entry!(
- self,
- peer_state,
- chan.commitment_signed(
- msg,
- best_block,
- &self.signer_provider,
- &self.fee_estimator,
- &&logger
- ),
- chan_entry
+ let res = chan.commitment_signed(
+ msg,
+ best_block,
+ &self.signer_provider,
+ &self.fee_estimator,
+ &&logger,
);
+ let (monitor_opt, monitor_update_opt) =
+ try_channel_entry!(self, peer_state, res, chan_entry);
if let Some(chan) = chan.as_funded_mut() {
if let Some(monitor) = monitor_opt {
Why this scored 32/100
Community notes
Notes can correct, qualify, or add evidence to the AI analysis. Every note shown here has been validated by a human moderator.
The AI analysis stands alone for now. Submit a note if you can add evidence or important context.