fuzz: rename chan_id to scid in hop payment functions
What the developer wrote
Authored by Joost Jager
fuzz: rename chan_id to scid in hop payment functions
Rename `middle_chan_id` to `middle_scid` and `dest_chan_id` to `dest_scid`
in `send_hop_noret` and `send_hop_payment`. These parameters are short
channel IDs (SCIDs), not channel IDs, so the rename improves clarity.
Co-Authored-By: Claude Opus 4.5 <noreply@anthropic.com>
Co-Authored-By: Matt Corallo <git@bluematt.me>
What changed, and why it matters
This commit is a simple variable rename in a fuzz testing file. It changes 'chan_id' to 'scid' (short channel ID) in two helper functions to make the code clearer. There is no functional change and no security impact.
No action needed. This is a non-security refactoring change.
Security signals we found
No strong security signals were identified.
Evidence from the diff
The patch renames parameters middle_chan_id to middle_scid and dest_chan_id to dest_scid in send_hop_noret and send_hop_payment within fuzz/src/chanmon_consistency.rs. All call sites and usages are updated consistently. The diff shows only identifier renames with no logic, type, or behavior changes. It affects only fuzz testing infrastructure, not production code paths.
Changed components
fuzz/src/chanmon_consistency.rsInspect captured patch +6 / −6
diff --git a/fuzz/src/chanmon_consistency.rs b/fuzz/src/chanmon_consistency.rs
index d3d38a9..de83f80 100644
--- a/fuzz/src/chanmon_consistency.rs
+++ b/fuzz/src/chanmon_consistency.rs
@@ -604,15 +604,15 @@ fn send_payment(
#[inline]
fn send_hop_noret(
- source: &ChanMan, middle: &ChanMan, middle_chan_id: u64, dest: &ChanMan, dest_chan_id: u64,
+ source: &ChanMan, middle: &ChanMan, middle_scid: u64, dest: &ChanMan, dest_scid: u64,
amt: u64, payment_ctr: &mut u64,
) {
- send_hop_payment(source, middle, middle_chan_id, dest, dest_chan_id, amt, payment_ctr);
+ send_hop_payment(source, middle, middle_scid, dest, dest_scid, amt, payment_ctr);
}
#[inline]
fn send_hop_payment(
- source: &ChanMan, middle: &ChanMan, middle_chan_id: u64, dest: &ChanMan, dest_chan_id: u64,
+ source: &ChanMan, middle: &ChanMan, middle_scid: u64, dest: &ChanMan, dest_scid: u64,
amt: u64, payment_ctr: &mut u64,
) -> bool {
let (payment_secret, payment_hash) = get_payment_secret_hash(dest, payment_ctr);
@@ -621,7 +621,7 @@ fn send_hop_payment(
let (min_value_sendable, max_value_sendable) = source
.list_usable_channels()
.iter()
- .find(|chan| chan.short_channel_id == Some(middle_chan_id))
+ .find(|chan| chan.short_channel_id == Some(middle_scid))
.map(|chan| (chan.next_outbound_htlc_minimum_msat, chan.next_outbound_htlc_limit_msat))
.unwrap_or((0, 0));
let first_hop_fee = 50_000;
@@ -635,7 +635,7 @@ fn send_hop_payment(
RouteHop {
pubkey: middle.get_our_node_id(),
node_features: middle.node_features(),
- short_channel_id: middle_chan_id,
+ short_channel_id: middle_scid,
channel_features: middle.channel_features(),
fee_msat: first_hop_fee,
cltv_expiry_delta: 100,
@@ -644,7 +644,7 @@ fn send_hop_payment(
RouteHop {
pubkey: dest.get_our_node_id(),
node_features: dest.node_features(),
- short_channel_id: dest_chan_id,
+ short_channel_id: dest_scid,
channel_features: dest.channel_features(),
fee_msat: amt,
cltv_expiry_delta: 200,
Why this scored 15/100
Community notes
Notes can correct, qualify, or add evidence to the AI analysis. Every note shown here has been validated by a human moderator.
The AI analysis stands alone for now. Submit a note if you can add evidence or important context.