Drop outdated async signing comment
What the developer wrote
Authored by Jeffrey Czyz
Drop outdated async signing comment
What changed, and why it matters
This commit removes an outdated code comment and adjusts how a future commitment public key is serialized to disk. It is a cleanup/refactoring change with no apparent security relevance.
No security action needed; treat as routine maintenance.
Security signals we found
No strong security signals were identified.
Evidence from the diff
The change drops a comment stating that HolderCommitmentPoint::next_point would become optional once async signing was implemented. Since async signing has since been implemented, next_point() now always returns a value, so the code removes the Some(...) wrapper and changes the corresponding TLV serialization from option to required. This is a data-format consistency cleanup, not a behavior change in cryptographic validation.
Changed components
lightning/src/ln/channel.rs serialization of holder commitment pointsInspect captured patch +2 / −3
diff --git a/lightning/src/ln/channel.rs b/lightning/src/ln/channel.rs
index 5777ea4..3c7a57c 100644
--- a/lightning/src/ln/channel.rs
+++ b/lightning/src/ln/channel.rs
@@ -13252,8 +13252,7 @@ where
let is_manual_broadcast = Some(self.context.is_manual_broadcast);
let holder_commitment_point_current = self.holder_commitment_point.current_point();
- // `HolderCommitmentPoint::next_point` will become optional when async signing is implemented.
- let holder_commitment_point_next = Some(self.holder_commitment_point.next_point());
+ let holder_commitment_point_next = self.holder_commitment_point.next_point();
let holder_commitment_point_pending_next = self.holder_commitment_point.pending_next_point;
write_tlv_fields!(writer, {
@@ -13292,7 +13291,7 @@ where
(39, pending_outbound_blinding_points, optional_vec),
(41, holding_cell_blinding_points, optional_vec),
(43, malformed_htlcs, optional_vec), // Added in 0.0.119
- (45, holder_commitment_point_next, option),
+ (45, holder_commitment_point_next, required),
(47, holder_commitment_point_pending_next, option),
(49, self.context.local_initiated_shutdown, option), // Added in 0.0.122
(51, is_manual_broadcast, option), // Added in 0.0.124
Why this scored 15/100
Community notes
Notes can correct, qualify, or add evidence to the AI analysis. Every note shown here has been validated by a human moderator.
The AI analysis stands alone for now. Submit a note if you can add evidence or important context.