What changed, and why it matters
This commit removes the ability to change the proxy address from inside the Monero GUI wallet after the wallet is running. The proxy setting can still be read and reported, but the setter function that would update it at runtime has been deleted. The change is defensive: it prevents a running wallet's network proxy from being modified on the fly, which could otherwise be abused to redirect traffic unexpectedly. There is no direct evidence in the commit of an active vulnerability being fixed, and the commit message does not describe a security issue.
Treat as a hardening change rather than an urgent security patch. Review whether the proxy address can still be set securely at wallet startup or through trusted configuration UI, and verify that no remaining QML/JavaScript bindings can inject values into the now-read-only property. No immediate incident response is indicated by this commit alone.
Security signals we found
Removal of a writable property that controls outbound network proxy configuration
Reduction of runtime mutable network surface in GUI layer
No accompanying fix for a concrete vulnerability in the diff
No mention of CVE, security advisory, or researcher attribution in commit
Evidence from the diff
The patch removes Wallet::setProxyAddress(QString) from src/libwalletqt/Wallet.cpp and changes the proxyAddress Q_PROPERTY from READ/WRITE/NOTIFY to READ/NOTIFY in src/libwalletqt/Wallet.h. The getter and change notification remain, but runtime mutation of the proxy address is no longer exposed through the Qt property system. This reduces the attack surface against any UI or QML binding that could bind an untrusted value to proxyAddress. The underlying wallet implementation still has a setProxy method, but the GUI no longer calls it after construction.
Changed components
src/libwalletqt/Wallet.cppsrc/libwalletqt/Wallet.hMonero GUI wallet proxy address configurationInspect captured patch +1 / −19
### src/libwalletqt/Wallet.cpp
@@ -199,23 +199,6 @@ QString Wallet::getProxyAddress() const
return m_proxyAddress;
}
-void Wallet::setProxyAddress(QString address)
-{
- m_scheduler.run([this, address] {
- {
- QMutexLocker locker(&m_proxyMutex);
-
- if (!m_walletImpl->setProxy(address.toStdString()))
- {
- qCritical() << "failed to set proxy" << address;
- }
-
- m_proxyAddress = address;
- }
- emit proxyAddressChanged();
- });
-}
-
bool Wallet::synchronized() const
{
return m_walletImpl->synchronized();
### src/libwalletqt/Wallet.h
@@ -99,7 +99,7 @@ class Wallet : public QObject, public PassprasePrompter
Q_PROPERTY(QString secretSpendKey READ getSecretSpendKey)
Q_PROPERTY(QString publicSpendKey READ getPublicSpendKey)
Q_PROPERTY(QString daemonLogPath READ getDaemonLogPath CONSTANT)
- Q_PROPERTY(QString proxyAddress READ getProxyAddress WRITE setProxyAddress NOTIFY proxyAddressChanged)
+ Q_PROPERTY(QString proxyAddress READ getProxyAddress NOTIFY proxyAddressChanged)
Q_PROPERTY(quint64 walletCreationHeight READ getWalletCreationHeight WRITE setWalletCreationHeight NOTIFY walletCreationHeightChanged)
public:
@@ -469,7 +469,6 @@ class Wallet : public QObject, public PassprasePrompter
void refreshingSet(bool value);
void setConnectionStatus(ConnectionStatus value);
QString getProxyAddress() const;
- void setProxyAddress(QString address);
void startRefreshThread();
private:Why this scored 26/100
Community notes
Notes can correct, qualify, or add evidence to the AI analysis. Every note shown here has been validated by a human moderator.
The AI analysis stands alone for now. Submit a note if you can add evidence or important context.