AI-generated analysisPublished automatically and not human-verified. Validated context appears in community notes below.
← Watch feed
Low 42 Monero

oshelper: verify seed template hash before opening

Public commit record

What the developer wrote

Authored by selsta

60/100 · Adequate
oshelper: verify seed template hash before opening
✓ Specific, descriptive subject✓ Names a concrete action or component✓ Mentions testing or verification! No meaningful explanatory body
The short version

What changed, and why it matters

This change hardens how the Monero GUI wallet opens a printable PDF seed backup template. Previously, the app copied a bundled PDF to a predictable temporary path and immediately opened it. Now it uses a unique temporary directory, verifies the PDF's SHA-256 hash against a hardcoded value, and reports an error if the file doesn't match. This reduces the risk that a local attacker could swap or modify the template file to trick the user into revealing or mishandling their recovery seed.

Recommended action

Treat as a security hardening improvement. Reviewers should verify that seedTemplateHash exactly matches the current :/wizard/template.pdf SHA-256, confirm QTemporaryDir lifetime covers the external PDF viewer's usage, and ensure the test runs in CI so future template updates don't desynchronize the hash.

Security signals we found

01

Adds integrity check (SHA-256) for a bundled resource before opening it externally

02

Switches from predictable temp file path to randomized QTemporaryDir

03

Returns explicit error codes and surfaces integrity failures to the user

04

Adds regression test enforcing hash synchronization with bundled resource

Risk score

Why this scored 42/100

Our methodology →
Potential impact 12/30
Exploitability 8/25
Stealth signal 6/15
Affected reach 7/15
Confidence 6/10
Evidence quality 3/5
Human-validated context

Community notes

Notes can correct, qualify, or add evidence to the AI analysis. Every note shown here has been validated by a human moderator.

No validated notes yet.

The AI analysis stands alone for now. Submit a note if you can add evidence or important context.