What changed, and why it matters
This commit changes Monero GUI's 'simple mode' so that, instead of running a local node that does not sync the full blockchain, it connects to a built-in list of public remote nodes. The old 'bootstrap' mode (which downloaded the blockchain while using a remote node) is removed. The change is a feature redesign, not a traditional bug fix. It increases convenience for simple-mode users but makes them rely on third-party servers by default, which can reduce privacy and expose users to malicious or snooping nodes. There is no evidence in the commit of an active security vulnerability like remote code execution or theft of keys.
Treat this as a privacy-relevant design change rather than an urgent vulnerability. Users who need maximum privacy should be guided to advanced mode with their own full node. Review the hard-coded node list for quality and consider adding user-visible warnings about remote-node privacy trade-offs. Verify that the auto-switch logic cannot be abused to force a user onto a malicious node, and ensure proxy settings are consistently applied.
Security signals we found
Default connection to a large, hard-coded list of public third-party nodes in simple mode
Removal of bootstrap mode reduces local blockchain syncing, increasing reliance on remote nodes
Remote nodes can log IP addresses, correlate restore heights, and serve inaccurate chain data
No TLS/certificate pinning or node authentication is visible in the diff
Auto-switching on failure could route users to untrusted nodes without explicit consent
Proxy is applied to simple-mode remote-node connections if a SOCKS5 proxy is configured
Evidence from the diff
The patch replaces the simple-mode bootstrap mechanism with direct remote-node usage. It adds js/RemoteNodes.js containing ~700 hard-coded mainnet RPC endpoints, shuffles them, and auto-switches if a node fails. Wallet initialization is made re-entrant with an ‘initializing’ guard, and connection-status logic is mutex-protected. The local daemon is no longer started in simple mode (walletMode == 0). Settings UI, wizard flows, and command-line help strings are updated to reflect only two modes: simple (remote node) and advanced (local or chosen remote).
Changed components
Monero GUI simple mode wallet operationWizard mode selection and creation/restore flowsNetwork status indicator and remote-node switcherDaemonManager start API (noSync parameter removed)Wallet initialization and connection-status logic (src/libwalletqt/Wallet.cpp/h)Settings pages: Node, Info, Layout, LogInspect captured patch +1008 / −300
### components/NetworkStatusItem.qml
@@ -55,13 +55,13 @@ Rectangle {
return qsTr("Synchronizing");
if (persistentSettings.useRemoteNode && persistentSettings.allowRemoteNodeMining && appWindow.isMining)
return qsTr("Remote node") + " + " + qsTr("Mining");
- if (persistentSettings.useRemoteNode)
+ if (appWindow.walletMode === 0 || persistentSettings.useRemoteNode)
return qsTr("Remote node");
return appWindow.isMining ? qsTr("Connected") + " + " + qsTr("Mining"): qsTr("Connected");
case Wallet.ConnectionStatus_WrongVersion:
return qsTr("Wrong version");
case Wallet.ConnectionStatus_Disconnected:
- if (appWindow.walletMode <= 1) {
+ if (appWindow.walletMode === 0) {
return qsTr("Searching node") + translationManager.emptyString;
}
return qsTr("Disconnected");
@@ -163,23 +163,26 @@ Rectangle {
}
MoneroComponents.TextPlain {
+ id: switchNodeIcon
anchors.left: statusTextVal.right
anchors.leftMargin: 16
anchors.verticalCenter: parent.verticalCenter
color: refreshMouseArea.containsMouse ? MoneroComponents.Style.defaultFontColor : MoneroComponents.Style.dimmedFontColor
font.family: FontAwesome.fontFamilySolid
font.pixelSize: 24
font.styleName: "Solid"
- opacity: 0.85
text: FontAwesome.random
themeTransition: false
tooltip: qsTr("Switch to another public remote node") + translationManager.emptyString;
visible: (
- !appWindow.disconnected &&
- !persistentSettings.useRemoteNode &&
- (persistentSettings.bootstrapNodeAddress == "auto" || persistentSettings.walletMode < 2)
+ (appWindow.walletMode === 0 && appWindow.currentWallet != undefined) ||
+ (!appWindow.disconnected && !persistentSettings.useRemoteNode &&
+ appWindow.walletMode >= 2 && persistentSettings.bootstrapNodeAddress == "auto")
)
+ enabled: appWindow.walletMode !== 0 || (appWindow.currentWallet != undefined && !appWindow.currentWallet.initializing)
+ opacity: enabled ? 0.85 : 0.5
+
MouseArea {
id: refreshMouseArea
anchors.fill: parent
@@ -189,6 +192,13 @@ Rectangle {
onEntered: parent.tooltipPopup.open()
onExited: parent.tooltipPopup.close()
onClicked: {
+ if (appWindow.walletMode === 0) {
+ if (appWindow.switchSimpleModeNode(false)) {
+ appWindow.showStatusMessage(qsTr("Switching to another public node") + "…", 3);
+ }
+ return;
+ }
+
const callback = function(result) {
refreshMouseArea.visible = true;
if (result) {
### js/RemoteNodes.js
@@ -0,0 +1,703 @@
+.pragma library
+
+// Mainnet RPC endpoints in host[:port] format. Omitted ports default to 18081.
+var addresses = [
+ "100.14.80.141:18089",
+ "100.35.68.51:18081",
+ "101.100.136.191:18089",
+ "103.176.58.34:18089",
+ "103.176.58.43:18089",
+ "103.176.58.44:18089",
+ "103.229.168.246:18089",
+ "103.245.231.39:18081",
+ "103.253.25.29:18089",
+ "103.253.25.30:18089",
+ "103.48.171.169:18089",
+ "103.76.41.145:18081",
+ "104.131.174.3:18081",
+ "104.154.75.197:18081",
+ "104.199.89.5:18089",
+ "104.237.151.74:18081",
+ "104.245.208.112:18089",
+ "104.248.220.36:18081",
+ "104.248.75.38:18081",
+ "104.250.118.142:18081",
+ "104.250.118.67:18081",
+ "104.250.118.91:18081",
+ "104.250.122.150:18081",
+ "104.36.87.200:18089",
+ "107.167.254.228:18081",
+ "107.167.84.90:18089",
+ "107.170.5.248:18081",
+ "107.170.67.200:18081",
+ "107.170.74.133:18081",
+ "107.173.168.135:18089",
+ "107.200.171.114:18081",
+ "107.213.101.152:18089",
+ "108.213.112.168:18089",
+ "108.218.188.175:18089",
+ "108.250.118.187:18081",
+ "108.27.68.70:18089",
+ "108.30.169.170:18089",
+ "108.89.137.105:18089",
+ "109.150.40.241:18081",
+ "109.190.247.5:18081",
+ "109.193.3.118:18081",
+ "109.196.118.68:18081",
+ "109.199.98.74:18081",
+ "109.202.246.135:18089",
+ "109.235.50.35:7799",
+ "109.235.50.36:38533",
+ "109.70.112.101:18089",
+ "109.86.89.233:18081",
+ "109.89.168.129:18089",
+ "111.221.46.126:18089",
+ "116.202.16.239:18089",
+ "116.203.98.127:18089",
+ "116.251.217.58:18089",
+ "117.18.123.76:18081",
+ "12.236.221.236:18081",
+ "121.127.33.242:18089",
+ "123.16.19.126:18089",
+ "123.255.55.81:18089",
+ "125.229.65.126:18081",
+ "129.212.151.74:18081",
+ "129.212.250.33:18081",
+ "129.225.164.124:18089",
+ "131.241.237.68:18081",
+ "134.122.115.120:18081",
+ "134.122.35.188:18081",
+ "134.122.38.12:18081",
+ "134.122.68.241:18081",
+ "134.199.153.69:18081",
+ "134.199.161.236:18081",
+ "134.199.169.253:18081",
+ "134.199.170.104:18081",
+ "134.199.218.80:18081",
+ "134.209.40.183:18081",
+ "134.209.69.103:18081",
+ "134.209.80.205:18081",
+ "134.56.81.174:18081",
+ "135.148.122.119:18089",
+ "135.148.45.230:18089",
+ "135.181.141.137:18089",
+ "135.181.181.190:18089",
+ "135.181.76.219:18089",
+ "136.111.54.63:18081",
+ "136.50.61.237:18089",
+ "136.53.9.137:18089",
+ "136.56.77.154:18089",
+ "137.184.103.136:18081",
+ "137.184.162.2:18081",
+ "137.184.217.80:18081",
+ "137.184.37.78:18081",
+ "137.220.134.184:18081",
+ "138.197.0.98:18081",
+ "138.197.110.171:18089",
+ "138.197.115.194:18089",
+ "138.197.158.148:18081",
+ "138.197.33.215:18089",
+ "138.197.85.137:18081",
+ "138.197.96.128:18081",
+ "138.201.50.146:18089",
+ "138.68.140.247:18081",
+ "139.162.161.103:18081",
+ "139.162.178.137:18081",
+ "139.59.81.130:18081",
+ "14.224.137.18:18081",
+ "141.101.226.22:18089",
+ "141.255.167.250:18089",
+ "141.94.99.110:18089",
+ "141.95.3.181:18081",
+ "141.95.32.57:18081",
+ "141.98.153.205:18089",
+ "142.112.252.86:18089",
+ "142.93.115.67:18081",
+ "142.93.155.123:18081",
+ "142.93.157.59:18081",
+ "143.110.164.200:18081",
+ "143.110.184.64:18081",
+ "143.110.241.184:18081",
+ "143.198.141.16:18081",
+ "143.198.20.150:18081",
+ "143.244.128.5:18081",
+ "143.244.211.72:18081",
+ "144.172.99.203:18089",
+ "144.2.102.214:18089",
+ "144.2.90.54:18089",
+ "144.31.28.226:18089",
+ "144.91.121.7:18089",
+ "145.239.0.223:18081",
+ "145.241.100.52:18089",
+ "146.190.125.190:18081",
+ "146.190.196.200:18081",
+ "146.190.2.160:18081",
+ "146.59.108.136:18089",
+ "147.93.154.124:18081",
+ "148.251.80.54:18081",
+ "149.106.159.148:18081",
+ "149.202.89.206:18089",
+ "15.204.197.8:18081",
+ "15.204.72.133:18081",
+ "15.204.78.223:18081",
+ "15.218.116.247:18089",
+ "15.235.227.47:18089",
+ "15.235.227.59:18089",
+ "15.235.228.36:18089",
+ "151.15.58.128:18089",
+ "152.42.128.172:18081",
+ "152.53.102.87:18089",
+ "152.53.133.188:18089",
+ "152.53.150.12:18081",
+ "152.53.150.194:18081",
+ "152.53.3.244:18089",
+ "152.53.80.208:18089",
+ "152.53.95.190:18089",
+ "153.75.248.158:18089",
+ "154.26.133.182:18089",
+ "157.131.42.39:18089",
+ "157.173.24.223:18089",
+ "157.211.240.120:18089",
+ "157.230.101.76:18081",
+ "157.230.174.122:18081",
+ "157.245.217.225:18089",
+ "157.245.247.221:18081",
+ "158.173.147.72:18089",
+ "158.220.104.140:18081",
+ "158.220.114.42:18081",
+ "158.220.117.81:18081",
+ "158.220.126.7:18081",
+ "159.134.107.193:18089",
+ "159.195.57.197:18089",
+ "159.196.205.74:18089",
+ "159.203.129.135:18081",
+ "159.203.170.226:18081",
+ "159.203.18.49:18081",
+ "159.203.65.163:18089",
+ "159.203.73.96:18081",
+ "159.203.9.59:18081",
+ "159.223.17.65:18081",
+ "159.223.218.90:18081",
+ "159.65.173.223:18081",
+ "159.65.254.176:18081",
+ "159.65.33.220:18081",
+ "159.69.121.11:18081",
+ "159.69.188.3:18089",
+ "159.89.177.16:18089",
+ "159.89.19.87:18081",
+ "159.89.49.137:18081",
+ "159.89.98.22:18081",
+ "160.22.78.186:18081",
+ "161.230.143.14:28081",
+ "161.35.181.16:18081",
+ "161.35.26.217:18081",
+ "161.97.128.100:18089",
+ "161.97.79.219:18089",
+ "162.210.173.15:18089",
+ "162.226.250.137:18089",
+ "162.226.61.8:18081",
+ "162.227.141.189:18089",
+ "162.243.37.31:18081",
+ "162.246.16.146:18089",
+ "162.250.189.234:18089",
+ "162.251.5.90:18089",
+ "163.227.128.10:18081",
+ "163.227.128.200:18081",
+ "163.227.128.244:18081",
+ "163.227.128.66:18081",
+ "163.227.128.95:18081",
+ "163.227.192.51:18081",
+ "163.47.11.209:18081",
+ "163.61.44.215:18081",
+ "164.90.130.50:18081",
+ "164.92.85.147:18081",
+ "165.140.240.130:18089",
+ "165.22.115.36:18081",
+ "165.22.224.121:18081",
+ "165.22.253.197:18081",
+ "165.227.147.14:18081",
+ "165.227.150.164:18081",
+ "165.227.69.59:18081",
+ "165.227.99.51:18081",
+ "165.232.32.117:18081",
+ "165.245.138.134:18081",
+ "165.245.216.156:18081",
+ "165.245.217.223:18081",
+ "167.114.172.211:18081",
+ "167.114.18.32:18081",
+ "167.172.169.77:18081",
+ "167.172.181.228:18081",
+ "167.172.223.183:18081",
+ "167.172.41.194:18081",
+ "167.172.68.79:18081",
+ "167.172.81.104:18081",
+ "167.235.177.163:18089",
+ "167.235.224.192:18089",
+ "167.235.27.242:18089",
+ "167.71.134.224:18081",
+ "167.71.157.55:18081",
+ "167.71.182.115:18089",
+ "167.71.228.242:18081",
+ "167.71.241.148:18081",
+ "167.86.113.23:18081",
+ "167.86.119.18:18089",
+ "167.86.67.12:18081",
+ "167.99.197.192:18081",
+ "167.99.211.240:18081",
+ "167.99.233.252:18081",
+ "168.144.116.140:18081",
+ "168.144.116.144:18081",
+ "169.58.154.101:18081",
+ "169.58.2.112:18089",
+ "170.106.113.194:80",
+ "170.64.186.196:18081",
+ "172.104.188.12:18081",
+ "172.104.203.21:18081",
+ "172.105.122.150:18081",
+ "172.15.7.5:18089",
+ "172.232.216.246:18081",
+ "172.235.167.196:18081",
+ "172.239.20.30:18081",
+ "173.180.140.225:18089",
+ "173.187.149.67:18089",
+ "173.212.241.87:18081",
+ "173.255.212.53:18081",
+ "174.138.73.198:18089",
+ "174.163.3.56:18081",
+ "174.29.111.218:18081",
+ "174.51.45.206:18081",
+ "175.114.80.23:18089",
+ "176.123.6.130:18081",
+ "176.168.215.220:18089",
+ "176.79.32.98:18089",
+ "178.105.55.74:18081",
+ "178.128.130.225:18081",
+ "178.128.240.187:18081",
+ "178.224.236.16:18089",
+ "178.253.43.140:18089",
+ "178.62.247.28:18081",
+ "178.62.82.112:18081",
+ "179.237.121.78:18089",
+ "180.150.101.193:18089",
+ "180.150.27.133:18089",
+ "184.16.126.235:18089",
+ "184.75.221.59:18193",
+ "185.130.45.190:18081",
+ "185.132.176.201:18082",
+ "185.132.45.117:18089",
+ "185.132.53.199:18089",
+ "185.143.48.4:18089",
+ "185.147.158.77:18081",
+ "185.162.249.141:18089",
+ "185.165.170.150:18089",
+ "185.177.127.72:18089",
+ "185.183.34.250:18089",
+ "185.191.116.142:18089",
+ "185.198.234.118:18089",
+ "185.213.154.83:18081",
+ "185.220.101.223:18081",
+ "185.220.101.63:18081",
+ "185.224.3.40:18089",
+ "185.241.197.18:18081",
+ "185.246.84.179:18089",
+ "185.254.138.194:18089",
+ "185.66.143.190:18081",
+ "185.84.98.87:18081",
+ "185.85.240.191:18089",
+ "186.104.105.191:18089",
+ "186.105.146.19:18081",
+ "186.237.86.99:18089",
+ "187.65.117.37:18081",
+ "188.154.159.130:18089",
+ "188.245.192.31:18089",
+ "188.245.207.27:18089",
+ "188.245.229.65:18089",
+ "188.245.230.55:18081",
+ "188.245.49.156:18089",
+ "188.40.85.196:18081",
+ "190.18.197.241:18089",
+ "190.211.255.227:443",
+ "192.206.117.191:18081",
+ "192.241.170.114:18081",
+ "192.241.172.142:18081",
+ "192.46.210.231:18081",
+ "192.99.15.97:18089",
+ "192.99.37.121:18089",
+ "192.99.8.110:18089",
+ "193.138.218.77:18081",
+ "193.168.141.4:18081",
+ "193.168.143.101:18089",
+ "193.168.143.9:18081",
+ "193.30.122.232:18089",
+ "193.72.32.187:18089",
+ "194.147.140.17:18089",
+ "194.147.140.7:18081",
+ "194.163.130.145:18089",
+ "194.163.176.218:18089",
+ "195.133.47.31:18089",
+ "195.160.222.168:18081",
+ "195.66.213.39:18089",
+ "198.244.131.227:18081",
+ "198.44.159.43:6977",
+ "198.50.177.217:18081",
+ "199.244.51.100:18081",
+ "2.28.224.37:18089",
+ "202.137.172.241:18089",
+ "202.181.177.196:18081",
+ "204.10.194.186:18081",
+ "204.8.45.35:18081",
+ "204.93.126.93:18089",
+ "206.172.187.138:18081",
+ "206.189.135.78:18081",
+ "206.189.43.18:18081",
+ "206.206.78.182:18081",
+ "207.153.2.169:18089",
+ "207.180.226.99:18081",
+ "207.181.229.239:18089",
+ "207.195.159.14:18089",
+ "207.66.71.46:18089",
+ "207.89.71.54:18081",
+ "208.97.56.229:18081",
+ "209.126.83.236:18089",
+ "209.182.237.64:18090",
+ "209.38.17.208:18081",
+ "209.38.93.1:18081",
+ "209.97.142.240:18081",
+ "212.132.104.130:18089",
+ "212.33.255.113:18089",
+ "212.56.119.193:18081",
+ "213.109.162.82:18081",
+ "213.165.76.129:18089",
+ "216.17.34.28:18089",
+ "216.96.93.20:18089",
+ "217.156.8.212:18089",
+ "217.216.78.90:18081",
+ "217.229.84.8:18089",
+ "217.76.61.152:18089",
+ "220.233.93.57:18089",
+ "23.128.248.240:18089",
+ "23.131.76.144:18089",
+ "23.137.105.248:18089",
+ "23.137.254.9:18089",
+ "23.137.57.100:18089",
+ "23.171.112.218:18089",
+ "23.176.184.73:18089",
+ "23.187.144.242:18089",
+ "23.188.56.111:18081",
+ "23.191.201.7:18089",
+ "23.226.69.178:18089",
+ "23.226.69.234:18089",
+ "23.239.13.120:18081",
+ "23.94.74.248:18081",
+ "24.144.78.169:18081",
+ "24.156.190.235:18089",
+ "24.165.33.230:18081",
+ "24.180.70.29:18089",
+ "24.181.86.196:18081",
+ "24.199.126.115:18081",
+ "24.199.71.126:18081",
+ "31.16.170.127:18089",
+ "31.201.110.138:18089",
+ "31.56.36.64:18081",
+ "31.57.129.62:18089",
+ "31.57.219.98:18089",
+ "34.159.89.210:18081",
+ "34.162.176.65:18089",
+ "34.162.254.34:18089",
+ "34.162.53.250:18089",
+ "34.162.63.87:18089",
+ "34.18.4.119:18089",
+ "34.18.76.191:18089",
+ "34.18.97.163:18089",
+ "34.18.99.247:18089",
+ "34.38.63.61:18089",
+ "34.38.9.65:18089",
+ "34.76.148.167:18089",
+ "34.78.99.250:18089",
+ "34.81.1.145:18089",
+ "34.81.172.77:18089",
+ "34.95.247.125:18081",
+ "35.190.218.60:18089",
+ "35.194.218.1:18089",
+ "35.194.238.197:18089",
+ "35.198.32.241:18081",
+ "35.201.138.175:18089",
+ "35.236.160.100:18089",
+ "37.153.1.231:18089",
+ "37.187.129.139:18081",
+ "37.187.74.171:18089",
+ "37.48.112.198:18089",
+ "37.60.230.43:18081",
+ "37.60.231.104:18081",
+ "37.60.231.127:18081",
+ "38.102.127.29:18089",
+ "38.186.126.109:18081",
+ "38.46.89.52:18081",
+ "40.160.139.239:18081",
+ "40.160.4.147:18081",
+ "40.160.5.120:18081",
+ "45.11.16.140:18089",
+ "45.13.59.38:18089",
+ "45.140.213.178:18081",
+ "45.142.176.163:18089",
+ "45.142.30.74:18089",
+ "45.15.150.76:18081",
+ "45.43.14.195:18081",
+ "45.79.143.128:18081",
+ "45.84.59.11:18089",
+ "45.84.59.17:18081",
+ "45.87.251.141:18089",
+ "45.9.149.100:18089",
+ "46.101.147.130:18089",
+ "46.110.126.165:18089",
+ "46.188.104.91:30081",
+ "46.250.239.14:18089",
+ "46.250.244.25:18089",
+ "46.32.46.171:18081",
+ "46.40.124.27:18089",
+ "47.187.37.122:18089",
+ "47.203.219.143:18089",
+ "49.12.12.90:18089",
+ "49.13.1.121:18089",
+ "49.13.18.244:18089",
+ "49.13.48.122:18089",
+ "49.13.72.35:18089",
+ "49.13.76.60:18089",
+ "49.206.194.53:18089",
+ "5.104.84.64:18089",
+ "5.255.106.174:18081",
+ "5.39.23.134:18081",
+ "5.61.52.184:18089",
+ "5.9.89.57:18089",
+ "50.116.20.6:18089",
+ "50.116.56.159:18081",
+ "50.120.57.59:18089",
+ "50.35.67.167:18081",
+ "50.54.156.49:18089",
+ "50.71.202.28:18089",
+ "51.195.219.36:18081",
+ "51.210.222.91:18089",
+ "51.222.40.186:18089",
+ "51.68.212.53:18089",
+ "51.89.165.64:18081",
+ "51.89.41.42:443",
+ "51.91.215.198:18089",
+ "57.128.246.105:18089",
+ "58.105.164.185:18089",
+ "62.146.228.166:18089",
+ "62.171.172.91:18081",
+ "62.214.232.15:18089",
+ "62.250.208.213:18081",
+ "62.3.53.48:18089",
+ "62.45.194.66:18089",
+ "62.78.195.70:18089",
+ "62.99.13.205:18089",
+ "64.176.25.246:18081",
+ "64.226.105.236:18081",
+ "64.227.103.173:18081",
+ "64.227.180.31:18081",
+ "64.227.26.62:18081",
+ "64.246.104.92:18089",
+ "64.31.61.150:18089",
+ "64.74.162.85:18089",
+ "64.98.119.136:18089",
+ "65.108.133.154:18081",
+ "65.108.235.49:18089",
+ "65.108.8.181:18085",
+ "65.109.71.97:18089",
+ "65.109.99.56:18089",
+ "65.130.240.137:18089",
+ "65.21.212.204:18089",
+ "65.21.232.155:18089",
+ "65.31.34.253:18081",
+ "66.158.179.123:18081",
+ "66.228.57.18:18081",
+ "66.42.121.201:18089",
+ "66.44.61.176:18089",
+ "67.177.237.91:18089",
+ "67.177.42.164:18081",
+ "67.207.71.175:18081",
+ "67.240.36.204:18089",
+ "68.183.144.184:18081",
+ "68.183.150.15:18089",
+ "68.183.158.142:18081",
+ "68.183.214.27:18081",
+ "68.183.222.35:18081",
+ "68.183.28.158:18081",
+ "68.183.8.163:18081",
+ "68.252.222.137:18089",
+ "68.89.248.49:18089",
+ "69.109.232.200:18089",
+ "69.221.140.174:18089",
+ "69.30.225.138:18089",
+ "69.9.216.114:18081",
+ "70.123.161.202:18081",
+ "70.53.4.21:18089",
+ "71.191.176.21:18089",
+ "71.31.211.226:18089",
+ "71.61.149.115:18081",
+ "72.239.112.161:18089",
+ "72.34.98.2:18089",
+ "72.73.113.140:18089",
+ "73.243.24.83:18081",
+ "73.246.174.237:18089",
+ "73.65.25.51:18089",
+ "74.0.48.70:18081",
+ "74.119.149.17:18081",
+ "74.201.73.90:18089",
+ "74.210.205.103:18089",
+ "74.214.179.53:18089",
+ "74.85.229.24:18089",
+ "75.102.27.126:18089",
+ "75.143.26.248:18089",
+ "75.163.190.63:18089",
+ "76.120.189.45:18089",
+ "76.71.121.36:18089",
+ "77.109.149.217:18089",
+ "77.111.56.218:18089",
+ "77.183.165.131:18081",
+ "77.223.214.76:18081",
+ "77.33.31.34:18081",
+ "77.51.191.79:18081",
+ "77.54.111.144:18089",
+ "77.57.208.155:18089",
+ "77.68.93.144:18089",
+ "77.74.85.157:18089",
+ "77.8.207.135:18089",
+ "78.138.61.70:18089",
+ "78.36.200.128:18089",
+ "78.44.160.118:18081",
+ "78.97.155.230:18089",
+ "79.112.9.84:18089",
+ "79.189.125.171:18081",
+ "79.97.42.37:18089",
+ "80.132.76.126:18081",
+ "80.139.34.123:18081",
+ "80.153.185.25:18089",
+ "80.239.189.97:18089",
+ "80.69.42.48:18089",
+ "81.17.30.210:18081",
+ "81.183.239.91:18081",
+ "81.196.202.86:18081",
+ "81.207.74.50:18081",
+ "81.245.216.98:18089",
+ "82.105.129.93:18089",
+ "82.149.227.116:18081",
+ "82.153.138.164:18081",
+ "82.153.138.188:18089",
+ "82.153.138.31:18089",
+ "82.64.166.200:18081",
+ "82.66.149.90:18089",
+ "82.66.89.35:18089",
+ "82.67.7.32:18089",
+ "83.21.205.254:18081",
+ "83.238.168.206:18089",
+ "83.251.141.124:18081",
+ "83.99.142.174:18089",
+ "84.247.152.225:18089",
+ "84.32.83.49:18089",
+ "84.39.245.171:18081",
+ "84.73.145.29:18089",
+ "85.0.165.195:18081",
+ "85.137.252.1:18089",
+ "85.146.187.206:18089",
+ "85.164.134.12:18089",
+ "85.74.214.70:18089",
+ "86.106.84.166:46279",
+ "86.48.0.131:18081",
+ "87.106.158.70:18089",
+ "87.106.213.199:18089",
+ "87.197.115.178:18081",
+ "87.63.200.138:18089",
+ "88.214.26.118:18089",
+ "88.216.130.84:18089",
+ "88.216.197.106:18089",
+ "88.217.37.131:18089",
+ "88.3.210.198:18081",
+ "88.68.98.227:18089",
+ "88.71.210.138:18081",
+ "88.80.150.48:3389",
+ "88.80.229.74:18089",
+ "88.99.195.15:18089",
+ "89.116.156.14:18081",
+ "89.116.156.50:18081",
+ "89.116.156.67:18081",
+ "89.116.156.69:18081",
+ "89.116.156.73:18081",
+ "89.116.156.76:18081",
+ "89.116.156.77:18081",
+ "89.116.156.80:18081",
+ "89.116.156.81:18081",
+ "89.116.156.85:18081",
+ "89.116.156.90:18081",
+ "89.116.156.9:18081",
+ "89.116.171.233:18081",
+ "89.116.246.155:18081",
+ "89.116.246.194:18081",
+ "89.116.246.197:18081",
+ "89.116.246.199:18081",
+ "89.116.246.202:18081",
+ "89.116.246.207:18081",
+ "89.116.246.210:18081",
+ "89.116.246.214:18081",
+ "89.116.246.228:18081",
+ "89.116.246.229:18081",
+ "89.116.246.54:18081",
+ "89.116.246.56:18081",
+ "89.116.246.57:18081",
+ "89.116.246.59:18081",
+ "89.116.246.82:18081",
+ "89.116.246.84:18081",
+ "89.125.187.247:18089",
+ "89.127.235.222:18081",
+ "89.167.0.172:18089",
+ "89.219.15.106:18089",
+ "89.247.27.180:18081",
+ "89.58.3.58:18081",
+ "89.58.60.70:18081",
+ "90.242.74.36:18081",
+ "91.18.235.243:18089",
+ "91.188.119.135:18089",
+ "91.200.29.139:18081",
+ "91.206.17.195:981",
+ "91.224.92.48:18089",
+ "91.236.10.252:18089",
+ "91.248.19.166:18089",
+ "92.116.198.124:18089",
+ "92.204.53.38:18081",
+ "92.212.225.21:18089",
+ "92.220.123.27:18089",
+ "92.60.36.162:18089",
+ "93.136.148.148:18089",
+ "93.181.39.26:18089",
+ "93.197.186.219:18089",
+ "93.222.243.177:18089",
+ "94.250.201.231:18081",
+ "94.251.70.85:18089",
+ "95.111.236.211:18089",
+ "95.144.114.230:18089",
+ "95.155.151.116:18081",
+ "95.160.51.250:18089",
+ "95.172.227.163:18089",
+ "95.216.13.216:18081",
+ "95.216.226.230:18089",
+ "95.216.245.77:18089",
+ "95.217.126.126:18081",
+ "95.31.191.92:30081",
+ "95.88.110.230:11816",
+ "96.227.127.63:18089",
+ "96.239.86.174:18089",
+ "96.72.113.147:18089",
+ "96.93.91.49:18089",
+ "97.107.134.35:18081",
+ "98.111.208.185:18089",
+ "98.161.137.228:18089",
+ "98.236.100.27:18089",
+ "99.103.106.27:18089",
+ "99.152.32.222:18089",
+ "99.236.132.17:18089",
+ "99.248.12.15:18089",
+ "99.252.41.14:18081",
+ "99.26.189.25:18081",
+ "99.3.31.176:18089"
+]
### main.qml
@@ -50,6 +50,7 @@ import "components" as MoneroComponents
import "components/effects" as MoneroEffects
import "pages/merchant" as MoneroMerchant
import "wizard"
+import "js/RemoteNodes.js" as RemoteNodes
import "js/Utils.js" as Utils
import "js/Windows.js" as Windows
import "version.js" as Version
@@ -80,7 +81,7 @@ ApplicationWindow {
property bool daemonSynced: false
property bool walletSynced: false
property int maxWindowHeight: (isAndroid || isIOS)? screenAvailableHeight : (screenAvailableHeight < 900)? 720 : 800;
- property bool daemonRunning: !persistentSettings.useRemoteNode && !disconnected
+ property bool daemonRunning: walletMode >= 2 && !persistentSettings.useRemoteNode && !disconnected
property int daemonStartStopInProgress: 0
property alias toolTip: toolTip
property string walletName
@@ -98,6 +99,9 @@ ApplicationWindow {
readonly property string localDaemonAddress : "localhost:" + getDefaultDaemonRpcPort(persistentSettings.nettype)
property string currentDaemonAddress;
property int disconnectedEpoch: 0
+ property int simpleModeIndex: 0
+ property var simpleModeAddresses: []
+ property var failedSimpleModeAddresses: ({})
property int estimatedBlockchainSize: persistentSettings.pruneBlockchain ? 110 : 270 // GB
property alias viewState: rootItem.state
property string prevSplashText;
@@ -312,6 +316,7 @@ ApplicationWindow {
currentWallet.unconfirmedMoneyReceived.disconnect(onWalletUnconfirmedMoneyReceived)
currentWallet.transactionCreated.disconnect(onTransactionCreated)
currentWallet.connectionStatusChanged.disconnect(onWalletConnectionStatusChanged)
+ currentWallet.initializingChanged.disconnect(onWalletInitializingChanged)
currentWallet.deviceButtonRequest.disconnect(onDeviceButtonRequest);
currentWallet.deviceButtonPressed.disconnect(onDeviceButtonPressed);
currentWallet.walletPassphraseNeeded.disconnect(onWalletPassphraseNeededWallet);
@@ -350,6 +355,14 @@ ApplicationWindow {
persistentSettings.nettype = currentWallet.nettype;
}
+ // The bundled public nodes only serve mainnet.
+ if (appWindow.walletMode == 0 && currentWallet.nettype != NetworkType.MAINNET) {
+ changeWalletMode(2);
+ }
+ if (appWindow.walletMode == 0) {
+ initializeSimpleMode();
+ }
+
// connect handlers
currentWallet.heightRefreshed.connect(onHeightRefreshed);
currentWallet.refreshed.connect(onWalletRefresh)
@@ -363,6 +376,7 @@ ApplicationWindow {
currentWallet.unconfirmedMoneyReceived.connect(onWalletUnconfirmedMoneyReceived)
currentWallet.transactionCreated.connect(onTransactionCreated)
currentWallet.connectionStatusChanged.connect(onWalletConnectionStatusChanged)
+ currentWallet.initializingChanged.connect(onWalletInitializingChanged)
currentWallet.deviceButtonRequest.connect(onDeviceButtonRequest);
currentWallet.deviceButtonPressed.connect(onDeviceButtonPressed);
currentWallet.walletPassphraseNeeded.connect(onWalletPassphraseNeededWallet);
@@ -378,7 +392,10 @@ ApplicationWindow {
console.log("Recovering from seed: ", persistentSettings.is_recovering)
console.log("restore Height", persistentSettings.restore_height)
- if (persistentSettings.useRemoteNode) {
+ if (appWindow.walletMode == 0) {
+ currentDaemonAddress = currentSimpleModeAddress();
+ currentWallet.setDaemonLogin("", "");
+ } else if (persistentSettings.useRemoteNode) {
const remoteNode = remoteNodesModel.currentRemoteNode();
currentDaemonAddress = remoteNode.address;
currentWallet.setDaemonLogin(remoteNode.username, remoteNode.password);
@@ -387,6 +404,10 @@ ApplicationWindow {
}
console.log("initializing with daemon address: ", currentDaemonAddress)
+ disconnectedEpoch = Utils.epoch();
+ if (appWindow.walletMode >= 2) {
+ walletManager.setDaemonAddressAsync(currentDaemonAddress);
+ }
currentWallet.initAsync(
currentDaemonAddress,
isTrustedDaemon(),
@@ -404,6 +425,81 @@ ApplicationWindow {
return appWindow.walletMode >= 2 && (!persistentSettings.useRemoteNode || remoteNodesModel.currentRemoteNode().trusted);
}
+ function currentSimpleModeAddress() {
+ return simpleModeAddresses[simpleModeIndex] || "";
+ }
+
+ function initializeSimpleMode() {
+ daemonSynced = false;
+ // Shuffle alternatives, but prefer the last node that connected successfully.
+ var addresses = [];
+ for (var i = 0; i < RemoteNodes.addresses.length; ++i) {
+ var node = RemoteNodes.addresses[i];
+ if (node.indexOf(":") == -1) {
+ node += ":" + getDefaultDaemonRpcPort(NetworkType.MAINNET);
+ }
+ if (addresses.indexOf(node) == -1) {
+ addresses.push(node);
+ }
+ }
+ for (var index = addresses.length - 1; index > 0; --index) {
+ const other = Math.floor(Math.random() * (index + 1));
+ const address = addresses[index];
+ addresses[index] = addresses[other];
+ addresses[other] = address;
+ }
+ simpleModeAddresses = addresses;
+ var lastWorkingAddress = persistentSettings.lastWorkingSimpleModeAddress;
+ if (lastWorkingAddress && lastWorkingAddress.indexOf(":") == -1) {
+ lastWorkingAddress += ":" + getDefaultDaemonRpcPort(NetworkType.MAINNET);
+ }
+ simpleModeIndex = Math.max(0, addresses.indexOf(lastWorkingAddress));
+ if (failedSimpleModeAddresses[currentSimpleModeAddress()]) {
+ simpleModeIndex = nextSimpleModeIndex();
+ }
+ }
+
+ function nextSimpleModeIndex() {
+ if (simpleModeAddresses.length < 2) {
+ return 0;
+ }
+ for (var offset = 1; offset < simpleModeAddresses.length; ++offset) {
+ const index = (simpleModeIndex + offset) % simpleModeAddresses.length;
+ if (!failedSimpleModeAddresses[simpleModeAddresses[index]]) {
+ return index;
+ }
+ }
+ // All alternatives failed. Clear the failures and try again.
+ failedSimpleModeAddresses = ({});
+ return (simpleModeIndex + 1) % simpleModeAddresses.length;
+ }
+
+ function switchSimpleModeNode(penalizeCurrent) {
+ if (appWindow.walletMode != 0 || !currentWallet || currentWallet.initializing || simpleModeAddresses.length < 2) {
+ return false;
+ }
+
+ if (penalizeCurrent !== false) {
+ failedSimpleModeAddresses[currentDaemonAddress] = true;
+ }
+ simpleModeIndex = nextSimpleModeIndex();
+ currentDaemonAddress = currentSimpleModeAddress();
+ disconnectedEpoch = Utils.epoch();
+ daemonSynced = false;
+ firstBlockSeen = 0;
+ console.log("Switching public node to", currentDaemonAddress);
+ currentWallet.setDaemonLogin("", "");
+ currentWallet.initAsync(
+ currentDaemonAddress,
+ false,
+ 0,
+ false,
+ false,
+ 0,
+ persistentSettings.getWalletProxyAddress());
+ return true;
+ }
+
function usefulName(path) {
// arbitrary "short enough" limit
if (path.length < 32)
@@ -463,6 +559,13 @@ ApplicationWindow {
}
}
+ function onWalletInitializingChanged() {
+ if (appWindow.walletMode == 0 && currentWallet) {
+ // Draining the previous scan must not use up the new node's timeout.
+ disconnectedEpoch = currentWallet.initializing ? 0 : Utils.epoch();
+ }
+ }
+
function onWalletConnectionStatusChanged(status){
console.log("Wallet connection status changed " + status)
middlePanel.updateStatus();
@@ -485,7 +588,7 @@ ApplicationWindow {
walletInitialized = true
// check if daemon was already mining and add mining logo if true
- if (!persistentSettings.useRemoteNode || persistentSettings.allowRemoteNodeMining) {
+ if (appWindow.walletMode >= 2 && (!persistentSettings.useRemoteNode || persistentSettings.allowRemoteNodeMining)) {
middlePanel.advancedView.miningView.update();
}
}
@@ -678,12 +781,18 @@ ApplicationWindow {
}
function connectRemoteNode() {
+ if (!currentWallet || currentWallet.initializing)
+ return;
+
console.log("connecting remote node");
p2poolManager.exit();
p2poolManager.getStatus();
const callback = function() {
+ if (!currentWallet || currentWallet.initializing)
+ return;
+
persistentSettings.useRemoteNode = true;
const remoteNode = remoteNodesModel.currentRemoteNode();
currentDaemonAddress = remoteNode.address;
@@ -707,7 +816,7 @@ ApplicationWindow {
}
function disconnectRemoteNode() {
- if (typeof currentWallet === "undefined" || currentWallet === null)
+ if (!currentWallet || currentWallet.initializing)
return;
console.log("disconnecting remote node");
@@ -731,13 +840,16 @@ ApplicationWindow {
}
function onHeightRefreshed(bcHeight, dCurrentBlock, dTargetBlock) {
+ if (!currentWallet || currentWallet.initializing)
+ return;
+
// Daemon fully synced
// TODO: implement onDaemonSynced or similar in wallet API and don't start refresh thread before daemon is synced
// targetBlock = currentBlock = 1 before network connection is established.
if (firstBlockSeen == 0 && dTargetBlock != 1) {
firstBlockSeen = dCurrentBlock;
}
- daemonSynced = dCurrentBlock >= dTargetBlock && dTargetBlock != 1
+ daemonSynced = dTargetBlock > 1 && dCurrentBlock >= dTargetBlock
walletSynced = bcHeight >= dTargetBlock
// Update progress bars
@@ -789,9 +901,7 @@ ApplicationWindow {
// Pause refresh while starting daemon
currentWallet.pauseRefresh();
- const noSync = appWindow.walletMode === 0;
- const bootstrapNodeAddress = persistentSettings.walletMode < 2 ? "auto" : persistentSettings.bootstrapNodeAddress
- daemonManager.start(flags, persistentSettings.nettype, persistentSettings.blockchainDataDir, bootstrapNodeAddress, noSync, persistentSettings.pruneBlockchain);
+ daemonManager.start(flags, persistentSettings.nettype, persistentSettings.blockchainDataDir, persistentSettings.bootstrapNodeAddress, persistentSettings.pruneBlockchain);
}
function stopDaemon(callback, splash){
@@ -817,8 +927,6 @@ ApplicationWindow {
// resume refresh
currentWallet.startRefresh();
}
- // resume simplemode connection timer
- appWindow.disconnectedEpoch = Utils.epoch();
}
function onDaemonStopped(){
if (currentWallet) {
@@ -844,6 +952,16 @@ ApplicationWindow {
}
function onWalletNewBlock(blockHeight, targetHeight) {
+ if (!currentWallet || currentWallet.initializing)
+ return;
+
+ // A long initial scan reports blocks before its first refresh completes.
+ // The wallet only scans once the daemon is synchronized.
+ daemonSynced = true;
+ if (appWindow.walletMode == 0) {
+ disconnectedEpoch = Utils.epoch();
+ }
+
// Update progress bar
var remaining = targetHeight - blockHeight;
if(blocksToSync < remaining) {
@@ -1540,6 +1658,7 @@ ApplicationWindow {
: [],
})
property string bootstrapNodeAddress: ""
+ property string lastWorkingSimpleModeAddress: ""
property bool segregatePreForkOutputs: true
property bool keyReuseMitigation2: true
property int segregationHeight: 0
@@ -1577,20 +1696,25 @@ ApplicationWindow {
return "socks5://" + proxyAddress;
}
function getWalletProxyAddress() {
+ if (appWindow.walletMode == 0) {
+ return getProxyAddress();
+ }
if (!useRemoteNode) {
return "";
- } else {
- const remoteAddress = remoteNodesModel.currentRemoteNode().address;
- // skip proxy when using localhost remote node
- if (/^(127\.0\.0\.1|localhost):[0-9]+$/i.test(remoteAddress)) {
- return "";
- } else {
- return getProxyAddress();
- }
}
+ const remoteNode = remoteNodesModel.currentRemoteNode();
+ const remoteAddress = remoteNode ? remoteNode.address : "";
+ // skip proxy when using localhost remote node
+ if (/^(127\.0\.0\.1|localhost):[0-9]+$/i.test(remoteAddress)) {
+ return "";
+ }
+ return getProxyAddress();
}
Component.onCompleted: {
+ if (persistentSettings.walletMode == 1) {
+ persistentSettings.walletMode = 0;
+ }
MoneroComponents.Style.blackTheme = persistentSettings.blackTheme
if (!appWindow.fiatPriceAPIs.hasOwnProperty(fiatPriceProvider)) {
@@ -1648,6 +1772,9 @@ ApplicationWindow {
}
function applyRemoteNode(index) {
+ if (currentWallet && currentWallet.initializing)
+ return;
+
selected = index;
persistentSettings.useRemoteNode = true;
if (currentWallet) {
@@ -2151,50 +2278,31 @@ ApplicationWindow {
onTriggered: appWindow.themeTransition = true;
}
- function checkNoSyncFlag() {
- if (!appWindow.daemonRunning) {
- return true;
- }
- if (appWindow.walletMode == 0 && !daemonManager.noSync()) {
- return false;
- }
- if (appWindow.walletMode == 1 && daemonManager.noSync()) {
- return false;
- }
- return true;
- }
-
- function checkSimpleModeConnection(){
- const disconnectedTimeoutSec = 30;
- const firstCheckDelaySec = 2;
-
- const firstRun = appWindow.disconnectedEpoch == 0;
- if (firstRun) {
- appWindow.disconnectedEpoch = Utils.epoch() + firstCheckDelaySec - disconnectedTimeoutSec;
- } else if (!disconnected) {
- appWindow.disconnectedEpoch = Utils.epoch();
- }
-
- const sinceLastConnect = Utils.epoch() - appWindow.disconnectedEpoch;
- if (sinceLastConnect < disconnectedTimeoutSec && checkNoSyncFlag()) {
+ function checkSimpleModeConnection() {
+ if (!currentWallet || currentWallet.initializing)
return;
- }
- const simpleModeFlags = "--enable-dns-blocklist --out-peers 16 --no-igd";
- if (appWindow.daemonRunning) {
- appWindow.stopDaemon(function() {
- appWindow.startDaemon(simpleModeFlags)
- });
- } else {
- appWindow.startDaemon(simpleModeFlags);
+ const now = Utils.epoch();
+ // The worker may finish before its initializingChanged signal is delivered.
+ if (disconnectedEpoch == 0) {
+ disconnectedEpoch = now;
+ }
+ const connectionStatus = currentWallet.connected();
+ if (connectionStatus == Wallet.ConnectionStatus_Connected && daemonSynced) {
+ disconnectedEpoch = now;
+ persistentSettings.lastWorkingSimpleModeAddress = currentDaemonAddress;
+ } else if (connectionStatus == Wallet.ConnectionStatus_Disconnected ||
+ connectionStatus == Wallet.ConnectionStatus_WrongVersion ||
+ now - disconnectedEpoch >= 30) {
+ switchSimpleModeNode();
}
}
Timer {
// Simple mode connection check timer
id: simpleModeConnectionTimer
interval: 2000
- running: appWindow.walletMode < 2 && currentWallet != undefined && daemonStartStopInProgress == 0
+ running: appWindow.walletMode == 0 && currentWallet != undefined
repeat: true
onTriggered: appWindow.checkSimpleModeConnection()
}
@@ -2268,10 +2376,8 @@ ApplicationWindow {
}
// If daemon is running - prompt user before exiting
- if(daemonManager == undefined || persistentSettings.useRemoteNode) {
+ if(daemonManager == undefined || persistentSettings.useRemoteNode || appWindow.walletMode == 0) {
closeAccepted();
- } else if (appWindow.walletMode == 0) {
- stopDaemon(closeAccepted, true);
} else {
showProcessingSplash(qsTr("Checking local node status..."));
const handler = function(running) {
@@ -2440,7 +2546,7 @@ ApplicationWindow {
middlePanel.settingsView.settingsStateViewState = "Wallet"
}
}
- console.log("walletMode: " + (mode === 0 ? "simple": mode === 1 ? "simple (bootstrap)" : "Advanced"));
+ console.log("walletMode: " + (mode === 0 ? "simple" : "Advanced"));
}
Rectangle {
### pages/Mining.qml
@@ -602,7 +602,6 @@ Rectangle {
}
function startP2PoolLocal() {
- var noSync = false;
//these args will be deleted because DaemonManager::start will re-add them later.
//--no-zmq must be deleted. removing '--zmq-pub=tcp...' lets us blindly add '--zmq-pub tcp...' later without risking duplication.
var defaultArgs = ["--detach","--data-dir","--bootstrap-daemon-address","--prune-blockchain","--no-sync","--check-updates","--non-interactive","--max-concurrency","--no-zmq","--zmq-pub=tcp://127.0.0.1:18083"]
@@ -631,7 +630,7 @@ allArgs = allArgs.filter( ( el ) => !defaultArgs.includes( el.split(" ")[0] ) )
continue
}
}
- var success = daemonManager.start(allArgs.join(" "), persistentSettings.nettype, persistentSettings.blockchainDataDir, persistentSettings.bootstrapNodeAddress, noSync, persistentSettings.pruneBlockchain)
+ var success = daemonManager.start(allArgs.join(" "), persistentSettings.nettype, persistentSettings.blockchainDataDir, persistentSettings.bootstrapNodeAddress, persistentSettings.pruneBlockchain)
if (success) {
startP2Pool()
}
### pages/settings/SettingsInfo.qml
@@ -55,8 +55,6 @@ Rectangle {
var modeStr;
if(appWindow.walletMode === 0){
modeStr = qsTr("Simple mode") + translationManager.emptyString;
- } else if(appWindow.walletMode === 1){
- modeStr = qsTr("Simple mode") + " (bootstrap)" + translationManager.emptyString;
} else if(appWindow.walletMode === 2){
modeStr = "%1 (%2)".arg(qsTr("Advanced mode")).arg(persistentSettings.useRemoteNode ? qsTr("Remote node") : qsTr("Local node")) + translationManager.emptyString;
}
@@ -337,6 +335,37 @@ Rectangle {
opacity: MoneroComponents.Style.dividerOpacity
}
+ MoneroComponents.TextBlock {
+ Layout.fillWidth: true
+ font.pixelSize: 14
+ text: qsTr("Node address: ") + translationManager.emptyString
+ }
+
+ MoneroComponents.TextBlock {
+ Layout.fillWidth: true
+ color: MoneroComponents.Style.dimmedFontColor
+ font.pixelSize: 14
+ text: appWindow.currentDaemonAddress || ""
+ }
+
+ Rectangle {
+ height: 1
+ Layout.topMargin: 2
+ Layout.bottomMargin: 2
+ Layout.fillWidth: true
+ color: MoneroComponents.Style.dividerColor
+ opacity: MoneroComponents.Style.dividerOpacity
+ }
+
+ Rectangle {
+ height: 1
+ Layout.topMargin: 2
+ Layout.bottomMargin: 2
+ Layout.fillWidth: true
+ color: MoneroComponents.Style.dividerColor
+ opacity: MoneroComponents.Style.dividerOpacity
+ }
+
MoneroComponents.TextBlock {
Layout.fillWidth: true
font.pixelSize: 14
@@ -404,6 +433,7 @@ Rectangle {
data += "\nWallet log path: " + logger.logFilePath;
data += "\nWallet mode: " + walletModeString;
+ data += "\nNode address: " + (appWindow.currentDaemonAddress || "");
data += "\nGraphics mode: " + rendererName;
if (isTails)
data += "\nTails: " + (tailsUsePersistence ? "persistent" : "persistence disabled");
### pages/settings/SettingsLayout.qml
@@ -284,7 +284,7 @@ Rectangle {
persistentSettings.proxyEnabled = !persistentSettings.proxyEnabled;
}
text: qsTr("Socks5 proxy (%1%2)")
- .arg(appWindow.walletMode >= 2 ? qsTr("remote node connections, ") : "")
+ .arg(qsTr("remote node connections, "))
.arg(qsTr("updates downloading, fetching price sources")) + translationManager.emptyString
}
### pages/settings/SettingsLog.qml
@@ -233,7 +233,7 @@ Rectangle {
inputPaddingBottom: 0
property var lastCommands: []
property int currentCommandIndex
- enabled: !persistentSettings.useRemoteNode
+ enabled: appWindow.walletMode >= 2 && !persistentSettings.useRemoteNode
fontBold: false
fontSize: 16
placeholderText: qsTr("Type a command (e.g '%1' or '%2') and press Enter").arg("help").arg("status") + translationManager.emptyString
### pages/settings/SettingsNode.qml
@@ -38,6 +38,7 @@ import "../../components/effects" as MoneroEffects
Rectangle{
color: "transparent"
Layout.fillWidth: true
+ enabled: !appWindow.currentWallet || !appWindow.currentWallet.initializing
property alias nodeHeight: root.height
/* main layout */
@@ -140,7 +141,6 @@ Rectangle{
anchors.fill: parent
enabled: persistentSettings.useRemoteNode
onClicked: {
- persistentSettings.useRemoteNode = false;
appWindow.disconnectRemoteNode();
}
}
### src/daemon/DaemonManager.cpp
@@ -48,7 +48,7 @@ namespace {
static const int DAEMON_START_TIMEOUT_SECONDS = 120;
}
-bool DaemonManager::start(const QString &flags, NetworkType::Type nettype, const QString &dataDir, const QString &bootstrapNodeAddress, bool noSync /* = false*/, bool pruneBlockchain /* = false*/)
+bool DaemonManager::start(const QString &flags, NetworkType::Type nettype, const QString &dataDir, const QString &bootstrapNodeAddress, bool pruneBlockchain /* = false*/)
{
if (!QFileInfo(m_monerod).isFile())
{
@@ -92,10 +92,6 @@ bool DaemonManager::start(const QString &flags, NetworkType::Type nettype, const
}
}
- if (noSync) {
- arguments << "--no-sync";
- }
-
arguments << "--check-updates" << "disabled";
arguments << "--non-interactive";
@@ -130,10 +126,9 @@ bool DaemonManager::start(const QString &flags, NetworkType::Type nettype, const
}
// Start start watcher
- m_scheduler.run([this, nettype, dataDir, noSync] {
+ m_scheduler.run([this, nettype, dataDir] {
if (startWatcher(nettype, dataDir)) {
emit daemonStarted();
- m_noSync = noSync;
} else {
emit daemonStartFailure(tr("Timed out, local node is not responding after %1 seconds").arg(DAEMON_START_TIMEOUT_SECONDS));
}
@@ -244,11 +239,6 @@ bool DaemonManager::running(NetworkType::Type nettype, const QString &dataDir) c
return status.contains("Height:");
}
-bool DaemonManager::noSync() const noexcept
-{
- return m_noSync;
-}
-
void DaemonManager::runningAsync(NetworkType::Type nettype, const QString &dataDir, const QJSValue& callback) const
{
m_scheduler.run([this, nettype, dataDir] {
### src/daemon/DaemonManager.h
@@ -47,10 +47,9 @@ class DaemonManager : public QObject
explicit DaemonManager(QObject *parent = 0);
~DaemonManager();
- Q_INVOKABLE bool start(const QString &flags, NetworkType::Type nettype, const QString &dataDir = "", const QString &bootstrapNodeAddress = "", bool noSync = false, bool pruneBlockchain = false);
+ Q_INVOKABLE bool start(const QString &flags, NetworkType::Type nettype, const QString &dataDir = "", const QString &bootstrapNodeAddress = "", bool pruneBlockchain = false);
Q_INVOKABLE void stopAsync(NetworkType::Type nettype, const QString &dataDir, const QJSValue& callback);
- Q_INVOKABLE bool noSync() const noexcept;
// return true if daemon process is started
Q_INVOKABLE void runningAsync(NetworkType::Type nettype, const QString &dataDir, const QJSValue& callback) const;
// Send daemon command from qml and prints output in console window.
@@ -82,7 +81,6 @@ public slots:
QMutex m_daemonMutex;
QString m_monerod;
bool m_app_exit = false;
- bool m_noSync = false;
QString args = "";
mutable FutureScheduler m_scheduler;
### src/libwalletqt/Wallet.cpp
@@ -118,13 +118,27 @@ NetworkType::Type Wallet::nettype() const
void Wallet::updateConnectionStatusAsync()
{
m_scheduler.run([this] {
+ QMutexLocker locker(&m_connectionStatusMutex);
+ const auto cleanup = sg::make_scope_guard([this]() noexcept {
+ m_connectionStatusRunning = false;
+ m_connectionStatusTime.restart();
+ });
+ if (m_initializing || !m_initialized)
+ {
+ return;
+ }
+
qDebug() << "updateConnectionStatusAsync current status:" << m_connectionStatus;
if (m_connectionStatus == Wallet::ConnectionStatus_Disconnected)
{
setConnectionStatus(ConnectionStatus_Connecting);
}
ConnectionStatus newStatus = static_cast<ConnectionStatus>(m_walletImpl->connected());
qDebug() << "Newest wallet status:" << newStatus;
+ if (m_initializing)
+ {
+ return;
+ }
if (m_connectionStatus != newStatus)
{
setConnectionStatus(newStatus);
@@ -133,18 +147,19 @@ void Wallet::updateConnectionStatusAsync()
startRefresh();
}
}
- // Release lock
- m_connectionStatusRunning = false;
- m_connectionStatusTime.restart();
});
}
Wallet::ConnectionStatus Wallet::connected(bool forceCheck)
{
- if (!m_initialized || m_initializing)
+ if (m_initializing)
{
return ConnectionStatus_Connecting;
}
+ if (!m_initialized)
+ {
+ return ConnectionStatus_Disconnected;
+ }
// cache connection status
if (forceCheck || (m_connectionStatusTime.elapsed() / 1000 > m_connectionStatusTtl && !m_connectionStatusRunning) || m_connectionStatusTime.elapsed() > 30000) {
@@ -161,6 +176,11 @@ bool Wallet::disconnected() const
return m_disconnected;
}
+bool Wallet::initializing() const
+{
+ return m_initializing;
+}
+
bool Wallet::refreshing() const
{
return m_refreshing;
@@ -305,20 +325,43 @@ void Wallet::initAsync(
const QString &proxyAddress /* = "" */)
{
qDebug() << "initAsync: " + daemonAddress;
- m_initializing = true;
+ if (m_initializing.exchange(true))
+ {
+ return;
+ }
+ emit initializingChanged();
pauseRefresh();
+ setConnectionStatus(Wallet::ConnectionStatus_Connecting);
const auto future = m_scheduler.run([this, daemonAddress, daemonUsername = m_daemonUsername, daemonPassword = m_daemonPassword, trustedDaemon, upperTransactionLimit, isRecovering, isRecoveringFromDevice, restoreHeight, proxyAddress] {
- m_initialized = init(
- daemonAddress,
- daemonUsername,
- daemonPassword,
- trustedDaemon,
- upperTransactionLimit,
- isRecovering,
- isRecoveringFromDevice,
- restoreHeight,
- proxyAddress);
+ m_initialized = false;
+ try
+ {
+ QMutexLocker refreshLocker(&m_asyncMutex);
+ QMutexLocker connectionLocker(&m_connectionStatusMutex);
+ // Wait for any previous refresh or connection check before changing daemons.
+ pauseRefresh();
+ setConnectionStatus(Wallet::ConnectionStatus_Connecting);
+ m_initialized = init(
+ daemonAddress,
+ daemonUsername,
+ daemonPassword,
+ trustedDaemon,
+ upperTransactionLimit,
+ isRecovering,
+ isRecoveringFromDevice,
+ restoreHeight,
+ proxyAddress);
+ }
+ catch (const std::exception &exception)
+ {
+ qCritical() << "Failed to initialize the wallet:" << exception.what();
+ }
+ if (!m_initialized)
+ {
+ setConnectionStatus(Wallet::ConnectionStatus_Disconnected);
+ }
m_initializing = false;
+ emit initializingChanged();
if (m_initialized)
{
emit walletCreationHeightChanged();
@@ -330,9 +373,12 @@ void Wallet::initAsync(
qCritical() << "Failed to initialize the wallet";
}
});
- if (future.first)
+ if (!future.first)
{
- setConnectionStatus(Wallet::ConnectionStatus_Connecting);
+ m_initialized = false;
+ setConnectionStatus(Wallet::ConnectionStatus_Disconnected);
+ m_initializing = false;
+ emit initializingChanged();
}
}
@@ -621,6 +667,11 @@ bool Wallet::refresh(bool historyAndSubaddresses /* = true */)
{
QMutexLocker locker(&m_asyncMutex);
+ if (m_initializing)
+ {
+ return false;
+ }
+
bool result = m_walletImpl->refresh();
if (historyAndSubaddresses)
{
### src/libwalletqt/Wallet.h
@@ -75,6 +75,7 @@ class Wallet : public QObject, public PassprasePrompter
{
Q_OBJECT
Q_PROPERTY(bool disconnected READ disconnected NOTIFY disconnectedChanged)
+ Q_PROPERTY(bool initializing READ initializing NOTIFY initializingChanged)
Q_PROPERTY(bool refreshing READ refreshing NOTIFY refreshingChanged)
Q_PROPERTY(QString seed READ getSeed)
Q_PROPERTY(QString seedLanguage READ getSeedLanguage)
@@ -427,6 +428,7 @@ class Wallet : public QObject, public PassprasePrompter
void connectionStatusChanged(int status) const;
void currentSubaddressAccountChanged() const;
void disconnectedChanged() const;
+ void initializingChanged() const;
void proxyAddressChanged() const;
void refreshingChanged() const;
@@ -465,6 +467,7 @@ class Wallet : public QObject, public PassprasePrompter
PendingTransaction::Priority priority);
bool disconnected() const;
+ bool initializing() const;
bool refreshing() const;
void refreshingSet(bool value);
void setConnectionStatus(ConnectionStatus value);
### src/main/main.cpp
@@ -243,7 +243,7 @@ Verify update binary using 'shasum'-compatible (SHA256 algo) output signed by tw
QCommandLineOption disableCheckUpdatesOption("disable-check-updates", "Disable automatic check for updates.");
parser.addOption(disableCheckUpdatesOption);
- QCommandLineOption socksProxyOption("socks5-proxy", "Enable socks5 proxy. Used for remote node connection (advanced mode), updates downloading and fetching price sources.", "address:port");
+ QCommandLineOption socksProxyOption("socks5-proxy", "Enable socks5 proxy. Used for remote node connections, updates downloading and fetching price sources.", "address:port");
parser.addOption(socksProxyOption);
QCommandLineOption checkQmlOption("check-qml");
checkQmlOption.setFlags(QCommandLineOption::HiddenFromHelp);
### wizard/WizardController.qml
@@ -100,7 +100,6 @@ Rectangle {
property string walletOptionsRecoverSpendkey: ''
property string walletOptionsBackup: ''
property int walletOptionsRestoreHeight: 0
- property string walletOptionsBootstrapAddress: persistentSettings.bootstrapNodeAddress
property bool walletOptionsRestoringFromDevice: false
property bool walletOptionsIsRecovering: false
property bool walletOptionsIsRecoveringFromDevice: false
@@ -149,7 +148,6 @@ Rectangle {
property WizardOpenWallet1 wizardOpenWallet1View: WizardOpenWallet1 { }
property WizardModeSelection wizardModeSelectionView: WizardModeSelection { }
property WizardModeRemoteNodeWarning wizardModeRemoteNodeWarningView: WizardModeRemoteNodeWarning { }
- property WizardModeBootstrap wizardModeBootstrapView: WizardModeBootstrap {}
anchors.fill: parent
color: "transparent"
@@ -246,10 +244,6 @@ Rectangle {
name: "wizardModeRemoteNodeWarning"
PropertyChanges { target: wizardStateView; currentView: wizardStateView.wizardModeRemoteNodeWarningView }
PropertyChanges { target: wizardFlickable; contentHeight: wizardStateView.wizardModeRemoteNodeWarningView.pageHeight + 80 }
- }, State {
- name: "wizardModeBootstrap"
- PropertyChanges { target: wizardStateView; currentView: wizardStateView.wizardModeBootstrapView }
- PropertyChanges { target: wizardFlickable; contentHeight: wizardStateView.wizardModeBootstrapView.pageHeight + 80 }
}
]
### wizard/WizardCreateDevice1.qml
@@ -255,7 +255,7 @@ Rectangle {
}
WizardNav {
- progressSteps: appWindow.walletMode <= 1 ? 3 : 4
+ progressSteps: appWindow.walletMode === 0 ? 3 : 4
progress: 0
btnNext.enabled: walletInput.verify() && wizardCreateDevice1.deviceName;
btnPrev.text: qsTr("Back to menu") + translationManager.emptyString
### wizard/WizardCreateWallet1.qml
@@ -89,7 +89,7 @@ Rectangle {
WizardNav {
id: wizardNav
- progressSteps: appWindow.walletMode <= 1 ? 4 : 5
+ progressSteps: appWindow.walletMode === 0 ? 4 : 5
progress: 0
btnNext.enabled: walletInput.verify();
btnPrev.text: appWindow.width <= 506 ? "<" : qsTr("Back to menu") + translationManager.emptyString
### wizard/WizardCreateWallet2.qml
@@ -408,7 +408,7 @@ Rectangle {
WizardNav {
id: navigation
- progressSteps: appWindow.walletMode <= 1 ? 4 : 5
+ progressSteps: appWindow.walletMode === 0 ? 4 : 5
progress: 1
onPrevClicked: {
wizardStateView.state = "wizardCreateWallet1";
### wizard/WizardCreateWallet3.qml
@@ -64,7 +64,7 @@ Rectangle {
WizardNav {
id: wizardNav
- progressSteps: appWindow.walletMode <= 1 ? 4 : 5
+ progressSteps: appWindow.walletMode === 0 ? 4 : 5
progress: 2
btnNext.enabled: passwordFields.calcStrengthAndVerify();
onPrevClicked: {
@@ -78,7 +78,7 @@ Rectangle {
onNextClicked: {
wizardController.walletOptionsPassword = passwordFields.password;
- if (appWindow.walletMode < 2) {
+ if (appWindow.walletMode === 0) {
wizardStateView.state = "wizardCreateWallet5";
} else {
wizardStateView.state = "wizardCreateWallet4";
### wizard/WizardCreateWallet5.qml
@@ -68,11 +68,11 @@ Rectangle {
id: wizardNav
Layout.topMargin: 24
btnNextText: qsTr("Create wallet") + translationManager.emptyString
- progressSteps: appWindow.walletMode <= 1 ? 4 : 5
- progress: appWindow.walletMode <= 1 ? 3 : 4
+ progressSteps: appWindow.walletMode === 0 ? 4 : 5
+ progress: appWindow.walletMode === 0 ? 3 : 4
onPrevClicked: {
- if (appWindow.walletMode <= 1){
+ if (appWindow.walletMode === 0){
wizardStateView.state = "wizardCreateWallet1";
} else {
wizardStateView.state = "wizardCreateWallet4";
### wizard/WizardModeBootstrap.qml
@@ -1,144 +0,0 @@
-// Copyright (c) 2014-2024, The Monero Project
-//
-// All rights reserved.
-//
-// Redistribution and use in source and binary forms, with or without modification, are
-// permitted provided that the following conditions are met:
-//
-// 1. Redistributions of source code must retain the above copyright notice, this list of
-// conditions and the following disclaimer.
-//
-// 2. Redistributions in binary form must reproduce the above copyright notice, this list
-// of conditions and the following disclaimer in the documentation and/or other
-// materials provided with the distribution.
-//
-// 3. Neither the name of the copyright holder nor the names of its contributors may be
-// used to endorse or promote products derived from this software without specific
-// prior written permission.
-//
-// THIS SOFTWARE IS PROVIDED BY THE COPYRIGHT HOLDERS AND CONTRIBUTORS "AS IS" AND ANY
-// EXPRESS OR IMPLIED WARRANTIES, INCLUDING, BUT NOT LIMITED TO, THE IMPLIED WARRANTIES OF
-// MERCHANTABILITY AND FITNESS FOR A PARTICULAR PURPOSE ARE DISCLAIMED. IN NO EVENT SHALL
-// THE COPYRIGHT HOLDER OR CONTRIBUTORS BE LIABLE FOR ANY DIRECT, INDIRECT, INCIDENTAL,
-// SPECIAL, EXEMPLARY, OR CONSEQUENTIAL DAMAGES (INCLUDING, BUT NOT LIMITED TO,
-// PROCUREMENT OF SUBSTITUTE GOODS OR SERVICES; LOSS OF USE, DATA, OR PROFITS; OR BUSINESS
-// INTERRUPTION) HOWEVER CAUSED AND ON ANY THEORY OF LIABILITY, WHETHER IN CONTRACT,
-// STRICT LIABILITY, OR TORT (INCLUDING NEGLIGENCE OR OTHERWISE) ARISING IN ANY WAY OUT OF
-// THE USE OF THIS SOFTWARE, EVEN IF ADVISED OF THE POSSIBILITY OF SUCH DAMAGE.
-
-import QtQuick
-import QtQuick.Layouts
-import QtQuick.Controls
-
-import "../js/Wizard.js" as Wizard
-import "../components" as MoneroComponents
-
-Rectangle {
- id: wizardModeBootstrapWarning
-
- color: "transparent"
- property alias pageHeight: pageRoot.height
- property string viewName: "wizardModeBootstrap"
- property bool understood: false
-
- ColumnLayout {
- id: pageRoot
- Layout.alignment: Qt.AlignHCenter;
- width: parent.width - 100
- Layout.fillWidth: true
- anchors.horizontalCenter: parent.horizontalCenter;
-
- spacing: 10
-
- ColumnLayout {
- Layout.fillWidth: true
- Layout.maximumWidth: wizardController.wizardSubViewWidth
- Layout.topMargin: wizardController.wizardSubViewTopMargin
- Layout.alignment: Qt.AlignHCenter
- spacing: 0
-
- WizardHeader {
- title: qsTr("About the bootstrap mode") + translationManager.emptyString
- subtitle: ""
- }
-
- ColumnLayout {
- spacing: 20
-
- Layout.topMargin: 10
- Layout.fillWidth: true
-
- MoneroComponents.TextPlain {
- text: qsTr("This mode will use a remote node whilst also syncing the blockchain. This is different from the first menu option (Simple mode), since it will only use the remote node until the blockchain is fully synced locally. It is a reasonable tradeoff for most people who care about privacy but also want the convenience of an automatic fallback option.") + translationManager.emptyString
- wrapMode: Text.Wrap
- Layout.topMargin: 14
- Layout.fillWidth: true
- textFormat: Text.RichText
-
- font.family: MoneroComponents.Style.fontRegular.name
- font.pixelSize: 16
- color: MoneroComponents.Style.lightGreyFontColor
- }
-
- MoneroComponents.TextPlain {
- text: qsTr("Temporary use of remote nodes is useful in order to use Monero immediately (hence the name bootstrap), however be aware that when using remote nodes (including with the bootstrap setting), nodes could track your IP address, track your \"restore height\" and associated block request data, and send you inaccurate information to learn more about transactions you make.") + translationManager.emptyString
- wrapMode: Text.Wrap
- Layout.topMargin: 8
- Layout.fillWidth: true
-
- font.family: MoneroComponents.Style.fontRegular.name
- font.pixelSize: 16
- color: MoneroComponents.Style.lightGreyFontColor
- }
-
- MoneroComponents.WarningBox{
- Layout.topMargin: 14
- Layout.bottomMargin: 6
- text: qsTr("Remain aware of these limitations. <b>Users who prioritize privacy and decentralization must use a full node instead</b>.") + translationManager.emptyString
- }
-
- MoneroComponents.CheckBox {
- id: understoodCheckbox
- Layout.topMargin: 20
- fontSize: 16
- text: qsTr("I understand the privacy implications of using a third-party server.") + translationManager.emptyString
- onClicked: {
- wizardModeBootstrapWarning.understood = !wizardModeBootstrapWarning.understood
- }
- }
-
- WizardNav {
- Layout.topMargin: 4
- btnNext.enabled: wizardModeBootstrapWarning.understood
- progressSteps: 0
-
- onPrevClicked: {
- wizardController.wizardState = 'wizardModeSelection';
- }
-
- onNextClicked: {
- appWindow.changeWalletMode(1);
- wizardController.wizardState = 'wizardHome';
- }
- }
- }
- }
- }
-
- ListModel {
- id: regionModel
- ListElement {column1: "Unspecified"; region: ""}
- ListElement {column1: "Africa"; region: "af"}
- ListElement {column1: "Asia"; region: "as"}
- ListElement {column1: "Central America"; region: "ca";}
- ListElement {column1: "North America"; region: "na";}
- ListElement {column1: "Europe"; region: "eu";}
- ListElement {column1: "Oceania"; region: "oc";}
- ListElement {column1: "South America"; region: "sa";}
- }
-
- function onPageCompleted(previousView){
- wizardModeBootstrapWarning.understood = false;
- understoodCheckbox.checked = false;
- }
-}
### wizard/WizardModeSelection.qml
@@ -79,6 +79,7 @@ Rectangle {
}
WizardMenuItem {
+ enabled: simpleModeAvailable
opacity: simpleModeAvailable ? 1.0 : 0.5
Layout.topMargin: 20
headerText: qsTr("Simple mode") + translationManager.emptyString
@@ -112,39 +113,6 @@ Rectangle {
opacity: MoneroComponents.Style.dividerOpacity
}
- WizardMenuItem {
- opacity: simpleModeAvailable ? 1.0 : 0.5
- headerText: qsTr("Simple mode") + " (bootstrap)" + translationManager.emptyString
- bodyText: {
- if (isTails) {
- return qsTr("Not available on Tails.") + translationManager.emptyString;
- } else {
- if (appWindow.persistentSettings.nettype == 0) {
- return qsTr("Easy access to sending, receiving and basic functionality. The blockchain is downloaded to your computer.") + translationManager.emptyString;
- } else {
- return qsTr("Available on mainnet.") + translationManager.emptyString;
- }
- }
- }
- imageIcon: "qrc:///images/local-node.png"
-
- onMenuClicked: {
- if (simpleModeAvailable) {
- appWindow.persistentSettings.pruneBlockchain = true;
- applyWalletMode(1, 'wizardModeBootstrap');
- }
- }
- }
-
- Rectangle {
- Layout.preferredHeight: 1
- Layout.topMargin: 5
- Layout.bottomMargin: 10
- Layout.fillWidth: true
- color: MoneroComponents.Style.dividerColor
- opacity: MoneroComponents.Style.dividerOpacity
- }
-
WizardMenuItem {
id: advancedModeButton
headerText: qsTr("Advanced mode") + translationManager.emptyString
### wizard/WizardRestoreWallet1.qml
@@ -313,7 +313,7 @@ Rectangle {
WizardNav {
id: nav
- progressSteps: appWindow.walletMode <= 1 ? 3 : 4
+ progressSteps: appWindow.walletMode === 0 ? 3 : 4
progress: 0
btnNext.enabled: wizardRestoreWallet1.verify();
btnPrev.text: qsTr("Back to menu") + translationManager.emptyString
### wizard/WizardRestoreWallet2.qml
@@ -68,7 +68,7 @@ Rectangle {
WizardNav {
id: wizardNav
- progressSteps: appWindow.walletMode <= 1 ? 3 : 4
+ progressSteps: appWindow.walletMode === 0 ? 3 : 4
progress: 1
btnNext.enabled: passwordFields.calcStrengthAndVerify();
onPrevClicked: {
@@ -77,7 +77,7 @@ Rectangle {
onNextClicked: {
wizardController.walletOptionsPassword = passwordFields.password;
- if(appWindow.walletMode === 0 || appWindow.walletMode === 1){
+ if(appWindow.walletMode === 0){
wizardStateView.state = "wizardRestoreWallet4";
} else {
wizardStateView.state = "wizardRestoreWallet3";
### wizard/WizardRestoreWallet4.qml
@@ -68,12 +68,12 @@ Rectangle {
id: wizardNav
Layout.topMargin: 24
btnNextText: qsTr("Create wallet") + translationManager.emptyString
- progressSteps: appWindow.walletMode <= 1 ? 3 : 4
- progress: appWindow.walletMode <= 1 ? 2 : 3
+ progressSteps: appWindow.walletMode === 0 ? 3 : 4
+ progress: appWindow.walletMode === 0 ? 2 : 3
onPrevClicked: {
btnNext.enabled = true;
- if (appWindow.walletMode <= 1){
+ if (appWindow.walletMode === 0){
wizardStateView.state = "wizardRestoreWallet1";
} else {
wizardStateView.state = "wizardRestoreWallet3";Why this scored 40/100
Community notes
Notes can correct, qualify, or add evidence to the AI analysis. Every note shown here has been validated by a human moderator.
The AI analysis stands alone for now. Submit a note if you can add evidence or important context.