What the developer wrote
Authored by selsta
cmake: drop unnecessary package
What changed, and why it matters
This commit simply removes an unused Qt XML Patterns dependency from the build configuration. There is no indication of a security issue, vulnerability, or behavior change in the application itself.
No security action needed. Treat as routine build cleanup.
Security signals we found
No strong security signals were identified.
Evidence from the diff
The patch deletes a conditional find_package(Qt5XmlPatterns) block from CMakeLists.txt. The commit message states it is an unnecessary package, and the TODO comment indicates it was kept for compatibility with older Qt versions. No code paths, parsing logic, or runtime behavior are modified.
Changed components
CMakeLists.txt build configurationInspect captured patch +0 / −6
diff --git a/CMakeLists.txt b/CMakeLists.txt
index cf0a7e5..344a9ee 100644
--- a/CMakeLists.txt
+++ b/CMakeLists.txt
@@ -158,12 +158,6 @@ if(Qt5QmlModels_PKG_CONFIG_FOUND)
list(APPEND QT5_LIBRARIES Qt5QmlModels)
endif()
-# TODO: drop this once we switch to Qt 5.12+
-find_package(Qt5XmlPatterns QUIET)
-if(Qt5XmlPatterns_FOUND)
- list(APPEND QT5_LIBRARIES Qt5XmlPatterns)
-endif()
-
foreach(QT5_MODULE ${QT5_LIBRARIES})
find_package(${QT5_MODULE} REQUIRED)
include_directories(${${QT5_MODULE}_INCLUDE_DIRS})
Why this scored 15/100
Community notes
Notes can correct, qualify, or add evidence to the AI analysis. Every note shown here has been validated by a human moderator.
The AI analysis stands alone for now. Submit a note if you can add evidence or important context.