AI-generated analysisPublished automatically and not human-verified. Validated context appears in community notes below.
← Watch feed
Low 48 Bitcoin

walletrpc: reject retired lease requests

Public commit record

What the developer wrote

Authored by yyforyongyu

68/100 · Adequate
walletrpc: reject retired lease requests

Reject retired confirmation-count protobuf fields before lease
acquisition or PSBT funding so older clients cannot silently create
timed leases. Use preserved unknown fields and the existing protobuf
wire parser to keep the retired fields out of the public request schema.

Cover both public handlers with decoded old requests and stable error
identity assertions. Keep the existing wallet lifetime implementation.
✓ Descriptive subject✓ Names a concrete action or component✓ Provides detailed explanatory context
The short version

What changed, and why it matters

This change is a hardening patch, not an active exploit fix. LND removed two protobuf fields that let callers request timed output leases. Older clients still send those field numbers over the wire as 'unknown' protobuf data, so the server would silently ignore them and create a different kind of lease than the client expected. The patch now detects those retired field numbers in LeaseOutput and FundPsbt and returns an explicit error instead of silently falling through. The main risk is operational: an old client or script that relied on the removed fields will now fail fast rather than silently changing behavior.

Recommended action

Treat as a defensive hardening commit. Review release notes for any client compatibility guidance, ensure callers using LeaseOutput or FundPsbt have migrated to no_expiry / input_lease_no_expiry, and consider whether any integrations depend on the retired fields. No emergency deployment is indicated by the diff alone.

Security signals we found

01

Behavioral change from silent ignore to explicit error for deprecated protobuf fields

02

Prevention of unintended lease semantics when old clients send removed parameters

03

Uses protobuf unknown-field parsing to avoid re-adding retired fields to the public schema

04

Adds unit tests covering both affected handlers with stable error identity

Risk score

Why this scored 48/100

Our methodology →
Potential impact 12/30
Exploitability 8/25
Stealth signal 6/15
Affected reach 10/15
Confidence 8/10
Evidence quality 4/5
Human-validated context

Community notes

Notes can correct, qualify, or add evidence to the AI analysis. Every note shown here has been validated by a human moderator.

No validated notes yet.

The AI analysis stands alone for now. Submit a note if you can add evidence or important context.