What the developer wrote
Authored by ziggie
htlcswitch: use channel state open channel
Update htlcswitch test utilities to construct and pass
chanstate.OpenChannel values directly.
This removes another test-only dependency on the channeldb OpenChannel
alias while leaving the test database helpers unchanged.
What changed, and why it matters
This commit only changes test helper code in LND. It swaps one internal type name (channeldb.OpenChannel) for another (chanstate.OpenChannel) inside test utilities. There is no change to production code, no user-facing behavior change, and no security fix.
No action required. This is a routine refactoring of test-only code.
Security signals we found
No strong security signals were identified.
Evidence from the diff
The diff modifies htlcswitch/test_utils.go to construct and pass chanstate.OpenChannel values instead of channeldb.OpenChannel values in test helpers. channeldb.OpenChannel appears to have been an alias to chanstate.OpenChannel, so this is a test-only dependency cleanup. No runtime logic, validation, cryptography, or network handling is altered.
Changed components
htlcswitch/test_utils.goInspect captured patch +6 / −5
diff --git a/htlcswitch/test_utils.go b/htlcswitch/test_utils.go
index f0ebb5c..32d651f 100644
--- a/htlcswitch/test_utils.go
+++ b/htlcswitch/test_utils.go
@@ -24,6 +24,7 @@ import (
"github.com/btcsuite/btcd/wire/v2"
sphinx "github.com/lightningnetwork/lightning-onion"
"github.com/lightningnetwork/lnd/channeldb"
+ "github.com/lightningnetwork/lnd/chanstate"
"github.com/lightningnetwork/lnd/contractcourt"
"github.com/lightningnetwork/lnd/graph/db/models"
"github.com/lightningnetwork/lnd/htlcswitch/hop"
@@ -305,7 +306,7 @@ func createTestChannel(t *testing.T, alicePrivKey, bobPrivKey []byte,
CommitSig: bytes.Repeat([]byte{1}, 71),
}
- aliceChannelState := &channeldb.OpenChannel{
+ aliceChannelState := &chanstate.OpenChannel{
LocalChanCfg: aliceCfg,
RemoteChanCfg: bobCfg,
IdentityPub: aliceKeyPub,
@@ -323,7 +324,7 @@ func createTestChannel(t *testing.T, alicePrivKey, bobPrivKey []byte,
FundingTxn: channels.TestFundingTx,
}
- bobChannelState := &channeldb.OpenChannel{
+ bobChannelState := &chanstate.OpenChannel{
LocalChanCfg: bobCfg,
RemoteChanCfg: aliceCfg,
IdentityPub: bobKeyPub,
@@ -415,7 +416,7 @@ func createTestChannel(t *testing.T, alicePrivKey, bobPrivKey []byte,
"channel: %w", err)
}
- var aliceStoredChannel *channeldb.OpenChannel
+ var aliceStoredChannel *chanstate.OpenChannel
for _, channel := range aliceStoredChannels {
if channel.FundingOutpoint.String() == prevOut.String() {
aliceStoredChannel = channel
@@ -463,7 +464,7 @@ func createTestChannel(t *testing.T, alicePrivKey, bobPrivKey []byte,
"%w", err)
}
- var bobStoredChannel *channeldb.OpenChannel
+ var bobStoredChannel *chanstate.OpenChannel
for _, channel := range bobStoredChannels {
if channel.FundingOutpoint.String() == prevOut.String() {
bobStoredChannel = channel
@@ -1187,7 +1188,7 @@ func (h *hopNetwork) createChannelLink(server, peer *mockServer,
NotifyActiveChannel: func(wire.OutPoint) {},
NotifyInactiveChannel: func(wire.OutPoint) {},
NotifyInactiveLinkEvent: func(wire.OutPoint) {},
- NotifyChannelUpdate: func(*channeldb.OpenChannel) {},
+ NotifyChannelUpdate: func(*chanstate.OpenChannel) {},
HtlcNotifier: server.htlcSwitch.cfg.HtlcNotifier,
GetAliases: getAliases,
ShouldFwdExpAccountability: func() bool { return true },
Why this scored 15/100
Community notes
Notes can correct, qualify, or add evidence to the AI analysis. Every note shown here has been validated by a human moderator.
The AI analysis stands alone for now. Submit a note if you can add evidence or important context.