lnwallet/chancloser: use wait.DefaultTimeout for state transitions
What the developer wrote
Authored by Elle Mouton
lnwallet/chancloser: use wait.DefaultTimeout for state transitions
The hardcoded defaultTimeout (previously 500ms, then 5s) used in
assertStateTransitions was too tight for CI runners, especially
under coverage instrumentation or remote DB backends (postgres).
Use wait.DefaultTimeout which automatically adapts to the build
environment: 30s on standard platforms, 60s+ for remote DB builds,
and 60s on Windows.
What changed, and why it matters
This commit changes a single test file to use a more flexible timeout value instead of a hardcoded 500 milliseconds. It only affects automated tests, not the actual production code that runs on users' Lightning nodes. There is no security issue here.
No security action needed. This is a routine test-flakiness fix.
Security signals we found
No strong security signals were identified.
Evidence from the diff
In lnwallet/chancloser/rbf_coop_test.go, the test-local defaultTimeout constant is changed from 500ms to wait.DefaultTimeout. The commit message explains this is to reduce flaky test failures on CI runners, especially under coverage instrumentation or remote PostgreSQL backends. This is a test-only reliability fix with no changes to runtime behavior, consensus logic, or network handling.
Changed components
lnwallet/chancloser/rbf_coop_test.goInspect captured patch +1 / −1
diff --git a/lnwallet/chancloser/rbf_coop_test.go b/lnwallet/chancloser/rbf_coop_test.go
index 848d334..5338818 100644
--- a/lnwallet/chancloser/rbf_coop_test.go
+++ b/lnwallet/chancloser/rbf_coop_test.go
@@ -64,7 +64,7 @@ var (
closeTx = wire.NewMsgTx(2)
- defaultTimeout = 500 * time.Millisecond
+ defaultTimeout = wait.DefaultTimeout
)
func sigMustParse(sigBytes []byte) ecdsa.Signature {
Why this scored 15/100
Community notes
Notes can correct, qualify, or add evidence to the AI analysis. Every note shown here has been validated by a human moderator.
The AI analysis stands alone for now. Submit a note if you can add evidence or important context.