lntest: pin pre-v30 mempool policy defaults in itest bitcoind
What the developer wrote
Authored by ziggie
lntest: pin pre-v30 mempool policy defaults in itest bitcoind
Bitcoind v30 lowered the default minrelaytxfee and incrementalrelayfee
from 1000 sat/kvB (1 sat/vB) to 100 sat/kvB. The itest suite was
written against the old defaults and the lower values cascade into:
- integer sat/vByte assertions losing precision below 1 sat/vB, and
- RBF bump thresholds that alter sweeper/bumpfee replacement timing.
Pin the old defaults in the itest bitcoind backend so the existing
tests keep passing without per-test adaptation. Running against the
new defaults is still worth doing, but that is a separate exercise
that should not be bundled with the v30 version bump.
What changed, and why it matters
This change only adjusts the settings used for internal testing of LND with a Bitcoin Core backend. It pins older Bitcoin Core fee defaults so that existing automated tests continue to produce the same results after Bitcoin Core v30 changed its defaults. It does not change production LND code, user-facing behavior, or network consensus rules, and it does not fix a security vulnerability.
No security action required. Treat as a normal test-maintenance commit. If desired, separately track updating the integration tests to exercise Bitcoin Core v30's new default mempool policy values.
Security signals we found
No strong security signals were identified.
Evidence from the diff
The commit modifies lntest/bitcoind_common.go, which is part of the integration test harness, to pass -minrelaytxfee=0.00001 and -incrementalrelayfee=0.00001 when launching bitcoind for tests. Bitcoin Core v30 lowered these defaults from 1000 sat/kvB to 100 sat/kvB; the test suite was written against the old defaults and its integer sat/vByte assertions and RBF bump timing expectations fail or behave differently under the new defaults. This is a test-configuration pinning change, not a runtime fix.
Changed components
lntest/bitcoind_common.gointegration test harness bitcoind backend configurationInspect captured patch +8 / −0
diff --git a/lntest/bitcoind_common.go b/lntest/bitcoind_common.go
index 5f776de..04f5133 100644
--- a/lntest/bitcoind_common.go
+++ b/lntest/bitcoind_common.go
@@ -181,6 +181,14 @@ func newBackend(miner string, netParams *chaincfg.Params, extraArgs []string,
//
// TODO: Remove once btcd supports v2 P2P transport.
"-v2transport=0",
+ // Pin the pre-v30 mempool policy defaults (1 sat/vB)
+ // so the itest suite keeps exercising the fee math it
+ // was written against. v30 lowered minrelaytxfee and
+ // incrementalrelayfee to 100 sat/kvB, which breaks
+ // integer sat/vByte assertions and alters RBF bump
+ // thresholds across the sweeper/bumpfee tests.
+ "-minrelaytxfee=0.00001",
+ "-incrementalrelayfee=0.00001",
}
cmdArgs = append(cmdArgs, extraArgs...)
bitcoind := exec.Command("bitcoind", cmdArgs...)
Why this scored 14/100
Community notes
Notes can correct, qualify, or add evidence to the AI analysis. Every note shown here has been validated by a human moderator.
The AI analysis stands alone for now. Submit a note if you can add evidence or important context.