AI-generated analysisPublished automatically and not human-verified. Validated context appears in community notes below.
← Watch feed
Low 48 Bitcoin

Merge pull request #11357 from Roasbeef/zpay32-bolt11-vectors

Public commit record

What the developer wrote

Authored by Olaoluwa Osuntokun

73/100 · Adequate
Merge pull request #11357 from Roasbeef/zpay32-bolt11-vectors

zpay32: enforce BOLT 11 fixed lengths, single s, low-S with n
✓ Specific, descriptive subject✓ Names a concrete action or component✓ Provides an explanatory body✓ Links an issue, advisory, or supporting reference
The short version

What changed, and why it matters

This change tightens how LND reads BOLT 11 Lightning invoices. It now rejects invoices that violate the spec: fixed-length fields with wrong lengths, duplicate payment-address fields, and high-S signatures when the invoice explicitly names the payee. Previously these malformed invoices were accepted or silently skipped. The patch is defensive and brings LND into line with the BOLT 11 specification and its official test vectors.

Recommended action

Treat as a hardening/spec-compliance patch. Review whether any production or partner systems previously relied on LND accepting the now-rejected malformed invoices, and update integration tests that may have depended on the old lenient behavior. No emergency response is indicated by the commit materials alone.

Security signals we found

01

Rejects malformed BOLT 11 invoices that were previously accepted

02

Adds low-S signature enforcement for invoices with explicit destination pubkey

03

Adds duplicate payment-address (s) field rejection

04

Adds fixed-length field validation for p/h/s/n

05

Adds BOLT 11 official test vectors to the test suite

06

Release note describes change as spec compliance, not a security fix

Risk score

Why this scored 48/100

Our methodology →
Potential impact 12/30
Exploitability 8/25
Stealth signal 6/15
Affected reach 10/15
Confidence 8/10
Evidence quality 4/5
Human-validated context

Community notes

Notes can correct, qualify, or add evidence to the AI analysis. Every note shown here has been validated by a human moderator.

No validated notes yet.

The AI analysis stands alone for now. Submit a note if you can add evidence or important context.