What the developer wrote
Authored by Viktor Torstensson
sqldb/v2: rename the `postgresErrMsgs` list
Rename the `postgresErrMsgs` list to `postgresRetriableErrMsgs`, in
order to clarify its usage.
What changed, and why it matters
This commit is a simple rename of an internal variable and its comment from `postgresErrMsgs` to `postgresRetriableErrMsgs`. No code behavior changes; it only improves readability. There is no security relevance.
No action needed; this is a benign refactor with no security implications.
Security signals we found
No strong security signals were identified.
Evidence from the diff
The diff renames a package-level string slice variable and updates the loop variable name accordingly. The list of error message substrings, the logic in MapSQLError, and all functional behavior remain identical. It is a non-functional refactor.
Changed components
sqldb/v2/sqlerrors.goInspect captured patch +4 / −4
diff --git a/sqldb/v2/sqlerrors.go b/sqldb/v2/sqlerrors.go
index 5e9fd32..4c5ac7d 100644
--- a/sqldb/v2/sqlerrors.go
+++ b/sqldb/v2/sqlerrors.go
@@ -18,9 +18,9 @@ var (
// than the max allowed valued without a success.
ErrTxRetriesExceeded = errors.New("db tx retries exceeded")
- // postgresErrMsgs are strings that signify retriable errors resulting
- // from serialization failures.
- postgresErrMsgs = []string{
+ // postgresRetriableErrMsgs are strings that signify retriable errors
+ // resulting from serialization failures.
+ postgresRetriableErrMsgs = []string{
"could not serialize access",
"current transaction is aborted",
"not enough elements in RWConflictPool",
@@ -51,7 +51,7 @@ func MapSQLError(err error) error {
// Sometimes the error won't be properly wrapped, so we'll need to
// inspect raw error itself to detect something we can wrap properly.
// This handles a postgres variant of the error.
- for _, postgresErrMsg := range postgresErrMsgs {
+ for _, postgresErrMsg := range postgresRetriableErrMsgs {
if strings.Contains(err.Error(), postgresErrMsg) {
return &ErrSerializationError{
DBError: err,
Why this scored 15/100
Community notes
Notes can correct, qualify, or add evidence to the AI analysis. Every note shown here has been validated by a human moderator.
The AI analysis stands alone for now. Submit a note if you can add evidence or important context.