AI-generated analysisPublished automatically and not human-verified. Validated context appears in community notes below.
← Watch feed
Low 27 Bitcoin

lnwire+netann: update ChannelAnnouncement2 structure

Public commit record

What the developer wrote

Authored by Elle Mouton

70/100 · Adequate
lnwire+netann: update ChannelAnnouncement2 structure

Such that all fields are now TLV (including the signature).
✓ Specific, descriptive subject✓ Names a concrete action or component✓ Provides an explanatory body✓ Names security-relevant behavior explicitly
The short version

What changed, and why it matters

This commit refactors how a new Lightning network message type (ChannelAnnouncement2) is encoded and decoded. Previously the message had a fixed signature field followed by a block of TLV data. Now the signature itself is placed inside the TLV stream, and the code distinguishes between fields that are covered by the signature and those that are not. The change is a protocol-structure update rather than a clear-cut bug fix, but it touches signature coverage and message parsing, which are security-sensitive areas.

Recommended action

Treat this as a protocol-compatibility and signature-correctness change. Review the corresponding BOLT/spec update to confirm the signed TLV ranges and default chain-hash behavior match the intended design. Run the new round-trip and signature-validation tests, and verify that any node receiving the old wire format handles it gracefully (or that the protocol version gates the change).

Security signals we found

01

Signature coverage boundary changed: signature now a TLV record in the signed range

02

Unknown TLV records in the signed range are retained for signature validation

03

New EncodeAllNonSigFields / DecodeNonSigTLVRecords helpers affect what bytes are hashed for signing

04

ChainHash defaulting to Bitcoin mainnet genesis hash when omitted could alter signed payload if logic is inconsistent

05

No explicit security bug or CVE mentioned in commit message

Risk score

Why this scored 27/100

Our methodology →
Potential impact 5/30
Exploitability 5/25
Stealth signal 5/15
Affected reach 5/15
Confidence 4/10
Evidence quality 3/5
Human-validated context

Community notes

Notes can correct, qualify, or add evidence to the AI analysis. Every note shown here has been validated by a human moderator.

No validated notes yet.

The AI analysis stands alone for now. Submit a note if you can add evidence or important context.