ci: Drop workaround for Valgrind older than 3.20.0
What the developer wrote
Authored by Hennadii Stepanov
ci: Drop workaround for Valgrind older than 3.20.0
What changed, and why it matters
This commit simply removes a workaround in the continuous integration (CI) script that added a compiler flag for older versions of Valgrind. It does not change any cryptographic code, wallet logic, or network behavior, and has no direct security impact on the library itself.
No security action required; treat as routine CI maintenance.
Security signals we found
No strong security signals were identified.
Evidence from the diff
The patch deletes a shell case statement in ci/ci.sh that appended -gdwarf-4 to CFLAGS when using Clang with Valgrind, working around a Valgrind bug fixed in 3.20.0. The change is purely a CI/maintenance cleanup and does not touch secp256k1 source code, build system defaults, or runtime behavior.
Changed components
ci/ci.shInspect captured patch +0 / −16
diff --git a/ci/ci.sh b/ci/ci.sh
index 08e84ef..515c14c 100755
--- a/ci/ci.sh
+++ b/ci/ci.sh
@@ -52,22 +52,6 @@ if [ -n "$WRAPPER_CMD" ]; then
$WRAPPER_CMD --version
fi
-# Workaround for https://bugs.kde.org/show_bug.cgi?id=452758 (fixed in valgrind 3.20.0).
-case "${CC:-undefined}" in
- clang*)
- if [ "$CTIMETESTS" = "yes" ] && [ "$WITH_VALGRIND" = "yes" ]
- then
- export CFLAGS="${CFLAGS:+$CFLAGS }-gdwarf-4"
- else
- case "$WRAPPER_CMD" in
- valgrind*)
- export CFLAGS="${CFLAGS:+$CFLAGS }-gdwarf-4"
- ;;
- esac
- fi
- ;;
-esac
-
./autogen.sh
./configure \
Why this scored 15/100
Community notes
Notes can correct, qualify, or add evidence to the AI analysis. Every note shown here has been validated by a human moderator.
The AI analysis stands alone for now. Submit a note if you can add evidence or important context.