What the developer wrote
Authored by copilot-swe-agent[bot]
hash: Include secp256k1.h directly
Move the #include "../include/secp256k1.h" from src/util.h to
src/hash.h, which is the file that actually depends on the
secp256k1_sha256_compression_function type defined there.
Co-authored-by: Tim Ruffing <me@real-or-random.org>
What changed, and why it matters
This commit is a simple code cleanup: it moves an #include directive from one internal file to another so that each file only imports what it actually uses. There is no functional change, no bug fix, and no security relevance.
No action needed; this is a non-security refactoring commit.
Security signals we found
No strong security signals were identified.
Evidence from the diff
The change relocates ‘#include “../include/secp256k1.h”’ from src/util.h to src/hash.h, because hash.h is the file that depends on the secp256k1_sha256_compression_function type. This is a dependency-hygiene refactor with no behavioral or security impact.
Changed components
src/hash.hsrc/util.hInspect captured patch +2 / −1
diff --git a/src/hash.h b/src/hash.h
index 79d9767..348e05e 100644
--- a/src/hash.h
+++ b/src/hash.h
@@ -10,6 +10,8 @@
#include <stdlib.h>
#include <stdint.h>
+#include "../include/secp256k1.h"
+
typedef struct {
secp256k1_sha256_compression_function fn_sha256_compression;
} secp256k1_hash_ctx;
diff --git a/src/util.h b/src/util.h
index 163f932..13e26e0 100644
--- a/src/util.h
+++ b/src/util.h
@@ -7,7 +7,6 @@
#ifndef SECP256K1_UTIL_H
#define SECP256K1_UTIL_H
-#include "../include/secp256k1.h"
#include "checkmem.h"
#include <string.h>
Why this scored 15/100
Community notes
Notes can correct, qualify, or add evidence to the AI analysis. Every note shown here has been validated by a human moderator.
The AI analysis stands alone for now. Submit a note if you can add evidence or important context.