check-abi: remove support for obsolete CMake library output location (src/libsecp256k1.so)
What the developer wrote
Authored by Sebastian Falbesoner
check-abi: remove support for obsolete CMake library output location (src/libsecp256k1.so)
The CMake library output location was changed from "src/" to "lib/"
in PR #1553, supporting the old location shouldn't be necessary anymore.
What changed, and why it matters
This change removes a fallback path in an internal ABI-checking shell script. It is a cleanup of build tooling with no effect on the cryptographic library or its security.
No security action needed; treat as routine build-tooling cleanup.
Security signals we found
No strong security signals were identified.
Evidence from the diff
The commit deletes a conditional in tools/check-abi.sh that chose between src/libsecp256k1.so and lib/libsecp256k1.so, hardcoding the new lib/ location. This is a build-maintenance cleanup following a prior CMake output relocation. It does not alter compiled code, public API, or any runtime behavior of libsecp256k1.
Changed components
tools/check-abi.shInspect captured patch +1 / −8
diff --git a/tools/check-abi.sh b/tools/check-abi.sh
index 601a64b..a3ca67a 100755
--- a/tools/check-abi.sh
+++ b/tools/check-abi.sh
@@ -49,14 +49,7 @@ checkout_and_build() {
-DSECP256K1_BUILD_CTIME_TESTS=OFF \
-DSECP256K1_BUILD_EXAMPLES=OFF
cmake --build . -j "$(nproc)"
- # FIXME: Just set LIBPATH to lib/libsecp256k1.so once version 0.6.0 is
- # released.
- if [ -f "src/libsecp256k1.so" ]; then
- LIBPATH="src/libsecp256k1.so"
- else
- LIBPATH="lib/libsecp256k1.so"
- fi
- abi-dumper $LIBPATH -o ABI.dump -lver "$2" -public-headers ../include/
+ abi-dumper lib/libsecp256k1.so -o ABI.dump -lver "$2" -public-headers ../include/
cd "$_orig_dir"
}
Why this scored 15/100
Community notes
Notes can correct, qualify, or add evidence to the AI analysis. Every note shown here has been validated by a human moderator.
The AI analysis stands alone for now. Submit a note if you can add evidence or important context.