What changed, and why it matters
This commit only expands the project's automated testing on Windows by adding more clang-cl build configurations to GitHub Actions. It does not change any library code, cryptographic logic, or user-facing behavior. There is no security issue here.
No action needed. This is a benign CI-only change.
Security signals we found
No strong security signals were identified.
Evidence from the diff
The diff modifies .github/workflows/ci.yml to add four new clang-cl CI job variants (shared, static, int128_struct, and int128_struct with MSVC mulh override) and removes one older generic MSVC clang-cl job. It is purely a CI matrix expansion with no source code changes.
Changed components
.github/workflows/ci.ymlInspect captured patch +10 / −2
diff --git a/.github/workflows/ci.yml b/.github/workflows/ci.yml
index a3108d6..f6d3176 100644
--- a/.github/workflows/ci.yml
+++ b/.github/workflows/ci.yml
@@ -604,8 +604,16 @@ jobs:
cpp_flags: '/DSECP256K1_MSVC_MULH_TEST_OVERRIDE'
- job_name: 'x86 (MSVC): Windows (VS 2022)'
cmake_options: '-A Win32'
- - job_name: 'x64 (MSVC): Windows (clang-cl)'
- cmake_options: '-T ClangCL'
+ - job_name: 'x64 (clang-cl): Windows (VS 2022, shared)'
+ cmake_options: '-T ClangCL -DBUILD_SHARED_LIBS=ON'
+ symbol_check: 'true'
+ - job_name: 'x64 (clang-cl): Windows (VS 2022, static)'
+ cmake_options: '-T ClangCL -DBUILD_SHARED_LIBS=OFF'
+ - job_name: 'x64 (clang-cl): Windows (VS 2022, int128_struct)'
+ cmake_options: '-T ClangCL -DSECP256K1_TEST_OVERRIDE_WIDE_MULTIPLY=int128_struct'
+ - job_name: 'x64 (clang-cl): Windows (VS 2022, int128_struct with __(u)mulh)'
+ cmake_options: '-T ClangCL -DSECP256K1_TEST_OVERRIDE_WIDE_MULTIPLY=int128_struct'
+ cpp_flags: '/DSECP256K1_MSVC_MULH_TEST_OVERRIDE'
steps:
- name: Checkout
Why this scored 15/100
Community notes
Notes can correct, qualify, or add evidence to the AI analysis. Every note shown here has been validated by a human moderator.
The AI analysis stands alone for now. Submit a note if you can add evidence or important context.