What the developer wrote
Authored by Salvatore Ingala
Wrong function mentioned in comment
What changed, and why it matters
This commit only fixes a typo in a code comment. The comment previously referenced the wrong function name ('bip32_CKDpub' instead of 'crypto_tr_tweak_pubkey'). No actual code logic was changed, so there is no security impact.
No security action needed. This is a non-functional comment correction.
Security signals we found
No strong security signals were identified.
Evidence from the diff
The diff modifies a single comment in src/crypto.c. It changes the explanatory text from referencing ‘bip32_CKDpub’ to referencing ‘crypto_tr_tweak_pubkey’, which is the actual function being documented. The surrounding code, including the call to secp256k1_point_unsafe(), remains unchanged. This is a documentation-only correction.
Changed components
src/crypto.c (comment only)Inspect captured patch +2 / −2
diff --git a/src/crypto.c b/src/crypto.c
index 7754550..4f9946d 100644
--- a/src/crypto.c
+++ b/src/crypto.c
@@ -587,8 +587,8 @@ int crypto_tr_tweak_pubkey(const uint8_t pubkey[static 32],
return -1;
}
- // as the arguments of bip32_CKDpub are public keys, we do not need to use math functions
- // hardened against side channels attacks, which are slower
+ // as the arguments of crypto_tr_tweak_pubkey are public keys, we do not need to use math
+ // functions hardened against side channels attacks, which are slower
if (0 > secp256k1_point_unsafe(t, Q)) {
// point at infinity, or error
return -1;
Why this scored 15/100
Community notes
Notes can correct, qualify, or add evidence to the AI analysis. Every note shown here has been validated by a human moderator.
The AI analysis stands alone for now. Submit a note if you can add evidence or important context.