AI-generated analysisPublished automatically and not human-verified. Validated context appears in community notes below.
← Watch feed
Low 34 Bitcoin

sign_psbt: commit to the optional MUSIG2_SESSION_ID in psbt_session_id

Public commit record

What the developer wrote

Authored by Salvatore Ingala

73/100 · Adequate
sign_psbt: commit to the optional MUSIG2_SESSION_ID in psbt_session_id

This allows software wallets to manage several in flight MuSig2 rounds
for the same wallet policy by adding distinct MUSIG2_SESSION_IDs for
each of them; if used in Round 1, the same value must be used in
Round 2.

If the field is absent, psbt_session_id still only depends on the
wallet policy.

A present but empty or too long value is rejected with
EC_SIGN_PSBT_INVALID_MUSIG2_SESSION_ID. Accepted values are at least
1 and at most 32 bytes long.
✓ Specific, descriptive subject✓ Names a concrete action or component✓ Provides detailed explanatory context
The short version

What changed, and why it matters

This commit adds an optional 'session ID' field to MuSig2 multi-signature signing sessions in Ledger's Bitcoin app. Previously, the device could only track one unfinished signing session per wallet policy; starting a second one would overwrite the first. The change lets wallet software label each session with a unique ID so multiple signing rounds can run in parallel. It also rejects malformed IDs (empty or too long). This is a feature enhancement that reduces the chance of a wallet accidentally mixing up or losing in-flight signing sessions.

Recommended action

Review the new MUSIG2_SESSION_ID parsing for off-by-one and key-comparison issues; confirm that the proprietary key cannot be confused with other 0xFC keys; verify that hashing the user-controlled session ID into psbt_session_id does not introduce collision or malleability issues in the MuSig2 nonce/session state; and ensure documentation (doc/musig.md) is updated to describe the new field and its security assumptions.

Security signals we found

01

New PSBT global proprietary field parsing with explicit length bounds

02

Session identifier now commits to an externally-supplied value, expanding the collision domain

03

Malformed field values are rejected rather than ignored

04

Existing behavior preserved when the field is absent

05

Test coverage added for parallel sessions, session-id mismatch, and invalid lengths

Risk score

Why this scored 34/100

Our methodology →
Potential impact 8/30
Exploitability 5/25
Stealth signal 4/15
Affected reach 6/15
Confidence 7/10
Evidence quality 4/5
Human-validated context

Community notes

Notes can correct, qualify, or add evidence to the AI analysis. Every note shown here has been validated by a human moderator.

No validated notes yet.

The AI analysis stands alone for now. Submit a note if you can add evidence or important context.