What the developer wrote
Authored by Salvatore Ingala
Use 'getbalances' rpc to get balance
The 'balance' field from 'getwalletinfo' has been removed.
What changed, and why it matters
This commit only updates automated test scripts to use a different Bitcoin Core RPC command for checking wallet balances. It does not change the Ledger app code that users interact with, and it has no security relevance.
No security action needed. This is a routine test maintenance change.
Security signals we found
No strong security signals were identified.
Evidence from the diff
The commit replaces calls to Bitcoin Core’s deprecated/removed getwalletinfo()[‘balance’] with getbalances()[‘mine’][‘trusted’] in four end-to-end Python test files. This is a test-compatibility fix for a Bitcoin Core API change and does not modify any application firmware, protocol handling, cryptography, or user-facing behavior.
Changed components
tests/test_e2e_miniscript.pytests/test_e2e_multisig.pytests/test_e2e_musig2.pytests/test_e2e_tapscripts.pyInspect captured patch +4 / −4
diff --git a/tests/test_e2e_miniscript.py b/tests/test_e2e_miniscript.py
index aa5b348..bd53dc1 100644
--- a/tests/test_e2e_miniscript.py
+++ b/tests/test_e2e_miniscript.py
@@ -82,7 +82,7 @@ def run_test_e2e(navigator: Navigator, client: RaggerClient, wallet_policy: Wall
rpc_test_wallet.sendtoaddress(T(address_hww), "0.1")
generate_blocks(1)
- assert multisig_rpc.getwalletinfo()["balance"] == Decimal("0.1")
+ assert multisig_rpc.getbalances()["mine"]["trusted"] == Decimal("0.1")
# ==> prepare a psbt spending from the wallet
diff --git a/tests/test_e2e_multisig.py b/tests/test_e2e_multisig.py
index b9a09fe..6838a48 100644
--- a/tests/test_e2e_multisig.py
+++ b/tests/test_e2e_multisig.py
@@ -82,7 +82,7 @@ def run_test(navigator: Navigator, client: RaggerClient, wallet_policy: WalletPo
rpc_test_wallet.sendtoaddress(T(address_hww), "0.1")
generate_blocks(1)
- assert multisig_rpc.getwalletinfo()["balance"] == Decimal("0.1")
+ assert multisig_rpc.getbalances()["mine"]["trusted"] == Decimal("0.1")
# ==> prepare a psbt spending from the multisig wallet
diff --git a/tests/test_e2e_musig2.py b/tests/test_e2e_musig2.py
index 074f84c..44c2c7c 100644
--- a/tests/test_e2e_musig2.py
+++ b/tests/test_e2e_musig2.py
@@ -98,7 +98,7 @@ def run_test_e2e_musig2(navigator: Navigator, client: RaggerClient, wallet_polic
rpc_test_wallet.sendtoaddress(T(address_hww), "0.1")
generate_blocks(1)
- assert core_wallet_rpc.getwalletinfo()["balance"] == Decimal("0.1")
+ assert core_wallet_rpc.getbalances()["mine"]["trusted"] == Decimal("0.1")
# ==> prepare a psbt spending from the wallet
diff --git a/tests/test_e2e_tapscripts.py b/tests/test_e2e_tapscripts.py
index 23f27f1..0699d48 100644
--- a/tests/test_e2e_tapscripts.py
+++ b/tests/test_e2e_tapscripts.py
@@ -80,7 +80,7 @@ def run_test_e2e(navigator: Navigator, client: RaggerClient, wallet_policy: Wall
rpc_test_wallet.sendtoaddress(T(address_hww), "0.1")
generate_blocks(1)
- assert multisig_rpc.getwalletinfo()["balance"] == Decimal("0.1")
+ assert multisig_rpc.getbalances()["mine"]["trusted"] == Decimal("0.1")
# ==> prepare a psbt spending from the wallet
Why this scored 15/100
Community notes
Notes can correct, qualify, or add evidence to the AI analysis. Every note shown here has been validated by a human moderator.
The AI analysis stands alone for now. Submit a note if you can add evidence or important context.