What changed, and why it matters
This commit only changes user-facing text strings in the Ledger Bitcoin app. It capitalizes 'Bitcoin' as 'bitcoin' in a few labels and rewords some warning messages to be clearer. There are no code logic changes, no security fixes, and no behavior changes.
No security action needed. This is a routine UI text update.
Security signals we found
No strong security signals were identified.
Evidence from the diff
The diff modifies string literals in src/ui/display_nbgl.c for the NBGL (new user interface) display layer. Changes include: ‘Sign transaction to send Bitcoin?’ → ‘bitcoin’, ‘Review transaction to send Bitcoin’ → ‘bitcoin’, ‘Verify Bitcoin address’ → ‘bitcoin address’, and reworded risk/warning messages for external inputs, non-standard sighash, and high fees. No functional code, parsing, cryptography, or security logic is altered.
Changed components
src/ui/display_nbgl.cInspect captured patch +8 / −9
diff --git a/src/ui/display_nbgl.c b/src/ui/display_nbgl.c
index 00da4c1..f07db37 100644
--- a/src/ui/display_nbgl.c
+++ b/src/ui/display_nbgl.c
@@ -16,7 +16,7 @@ static const char *rejected_status; // text displayed in rejection page (after
/* Graphical resources (GA) used by the application and NBGL */
#ifdef SCREEN_SIZE_WALLET
-const char GA_SIGN_TRANSACTION[] = "Sign transaction\nto send Bitcoin?";
+const char GA_SIGN_TRANSACTION[] = "Sign transaction\nto send bitcoin?";
const char GA_SIGN_MESSAGE[] = "Sign message?";
const char GA_REGISTER_ACCOUNT[] = "Register account?";
#else
@@ -29,13 +29,12 @@ const char GA_REGISTER_ACCOUNT[] = "Register account";
const char GA_SECURITY_RISK_TITLE[] = "Security risk detected";
const char GA_WARN_HIGH_FEES_TITLE[] = "High fees warning";
const char GA_RISK_EXTERNAL_INPUTS[] =
- "This transaction has external inputs, and could spend more than you think.";
+ "This transaction has external inputs. You could spend more than expected.";
const char GA_RISK_NON_STD_SIGHASH[] =
- "This transaction uses non-standard signing rules (modified sighash), and could spend more "
- "than you think.";
+ "This transaction uses non-standard signing rules (modified sighash). You could spend more "
+ "than expected.";
const char GA_WARN_HIGH_FEES[] =
- "You're about to review a transaction with fees above 10\% of the total amount.";
-
+ "This transaction has fees higher than 10% of the amount you’re sending.";
#else
const char GA_SECURITY_RISK_TITLE[] = "Security risk";
const char GA_WARN_HIGH_FEES_TITLE[] = "High fees warning";
@@ -47,7 +46,7 @@ const char GA_WARN_HIGH_FEES[] = "Fees are above 10%\n of total amount";
const char GA_BACK_TO_SAFETY[] = "Back to safety";
const char GA_CONTINUE_ANYWAY[] = "Continue anyway";
const char GA_RISK_UNVERIFIED_INPUTS[] = "Unverified inputs\nUpdate your wallet software";
-const char GA_REVIEW_TRANSACTION[] = "Review transaction\nto send Bitcoin";
+const char GA_REVIEW_TRANSACTION[] = "Review transaction\nto send bitcoin";
const char GA_REVIEW_MESSAGE[] = "Review message";
const char GA_LOADING_TRANSACTION[] = "Loading transaction";
const char GA_SIGNING_TRANSACTION[] = "Signing transaction";
@@ -335,7 +334,7 @@ void ui_display_receive_in_wallet_flow(void) {
nbgl_useCaseAddressReview(g_ui_state.wallet.address,
&pairList,
&ICON_APP_ACTION,
- "Verify Bitcoin\naddress",
+ "Verify bitcoin\naddress",
NULL,
status_address_callback);
}
@@ -421,7 +420,7 @@ void ui_display_default_wallet_address_flow(void) {
nbgl_useCaseAddressReview(g_ui_state.wallet.address,
NULL,
&ICON_APP_ACTION,
- "Verify Bitcoin\naddress",
+ "Verify bitcoin\naddress",
NULL,
status_address_callback);
}
Why this scored 15/100
Community notes
Notes can correct, qualify, or add evidence to the AI analysis. Every note shown here has been validated by a human moderator.
The AI analysis stands alone for now. Submit a note if you can add evidence or important context.