What the developer wrote
Authored by Salvatore Ingala
Remove redundant boolean check
What changed, and why it matters
This commit is a code cleanup with no functional change. It removes an unnecessary comparison to 'true' in two boolean checks. The behavior of the program is identical before and after the change.
No action needed. This is a benign cleanup commit.
Security signals we found
No strong security signals were identified.
Evidence from the diff
The patch changes two instances of if (!fill_keyexpr_info_if_internal(...) == true) to if (!fill_keyexpr_info_if_internal(...)). Because ! already produces a boolean result (0 or 1), comparing it to true is redundant. The compiled behavior is the same, so this is a non-functional refactor.
Changed components
src/handler/sign_psbt.cInspect captured patch +2 / −2
diff --git a/src/handler/sign_psbt.c b/src/handler/sign_psbt.c
index 0957ec7..9956d53 100644
--- a/src/handler/sign_psbt.c
+++ b/src/handler/sign_psbt.c
@@ -1957,7 +1957,7 @@ static bool __attribute__((noinline)) produce_musig2_pubnonces(
continue;
}
- if (!fill_keyexpr_info_if_internal(dc, st, keyexpr_info) == true) {
+ if (!fill_keyexpr_info_if_internal(dc, st, keyexpr_info)) {
continue;
}
@@ -2036,7 +2036,7 @@ sign_transaction(dispatcher_context_t *dc,
continue;
}
- if (!fill_keyexpr_info_if_internal(dc, st, keyexpr_info) == true) {
+ if (!fill_keyexpr_info_if_internal(dc, st, keyexpr_info)) {
continue;
}
Why this scored 15/100
Community notes
Notes can correct, qualify, or add evidence to the AI analysis. Every note shown here has been validated by a human moderator.
The AI analysis stands alone for now. Submit a note if you can add evidence or important context.