What the developer wrote
Authored by soralit
fix: build
What changed, and why it matters
This is a one-line build fix in a hardware wallet firmware file. It adds two extra arguments (NULL and 0) to a function call so it matches the current definition of get_keystone_connect_wallet_ur. There is no visible security change in behavior.
No security action needed; treat as a normal build-compatibility fix. If desired, verify the new parameters are intentional in the function declaration and that NULL/0 defaults are safe for the Nabox wallet flow.
Security signals we found
No strong security signals were identified.
Evidence from the diff
The patch updates the call site of get_keystone_connect_wallet_ur in GuiGetNaboxData to pass two additional trailing parameters, NULL and 0. This is consistent with a signature change in the called function and is required for compilation. The diff shows no logic alteration beyond matching the new prototype.
Changed components
src/ui/gui_wallet/multi/web3/gui_wallet.cInspect captured patch +1 / −1
diff --git a/src/ui/gui_wallet/multi/web3/gui_wallet.c b/src/ui/gui_wallet/multi/web3/gui_wallet.c
index 0824682..f051de8 100644
--- a/src/ui/gui_wallet/multi/web3/gui_wallet.c
+++ b/src/ui/gui_wallet/multi/web3/gui_wallet.c
@@ -237,7 +237,7 @@ UREncodeResult *GuiGetNaboxData(void)
char firmwareVersion[12];
GetSoftWareVersionNumber(firmwareVersion);
PtrT_CSliceFFI_ExtendedPublicKey public_keys = BuildChainPaths(chainPaths, keys, chainNum);
- UREncodeResult *urEncode = get_keystone_connect_wallet_ur(mfp, sizeof(mfp), serialNumber, public_keys, "Keystone 3 Pro", firmwareVersion);
+ UREncodeResult *urEncode = get_keystone_connect_wallet_ur(mfp, sizeof(mfp), serialNumber, public_keys, "Keystone 3 Pro", firmwareVersion, NULL, 0);
for (int i = 9; i < chainNum; i++) {
if (chainPaths[i].path != NULL) {
SRAM_FREE(chainPaths[i].path);
Why this scored 11/100
Community notes
Notes can correct, qualify, or add evidence to the AI analysis. Every note shown here has been validated by a human moderator.
The AI analysis stands alone for now. Submit a note if you can add evidence or important context.