What the developer wrote
Authored by soralit
fix: ci build
What changed, and why it matters
This is a tiny code-movement patch that shifts a variable declaration earlier in a function so the code compiles under CI. It does not change what the program does, only where a local variable is declared. There is no security relevance visible in the commit.
No security action needed. Treat as a normal build-fix commit.
Security signals we found
No strong security signals were identified.
Evidence from the diff
The commit moves the declaration bool isSlip39 = GetMnemonicType() == MNEMONIC_TYPE_SLIP39; from inside a later case WALLET_LIST_KEYSTONE: block to the top of the GuiConnectWalletSetQrdata function. The variable is now in scope for all switch cases, but the diff shows no new uses of isSlip39 outside the original Keystone case. This is a compiler/scope fix for a CI build failure, not a functional or security change.
Changed components
src/ui/gui_widgets/multi/web3/gui_connect_wallet_widgets.cInspect captured patch +1 / −1
diff --git a/src/ui/gui_widgets/multi/web3/gui_connect_wallet_widgets.c b/src/ui/gui_widgets/multi/web3/gui_connect_wallet_widgets.c
index fd96d0d..3072bc5 100644
--- a/src/ui/gui_widgets/multi/web3/gui_connect_wallet_widgets.c
+++ b/src/ui/gui_widgets/multi/web3/gui_connect_wallet_widgets.c
@@ -1139,6 +1139,7 @@ void GuiConnectWalletSetQrdata(WALLET_LIST_INDEX_ENUM index)
lv_label_set_text(g_coinTitleLabel, _("connect_wallet_supported_networks"));
lv_obj_clear_flag(g_bottomCont, LV_OBJ_FLAG_CLICKABLE);
lv_obj_add_flag(g_manageImg, LV_OBJ_FLAG_HIDDEN);
+ bool isSlip39 = GetMnemonicType() == MNEMONIC_TYPE_SLIP39;
switch (index) {
case WALLET_LIST_METAMASK:
func = GuiGetMetamaskData;
@@ -1259,7 +1260,6 @@ void GuiConnectWalletSetQrdata(WALLET_LIST_INDEX_ENUM index)
break;
case WALLET_LIST_KEYSTONE:
// todo add keystone ur logic
- bool isSlip39 = GetMnemonicType() == MNEMONIC_TYPE_SLIP39;
if (isSlip39) {
func = GuiGetKeystoneConnectWalletDataSlip39;
AddCoinsFromArray(g_keystoneWalletCoinArraySlip39, NUMBER_OF_ARRAYS(g_keystoneWalletCoinArraySlip39), false, 0);
Why this scored 15/100
Community notes
Notes can correct, qualify, or add evidence to the AI analysis. Every note shown here has been validated by a human moderator.
The AI analysis stands alone for now. Submit a note if you can add evidence or important context.