What the developer wrote
Authored by aaron
remove the noneeded cancel op
What changed, and why it matters
This commit removes a single function call, FpCancelCurOperate(), from the lock screen's verification loading animation. The function likely cancels any ongoing fingerprint operation before showing a 'please wait' verification hint. Without additional context, it is unclear whether this change fixes a security bug or is simply a cleanup. The commit message gives no security explanation.
Treat as ambiguous. Review the behavior of FpCancelCurOperate() and confirm whether removing it could leave a fingerprint sensor in an active state during seed verification, potentially allowing unintended fingerprint reads. Request a security-impact statement from the vendor or additional commits that clarify the change.
Security signals we found
Fingerprint/ biometric operation cancellation behavior changed
Lock-screen verification flow modified
Commit message is minimal and does not explain security relevance
Evidence from the diff
In src/ui/gui_widgets/gui_lock_widgets.c, the GuiLockScreenShowVerifyLoading() function no longer calls FpCancelCurOperate() before creating an animated hint box during seed verification. The removed call would have aborted the current fingerprint operation. The diff is one-line deletion with no accompanying rationale or references.
Changed components
src/ui/gui_widgets/gui_lock_widgets.cGuiLockScreenShowVerifyLoading()Fingerprint operation handling (FpCancelCurOperate)Inspect captured patch +0 / −1
diff --git a/src/ui/gui_widgets/gui_lock_widgets.c b/src/ui/gui_widgets/gui_lock_widgets.c
index 62a50eb..17911a5 100644
--- a/src/ui/gui_widgets/gui_lock_widgets.c
+++ b/src/ui/gui_widgets/gui_lock_widgets.c
@@ -220,7 +220,6 @@ void GuiLockScreenShowVerifyLoading(void *param)
return;
}
- FpCancelCurOperate();
g_verifyLoadingCont = GuiCreateAnimHintBox(480, 278, 82);
lv_obj_t *title = GuiCreateTextLabel(g_verifyLoadingCont, _("seed_check_wait_verify"));
lv_obj_align(title, LV_ALIGN_BOTTOM_MID, 0, -76);
Why this scored 25/100
Community notes
Notes can correct, qualify, or add evidence to the AI analysis. Every note shown here has been validated by a human moderator.
The AI analysis stands alone for now. Submit a note if you can add evidence or important context.