What the developer wrote
Authored by soralit
feat: modify Lace Wallet
What changed, and why it matters
This commit is a routine user-interface update for the Lace wallet integration. It moves the Lace wallet icon into the 'Bitcoin Wallets' submenu, removes a separate Lace entry that previously showed both Bitcoin and Cardano support, and now lists Lace only under Cardano. There is no security-relevant change in the diff.
No security action required; treat as normal feature/UI maintenance.
Security signals we found
No strong security signals were identified.
Evidence from the diff
The change modifies wallet list metadata in gui_connect_wallet_widgets.c. g_laceCoinArray (containing coinAda and coinBtc) is removed; the Lace wallet entry is changed to use g_adaCoinArray and its filter is narrowed from WALLET_FILTER_BTC | WALLET_FILTER_ADA to WALLET_FILTER_ADA. The Lace icon is added to g_btcWalletCoinArray and to the ‘More BTC Wallets’ hint box. The hardcoded count 5 for g_btcWalletCoinArray is replaced with NUMBER_OF_ARRAYS(...). No cryptographic, parsing, memory-management, or authentication logic is touched.
Changed components
src/ui/gui_widgets/multi/web3/gui_connect_wallet_widgets.cInspect captured patch +4 / −8
diff --git a/src/ui/gui_widgets/multi/web3/gui_connect_wallet_widgets.c b/src/ui/gui_widgets/multi/web3/gui_connect_wallet_widgets.c
index 135afe4..794a567 100644
--- a/src/ui/gui_widgets/multi/web3/gui_connect_wallet_widgets.c
+++ b/src/ui/gui_widgets/multi/web3/gui_connect_wallet_widgets.c
@@ -191,18 +191,13 @@ static const lv_img_dsc_t *g_ThorWalletCoinArray[3] = {
};
static const lv_img_dsc_t *g_btcWalletCoinArray[] = {
- &walletBluewallet, &walletSparrow, &walletZeus, &walletBabylon, &walletBull,
+ &walletBluewallet, &walletSparrow, &walletZeus, &walletBabylon, &walletBull, &walletLace,
};
static const lv_img_dsc_t *g_adaCoinArray[1] = {
&coinAda,
};
-static const lv_img_dsc_t *g_laceCoinArray[] = {
- &coinAda,
- &coinBtc,
-};
-
static const lv_img_dsc_t *g_xrpCoinArray[1] = {
&coinXrp,
};
@@ -222,7 +217,7 @@ WalletListItem_t g_walletListArray[] = {
{WALLET_LIST_NUFI, &walletNufi, "NuFi", g_nufiCoinArray, 5, true, WALLET_FILTER_BTC | WALLET_FILTER_ETH | WALLET_FILTER_SOL | WALLET_FILTER_ADA},
{WALLET_LIST_CORE, &walletCore, "Core Wallet", g_coreCoinArray, 3, true, WALLET_FILTER_BTC | WALLET_FILTER_ETH | WALLET_FILTER_OTHER},
{WALLET_LIST_HELIUM, &walletHelium, "Helium Wallet", g_heliumCoinArray, 2, true, WALLET_FILTER_SOL},
- {WALLET_LIST_BTC_WALLET, &coinBtc, "Bitcoin Wallets", g_btcWalletCoinArray, 5, true, WALLET_FILTER_BTC},
+ {WALLET_LIST_BTC_WALLET, &coinBtc, "Bitcoin Wallets", g_btcWalletCoinArray, NUMBER_OF_ARRAYS(g_btcWalletCoinArray), true, WALLET_FILTER_BTC},
{WALLET_LIST_TONKEEPER, &walletTonkeeper, "Tonkeeper", g_tonKeeperCoinArray, 1, false, WALLET_FILTER_OTHER},
{WALLET_LIST_RABBY, &walletRabby, "Rabby", g_ethWalletCoinArray, 4, true, WALLET_FILTER_ETH},
{WALLET_LIST_NABOX, &walletNabox, "Nabox", g_naboxWalletCoinArray, 7, true, WALLET_FILTER_BTC | WALLET_FILTER_ETH | WALLET_FILTER_SOL | WALLET_FILTER_OTHER},
@@ -230,7 +225,7 @@ WalletListItem_t g_walletListArray[] = {
{WALLET_LIST_ETERNL, &walletEternl, "Eternl", g_adaCoinArray, 1, true, WALLET_FILTER_ADA},
{WALLET_LIST_VESPR, &walletVespr, "Vespr", g_adaCoinArray, 1, true, WALLET_FILTER_ADA},
{WALLET_LIST_BEGIN, &walletBegin, "Begin", g_adaCoinArray, 1, true, WALLET_FILTER_ADA},
- {WALLET_LIST_LACE, &walletLace, "Lace", g_laceCoinArray, 2, true, WALLET_FILTER_BTC | WALLET_FILTER_ADA},
+ {WALLET_LIST_LACE, &walletLace, "Lace", g_adaCoinArray, 1, true, WALLET_FILTER_ADA},
{WALLET_LIST_UNISAT, &walletUniSat, "UniSat", g_UniSatCoinArray, 5, true, WALLET_FILTER_BTC},
{WALLET_LIST_SUIET, &walletSuiet, "Suiet", g_suiWalletCoinArray, 1, true, WALLET_FILTER_OTHER},
{WALLET_LIST_IOTA, &walletIota, "IOTA Wallet", g_iotaCoinArray, 1, true, WALLET_FILTER_OTHER},
@@ -1021,6 +1016,7 @@ static void OpenMoreBtcWalletsHandler(lv_event_t *e)
{.name = "ZEUS", .src = &walletZeus, .callBack = NULL, NULL},
{.name = _("connect_babylon_title"), .src = &walletBabylon, .callBack = NULL, NULL},
{.name = BULL_WALLET_TITLE, .src = &walletBull, .callBack = NULL, NULL},
+ {.name = "Lace", .src = &walletLace, .callBack = NULL, NULL},
};
g_noticeWindow = GuiCreateMoreInfoHintBox(NULL, NULL, moreInfoTable, NUMBER_OF_ARRAYS(moreInfoTable), true, &g_noticeWindow);
Why this scored 15/100
Community notes
Notes can correct, qualify, or add evidence to the AI analysis. Every note shown here has been validated by a human moderator.
The AI analysis stands alone for now. Submit a note if you can add evidence or important context.