fix: remove duplicate SIG_BACKGROUND_UR_GENERATE_FAIL enumerator
What the developer wrote
Authored by Adam Tucker
fix: remove duplicate SIG_BACKGROUND_UR_GENERATE_FAIL enumerator
The batch-signing change added a second SIG_BACKGROUND_UR_GENERATE_FAIL to
the GUI signal enum, which already defines it a few lines above. A duplicate
enumerator is a C redefinition error, and gui_views.h is included across the
UI layer, so the firmware would fail to build. Drop the duplicate.
What changed, and why it matters
This commit removes a duplicate entry in a list of internal software signal names used by the device's user interface. The duplicate would have caused the firmware to fail compilation, so the change is a straightforward build fix with no security relevance.
No security action required; treat as a normal build-fix commit.
Security signals we found
No strong security signals were identified.
Evidence from the diff
The patch deletes a redundant enumerator SIG_BACKGROUND_UR_GENERATE_FAIL from src/ui/gui_views/gui_views.h. The enum already contained the same constant a few lines earlier, making the duplicate a C redefinition error that prevented compilation. No logic, behavior, or data handling is changed.
Changed components
src/ui/gui_views/gui_views.hInspect captured patch +0 / −1
diff --git a/src/ui/gui_views/gui_views.h b/src/ui/gui_views/gui_views.h
index a86d7bd..38c9d78 100644
--- a/src/ui/gui_views/gui_views.h
+++ b/src/ui/gui_views/gui_views.h
@@ -143,7 +143,6 @@ typedef enum {
SIG_BACKGROUND_UR_GENERATE_SUCCESS,
SIG_BACKGROUND_UR_GENERATE_FAIL,
SIG_BACKGROUND_UR_UPDATE,
- SIG_BACKGROUND_UR_GENERATE_FAIL,
SIG_BACKGROUND_UR_BUTT,
SIG_TRANSACTION_CHECK_PASS = SIG_BACKGROUND_UR_BUTT + 50,
Why this scored 15/100
Community notes
Notes can correct, qualify, or add evidence to the AI analysis. Every note shown here has been validated by a human moderator.
The AI analysis stands alone for now. Submit a note if you can add evidence or important context.