Merge pull request #746 from Foundation-Devices/sft-8260-evaluate-miniscript-no-compatible-path
What changed, and why it matters
This commit only changes the wording of an on-screen warning message shown to users when a Bitcoin transaction's timelock conditions are not yet met. It does not change any security logic, validation, or behavior. The old message said no spending path was compatible with the transaction; the new message explains more precisely that the transaction fails a timelock and will be rejected by the network. A corresponding test was updated to expect the new text.
No security action needed. This is a documentation/UX string change.
Security signals we found
No strong security signals were identified.
Evidence from the diff
The diff updates a user-facing string in policy_display.py and the matching assertion string in a host-side test. The function format_signing_pages() still returns the same tuple structure and still short-circuits when filtered paths are empty. No code paths, cryptographic checks, Miniscript evaluation, or policy validation were modified.
Changed components
ports/stm32/boards/Passport/modules/policy_display.pyports/stm32/boards/Passport/modules/tests/host/test_wallet_policy_flows.pyInspect captured patch +5 / −4
### ports/stm32/boards/Passport/modules/policy_display.py
@@ -685,8 +685,9 @@ def format_signing_pages(policy, compatible_indexes=None):
if 0 <= index < len(all_paths))
if not filtered:
return (('Wallet\n{}\n\n'
- 'At least one input has no spending path compatible with this transaction.\n\n'
- 'Signing does not make it spendable. Check the transaction in your wallet app.')
+ "This transaction doesn't meet the timelock on any spending path "
+ 'for at least one input. The network will reject it even if you sign it.\n\n'
+ 'Rebuild the transaction in your wallet app.')
.format(_escape(policy.name)),)
paths = filtered
simple = _classify_simple_inheritance(policy, paths)
### ports/stm32/boards/Passport/modules/tests/host/test_wallet_policy_flows.py
@@ -39,8 +39,8 @@ def flow_method(filename, class_name, method_name):
@pytest.mark.parametrize('compatible_sets,expected', [
([], 'could not be checked'),
- ([()], 'no spending path compatible'),
- ([(0,), ()], 'no spending path compatible'),
+ ([()], 'The network will reject it'),
+ ([(0,), ()], 'The network will reject it'),
([(0,), (1,)], 'Inputs allow different spending paths'),
([(0,), (0,)], 'Spend now (1-of-1)'),
])Why this scored 15/100
Community notes
Notes can correct, qualify, or add evidence to the AI analysis. Every note shown here has been validated by a human moderator.
The AI analysis stands alone for now. Submit a note if you can add evidence or important context.