AI-generated analysisPublished automatically and not human-verified. Validated context appears in community notes below.
← Watch feed
Low 31 Bitcoin

Merge pull request #717 from Foundation-Devices/sft-8249-passport-core-psbt-error-text-loses-characters-to-lvgl

Public commit record

What the developer wrote

Authored by mjg-foundation

73/100 · Adequate
Merge pull request #717 from Foundation-Devices/sft-8249-passport-core-psbt-error-text-loses-characters-to-lvgl

SFT-8249: escape PSBT error text before displaying it
✓ Specific, descriptive subject✓ Names a concrete action or component✓ Provides an explanatory body✓ Links an issue, advisory, or supporting reference
The short version

What changed, and why it matters

This commit fixes a display bug in the Passport hardware wallet where error messages about Bitcoin transaction files (PSBTs) could lose important text, such as input numbers, because the screen-rendering library treats the '#' character as a color-code marker. The fix escapes every '#' so the full error message is shown to the user. It is primarily a usability and information-integrity issue rather than a direct theft-of-funds vulnerability, because the error still blocks signing; however, a malformed PSBT could hide or alter the visible reason for refusal.

Recommended action

Review whether other user-facing labels in the signing and validation flows also render untrusted strings with recolor enabled, and apply escape_text() consistently. Consider a defense-in-depth measure such as disabling recolor on labels that display dynamic error text.

Security signals we found

01

UI text truncation due to unescaped markup metacharacter

02

Error-message integrity issue in security-critical signing flow

03

Potential for crafted PSBT to influence displayed failure reason

04

Display-layer parsing ambiguity between data and control characters

Risk score

Why this scored 31/100

Our methodology →
Potential impact 5/30
Exploitability 4/25
Stealth signal 6/15
Affected reach 5/15
Confidence 7/10
Evidence quality 4/5
Human-validated context

Community notes

Notes can correct, qualify, or add evidence to the AI analysis. Every note shown here has been validated by a human moderator.

No validated notes yet.

The AI analysis stands alone for now. Submit a note if you can add evidence or important context.