AI-generated analysisPublished automatically and not human-verified. Validated context appears in community notes below.
← Watch feed
Moderate 60 Bitcoin

Merge pull request #736 from Foundation-Devices/sft-8554-bootloader-setup-checks

Public commit record

What the developer wrote

Authored by mjg-foundation

58/100 · Thin
Merge pull request #736 from Foundation-Devices/sft-8554-bootloader-setup-checks

SFT-8554: bootloader setup tidy-ups
✓ Specific, descriptive subject✓ Names a concrete action or component✓ Links an issue, advisory, or supporting reference! No meaningful explanatory body
The short version

What changed, and why it matters

This commit hardens how Passport's bootloader handles a sensitive factory key during initial device setup. Previously, the code trusted that erasing the key from SPI flash succeeded without checking, and it left a temporary copy of the key sitting in memory after use. The patch now verifies the key is actually gone from flash, retries the erase if needed, and wipes the temporary memory copy immediately. It also adds automated tests that simulate failures to make sure the key is never left behind.

Recommended action

Treat this as a security hardening fix and include it in the next bootloader/firmware release. Run the new host tests regularly in CI. Consider whether older devices that already went through factory setup could have left the SCV key in SPI flash due to the unverified erase, and evaluate whether any additional remediation (e.g., a one-time secure-wipe or attestation check) is warranted for already-shipped units.

Security signals we found

01

Sensitive key material (supply-chain validation key) is now explicitly zeroed from stack memory after use

02

SPI flash erase of the SCV key is now verified by read-back instead of assumed successful

03

Bootloader setup now aborts if the SCV key cannot be confirmed erased from SPI flash

04

Retry loop added for SPI erase/read failures to tolerate transient hardware errors

05

New host-side C unit tests exercise failure paths including failed reads, failed erases, and unconfirmed clears

Risk score

Why this scored 60/100

Our methodology →
Potential impact 18/30
Exploitability 12/25
Stealth signal 8/15
Affected reach 10/15
Confidence 8/10
Evidence quality 4/5
Human-validated context

Community notes

Notes can correct, qualify, or add evidence to the AI analysis. Every note shown here has been validated by a human moderator.

No validated notes yet.

The AI analysis stands alone for now. Submit a note if you can add evidence or important context.