AI-generated analysisPublished automatically and not human-verified. Validated context appears in community notes below.
← Watch feed
Low 29 Bitcoin

Merge pull request #725 from Foundation-Devices/SFT-7375-paginate-transaction-details

Public commit record

What the developer wrote

Authored by mjg-foundation

73/100 · Adequate
Merge pull request #725 from Foundation-Devices/SFT-7375-paginate-transaction-details

SFT-7375: switched from scrolling to pagination for transaction reviews
✓ Specific, descriptive subject✓ Names a concrete action or component✓ Provides an explanatory body✓ Links an issue, advisory, or supporting reference
The short version

What changed, and why it matters

This commit changes how the Passport hardware wallet displays transaction details during signing. Instead of one long scrolling screen, it now breaks the review into separate pages and requires the user to scroll to the bottom of each page before pressing forward. This is a user-interface hardening change meant to make sure people actually see all transaction details and warnings before approving. It is not a fix for a remote exploit or a cryptographic bug, but it does reduce the chance that a user accidentally approves a bad transaction because important information was hidden off-screen.

Recommended action

Treat as a security-hardening improvement rather than an emergency patch. Review the scroll-gate implementation for edge cases (very short pages, dynamic layout updates, and event-callback removal on detach) and ensure the pagination order cannot be skipped or reordered by a malicious PSBT. Continue running the new transaction_review.py unit tests in CI.

Security signals we found

01

UI anti-tampering: require_scroll_to_end prevents users from advancing until all page content has been viewed

02

Pagination splits transaction outputs, change, fees, and warnings into separate screens, reducing hidden-off-screen content

03

Adds unit and UI tests for review pagination and scroll-gate behavior

04

Removes old aggregate render_warnings() in favor of per-page rendering

Risk score

Why this scored 29/100

Our methodology →
Potential impact 5/30
Exploitability 3/25
Stealth signal 4/15
Affected reach 6/15
Confidence 7/10
Evidence quality 4/5
Human-validated context

Community notes

Notes can correct, qualify, or add evidence to the AI analysis. Every note shown here has been validated by a human moderator.

No validated notes yet.

The AI analysis stands alone for now. Submit a note if you can add evidence or important context.