What the developer wrote
Authored by Matt Gleason
SFT-5988: bumped debounce time
What changed, and why it matters
This commit increases the keypad debounce time from 20 to 120 time units. Debouncing is a normal hardware/software fix to prevent a single physical button press from being registered multiple times. The change is very small and routine, with no direct evidence of a security vulnerability.
No security action required. Treat as normal firmware maintenance. If concerned, verify that the longer debounce window does not introduce unintended UI behavior such as missed double-press inputs.
Security signals we found
Single-line timing threshold change in input handling
No mention of security, vulnerability, researcher, or CVE in commit message
No supplied verified references
Change is consistent with routine hardware debounce tuning
Evidence from the diff
The patch modifies modpassport_lv-keypad.h, changing the threshold in the keypad input device’s release-time filter from 20 to 120. When a key press occurs shortly after a release, the code sets a flag to ignore the next release. Increasing this window makes the debounce filter more tolerant of noisy or bouncy key contacts. There is no explicit security context in the commit or supplied references.
Changed components
ports/stm32/boards/Passport/modpassport_lv-keypad.hPassport device keypad input driverInspect captured patch +1 / −1
diff --git a/ports/stm32/boards/Passport/modpassport_lv-keypad.h b/ports/stm32/boards/Passport/modpassport_lv-keypad.h
index 03a30db..eee2139 100644
--- a/ports/stm32/boards/Passport/modpassport_lv-keypad.h
+++ b/ports/stm32/boards/Passport/modpassport_lv-keypad.h
@@ -291,7 +291,7 @@ STATIC void mod_passport_lv_Keypad_read_cb(lv_indev_drv_t* drv, lv_indev_data_t*
}
if (from_keypad) {
- if (is_pressed && key_time - key_filter[key_index].release_time < 20) {
+ if (is_pressed && key_time - key_filter[key_index].release_time < 120) {
key_filter[key_index].eat_next_release = true;
return;
}
Why this scored 11/100
Community notes
Notes can correct, qualify, or add evidence to the AI analysis. Every note shown here has been validated by a human moderator.
The AI analysis stands alone for now. Submit a note if you can add evidence or important context.