AI-generated analysisPublished automatically and not human-verified. Validated context appears in community notes below.
← Watch feed
Moderate 64 Bitcoin

Merge pull request #681 from Foundation-Devices/SFT-7377-harden-utxo-history

Public commit record

What the developer wrote

Authored by mjg-foundation

58/100 · Thin
Merge pull request #681 from Foundation-Devices/SFT-7377-harden-utxo-history

SFT-7377: harden utxo history
✓ Specific, descriptive subject✓ Names a concrete action or component✓ Links an issue, advisory, or supporting reference! No meaningful explanatory body
The short version

What changed, and why it matters

This commit hardens how Passport remembers past Bitcoin input amounts. Previously, the device could record an unverified amount from a rejected or malicious transaction, then later compare a real transaction against that poisoned value and wrongly reject it. The fix only saves amounts after a signature succeeds, rejects duplicate inputs earlier, and adds a user menu to clear the saved amounts. It is a defensive hardening patch rather than a remote exploit fix.

Recommended action

Treat as a security-relevant hardening fix. Review that no other code paths still call OutptValueCache.add or verify_amount in a way that records rejected PSBT data, and confirm the duplicate-input check covers all input iteration paths. Consider whether a CVE is warranted given the device could be tricked into rejecting legitimate user transactions.

Security signals we found

01

SegWit input amount cache could be poisoned by unapproved/rejected PSBTs

02

Duplicate prevouts accepted before signing could enable amount-cache confusion

03

Amount recording moved to post-success signature path

04

New user-facing cache-clear flow added

05

Unit tests explicitly model malicious coordinator scenarios

Risk score

Why this scored 64/100

Our methodology →
Potential impact 18/30
Exploitability 12/25
Stealth signal 10/15
Affected reach 12/15
Confidence 8/10
Evidence quality 4/5
Human-validated context

Community notes

Notes can correct, qualify, or add evidence to the AI analysis. Every note shown here has been validated by a human moderator.

No validated notes yet.

The AI analysis stands alone for now. Submit a note if you can add evidence or important context.