AI-generated analysisPublished automatically and not human-verified. Validated context appears in community notes below.
← Watch feed
Moderate 60 Bitcoin

Merge pull request #742 from Foundation-Devices/sft-8530-distinct-cosigners

Public commit record

What the developer wrote

Authored by mjg-foundation

73/100 · Adequate
Merge pull request #742 from Foundation-Devices/sft-8530-distinct-cosigners

SFT-8530: require distinct cosigner keys on multisig import
✓ Specific, descriptive subject✓ Names a concrete action or component✓ Provides an explanatory body✓ Links an issue, advisory, or supporting reference
The short version

What changed, and why it matters

This update to the Passport hardware wallet firmware adds a safety check when importing multi-signature wallet configurations. Previously, the same cosigner public key could be listed more than once under different fingerprints or address formats. Now the device rejects duplicate cosigner keys, preventing a user from being tricked into thinking they have an independent cosigner when they actually do not. This is a security hardening fix for a logic flaw in multisig import validation.

Recommended action

Review whether the same duplicate-cosigner check is also applied during PSBT signing and descriptor-based imports, and consider adding integration tests for those paths. Ensure the assertion is surfaced to the user as a clear error rather than a crash.

Security signals we found

01

Adds duplicate-key detection during multisig wallet import

02

Compares raw public-key x-coordinates rather than fingerprints or encoded xpub strings

03

Prevents a single key from being counted as multiple independent cosigners

04

Includes a new unit test covering same-key-different-fingerprint and same-key-different-format cases

Risk score

Why this scored 60/100

Our methodology →
Potential impact 18/30
Exploitability 12/25
Stealth signal 10/15
Affected reach 8/15
Confidence 8/10
Evidence quality 4/5
Human-validated context

Community notes

Notes can correct, qualify, or add evidence to the AI analysis. Every note shown here has been validated by a human moderator.

No validated notes yet.

The AI analysis stands alone for now. Submit a note if you can add evidence or important context.