AI-generated analysisPublished automatically and not human-verified. Validated context appears in community notes below.
← Watch feed
Low 44 Bitcoin

Merge pull request #728 from Foundation-Devices/SFT-3834-message-signing-microsd-length

Public commit record

What the developer wrote

Authored by mjg-foundation

73/100 · Adequate
Merge pull request #728 from Foundation-Devices/SFT-3834-message-signing-microsd-length

SFT-3834: restored newline support in messages being signed, increased
✓ Specific, descriptive subject✓ Names a concrete action or component✓ Provides an explanatory body✓ Links an issue, advisory, or supporting reference
The short version

What changed, and why it matters

This firmware update changes how the Passport hardware wallet handles message signing. It restores the ability to sign messages containing newlines (which had been blocked), increases the maximum microSD message file size from 240 to 4096 bytes, and adds a warning when a message ends in invisible whitespace. The core risk is that invisible characters at the end of a message, or a very long message that the user cannot fully review, could lead someone to sign something different from what they think they saw. The patch adds safeguards (footer warning, forced scrolling to the end) rather than removing all restrictions.

Recommended action

Treat this as a security-hardening feature change rather than a vulnerability fix. Review whether 4096 bytes is still short enough for users to reliably inspect the entire message, and verify that require_scroll_to_end cannot be bypassed. Consider localizing the new footer warning text before release.

Security signals we found

01

Restored newline support in signed messages after previous restriction

02

Increased microSD message signing length limit from 240 to 4096 bytes

03

Added footer warning for messages ending in invisible whitespace

04

Added require_scroll_to_end on message review pages

05

Continues to reject control characters, NUL, DEL, non-ASCII, and RTL override characters

06

Electrum-format messages parsed by splitting on spaces, not lines, to preserve signed bytes

Risk score

Why this scored 44/100

Our methodology →
Potential impact 12/30
Exploitability 8/25
Stealth signal 7/15
Affected reach 6/15
Confidence 7/10
Evidence quality 4/5
Human-validated context

Community notes

Notes can correct, qualify, or add evidence to the AI analysis. Every note shown here has been validated by a human moderator.

No validated notes yet.

The AI analysis stands alone for now. Submit a note if you can add evidence or important context.