AI-generated analysisPublished automatically and not human-verified. Validated context appears in community notes below.
← Watch feed
Low 49 Bitcoin

SFT-8316: prevented null truncation in op_return messages

Public commit record

What the developer wrote

Authored by Matt Gleason

50/100 · Thin
SFT-8316: prevented null truncation in op_return messages
✓ Specific, descriptive subject✓ Names a concrete action or component! No meaningful explanatory body
The short version

What changed, and why it matters

This commit fixes a display bug in Passport's Bitcoin signing flow. When a transaction contains an OP_RETURN message with a hidden NUL (zero-value) byte, the device's screen would silently cut off everything after that byte. An attacker could craft a message that looks short or harmless on the device, while the real message the user is approving is actually longer or different. The fix now detects NUL bytes and shows the message as raw hex instead, so the full content is visible.

Recommended action

Treat as a low-to-moderate UI integrity issue. Review whether other user-facing string fields (memos, labels, address notes, etc.) are also rendered through LVGL without NUL handling. Consider a broader policy of hex-escaping or rejecting NUL bytes in any attacker-influenced display text.

Security signals we found

01

UI truncation of embedded NUL bytes can hide part of an OP_RETURN payload from the user

02

User-visible message may not match the data actually being signed

03

OP_RETURN messages are attacker-controlled data included in transactions

04

Fix is defensive: force hex display when NUL bytes are present

Risk score

Why this scored 49/100

Our methodology →
Potential impact 12/30
Exploitability 10/25
Stealth signal 8/15
Affected reach 7/15
Confidence 8/10
Evidence quality 4/5
Human-validated context

Community notes

Notes can correct, qualify, or add evidence to the AI analysis. Every note shown here has been validated by a human moderator.

No validated notes yet.

The AI analysis stands alone for now. Submit a note if you can add evidence or important context.